Show differencesHistory of post edits
#2RobinsonUK
Posted 14 April 2012 - 11:19 AM
Not sure why you're loading the shader like this:
I mean getting a line and then appending a newline seems a bit pointless. I would write something like:
ifstream FragmentShaderStream(Fragment_file_path, std::ios::in);
if(FragmentShaderStream.is_open())
{
string Line = "";
while(getline(FragmentShaderStream, Line))
FragmentShaderCode += "\n" + Line;
FragmentShaderStream.close();
}
I mean getting a line and then appending a newline seems a bit pointless. I would write something like:
/* static */
void
FileReader::Read(std::string const & path, std::string & output)
{
[indent=1]
// Open stream.[/indent]
[indent=1]std::ifstream stream(path, std::ios::in);[/indent]
[indent=1]// Read into buffer.[/indent]
[indent=1]std::stringstream buffer;[/indent]
[indent=1]buffer << stream.rdbuf();[/indent]
[indent=1]// Assign result.[/indent]
[indent=1]output = buffer.str();[/indent]
[indent=1]stream.close();[/indent]
}
#1RobinsonUK
Posted 14 April 2012 - 11:19 AM
Not sure why you're loading the shader like this:
I mean getting a line and then appending a newline seems a bit pointless. I would write something like:
ifstream FragmentShaderStream(Fragment_file_path, std::ios::in);
if(FragmentShaderStream.is_open())
{
string Line = "";
while(getline(FragmentShaderStream, Line))
FragmentShaderCode += "\n" + Line;
FragmentShaderStream.close();
}
I mean getting a line and then appending a newline seems a bit pointless. I would write something like:
/* static */
void
FileReader::Read(std::string const & path, std::string & output)
{
[indent=1]
// Open stream.[/indent]
[indent=1]std::ifstream stream(path, std::ios::in);[/indent]
[indent=1]// Read into buffer.[/indent]
[indent=1]std::stringstream buffer;[/indent]
[indent=1]buffer << stream.rdbuf();[/indent]
[indent=1]// Assign result.[/indent]
[indent=1]output = buffer.str();[/indent]
[indent=1]stream.close();[/indent]
}