Jump to content

  • Log In with Google      Sign In   
  • Create Account


#ActualZomgbie

Posted 20 September 2013 - 03:25 AM

Hello people!

 

Last year i started my employment at a new company. Things have been going great, or so i thought. At a recent developers meeting i received quite a lot of critique for how i write my code. Now, i can accept that i have to adjust to a new code structure, but somethings just feels so wrong. For example, this is how i'd write an if statement:

if ($variable == "condition")
        doAction();

I was told that this is wrong and wont work, simply because the PHP log picked up an error at this line once. The error was actually caused by a missing quotation mark. So i was instructed to always encase my if statments like so:

if($variable=='condition') {
        $do_action();
}

And i just find it so hard to accept this. Sure, if he could give me a real reason to adjust to his personal coding style, i would. But blaming it on that it's "wrong and won't work" just pisses me off...

 

And then there is the question of coding software. I've always been using an OpenBSD box, with vim as my prefered editor. Sadly i was told that this is wrong too and i have to use Dreamweaver on Windows, because it's faster and "better".

 

How would you deal with this? I actually went to talk with my boss, but he said i have to accept these changes as the lead developer is way more experienced then me. Sadly i've lost a lot of productive code hours only to getting used to Dreamweaver and rewriting my code to follow his examples. What would you do? Am i just being stupid because i don't like the way he codes?


#1Zomgbie

Posted 20 September 2013 - 03:04 AM

Hello people!

 

Last year i started my employment at a new company. Things have been going great, or so i thought. At a recent developers meeting i received quite a lot of critique for how i write my code. Now, i can accept that i have to adjust to a new code structure, but somethings just feels so wrong. For example, this is how i'd write an if statement:

if ($variable == "condition")
        doAction();

I was told that this is wrong and wont work, simply because the PHP log picked up an error at this line once. The error was actually caused by a missing quotation mark. So i was instructed to always encase my if statments like so:

if($variable=='condition') {
        $do_action();
}

And i just find it so hard to accept this. Sure, if he could give me a real reason to adjust to his personal coding style, i would. But blaming it on that it's "wrong and won't work" just pisses me off...

 

And then there is the question of coding software. I've always been using an OpenBSD box, with vim as my prefered editor. Sadly i was told that this is wrong too and i have to use Dreamweaver on Windows, because it's faster and "better".

 

How would you deal with this? I actually went to talk with my boss, but he said i have to accept these changes as the lead developer is way more experienced then me. Sadly i've lost a lot of productive code hours only to getting used to Dreamweaver and rewriting my code to follow his examples. What would you do? Am i just being stupid because i don't like the way he codes?


PARTNERS