Back to General and Gameplay Programming

is there a better design for this interface?

xDan · 2010-05-27T06:41:47

Hi. I'm making an interface for things that are "pausable" in my game. Originally I had this - class IPausable { public: virtual ~IPausable(){} virtual void Pause() = 0; virtual void Resume() = 0; virtual bool IsPaused() = 0; }; But now I've realised I need a kind of pause counter system, so that for example if Pause is called twice from different areas of code, then two calls of Resume should be required to un-pause the object. Now I'm thinking about this design - class IPausable { u32 pauseCounter; public: IPausable() { pauseCounter = 0; } virtual ~IPausable(){} void Pause() { if (pauseCounter == 0) OnPause(); pauseCounter ++; } void Resume() { pauseCounter --; if (pauseCounter == 0) OnResume(); } bool IsPaused() { return pauseCounter > 0; } private: virtual void OnPause() = 0; virtual void OnResume() = 0; }; So now pause/resume logic in derived classes must be implemented in the OnPause, OnResume methods, and the top level IPausable interface handles the pause counting. However, this approach feels a bit wrong and hackish, to have the implementation code in the interface. I feel that perhaps I should have a separate PauseCounter class, which owns an IPausable class, or something, so pause counting is separated. Having said that, the solution above will work very nicely. Perhaps I am just being silly? :)

General and Gameplay Programming Programming

Started by xDan May 26, 2010 05:57 AM

11 comments, last by AlexKhomich 13 years, 10 months ago

Acid-Chris

504

May 27, 2010 02:34 AM

virtual bool IsPaused() = 0;

Just as a sidenote, you should really make the method 'const':

virtual bool IsPaused() const = 0;

xDan

194

Author

May 27, 2010 03:45 AM

Ok. I am now using ref counting. I'm still interested if there is any better design for the ref counting class though. Possibly there isn't.

XZIST.org :: Garnet Games

AlexKhomich

100

May 27, 2010 06:41 AM

I like option with interface IPausable, its implementation in class Pausable for further reuse.

Also there are a bit of correction for your second variant of IPausable. Events OnPause/OnResume should be protected in other way you can't inherit that class.

is there a better design for this interface?

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

is there a better design for this interface?

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

Reticulating splines