Jump to content

  • Log In with Google      Sign In   
  • Create Account

Problem with simple SSAO implementation


Old topic!
Guest, the last post of this topic is over 60 days old and at this point you may not reply in this topic. If you wish to continue this conversation start a new topic.

  • You cannot reply to this topic
2 replies to this topic

#1 ArthurD   Members   -  Reputation: 100

Like
0Likes
Like

Posted 15 January 2012 - 03:56 AM

Hello everyone,

I have been trying to implement the simple SSAO described here : http://www.gamedev.n...h-to-ssao-r2753 inside a DirectX demo, but so far I have not been able to make it work. (The demo is based on Humus Framework).
Edit : I forgot to state that this demo uses inverted z (far plane is z = 0, near plane is z = 1). I don't know if it is relevant with the problem I am encountering though.

Here are the steps that I take in order to prepare the textures used for the SSAO :

During my deferred rendering pass, I compute a position in View Space in the vertex shader, VPosition :

Out.Position  = mul(ViewProj, In.Position);
Out.VPosition = mul(View, In.Position);

and in the Pixel Shader, I compute a normal from it :

Out.VNormal = normalize(cross(ddx(In.VPosition.xyz), ddy(In.VPosition.xyz)));
Out.Position = In.VPosition;

Position and VNormal are 2 render targets using the format DXGI_FORMAT_R11G11B10_FLOAT.

In the SSAO pass, those 2 render targets are fed as input textures to the shader. In order to understand what is going wrong, I have kept only the smallest step from the algorithm. So here, I am computing the diff vector between the point located at (x+1,y) and the current point, and I look at the dot product between this diff and the normal.
I would expect that every point on a plane surface should have 0 for this dot product, except if they are at the edge.

Texture2D <float4> Base;
Texture2D <float3> Positions;
Texture2D <float3> VNormals;
SamplerState Filter;

float4 main(PsIn In) : SV_Target
{
float4 base = Base.Sample(Sam, In.texCoord);

const float2 vec[4] = {float2(1,0),float2(-1,0),
			float2(0,1),float2(0,-1)};

float3 p = Positions.Sample(Filter, In.texCoord);
float3 n = VNormals.Sample(Filter, In.texCoord);
n = normalize(n);

float2 coord1 = vec[0];

float3 diff = Positions.Sample(Filter, In.texCoord + coord1) - p;
const float3 v = normalize(diff);

base.rgb = float3(dot(n,v),dot(n,v),dot(n,v));

return base;
}

However, as you can see on this screen, this dot product is not at all what I expected it to be, so in turn it is not surprising that the SSAO doesn't work at all. Any help would be appreciated !

Posted Image

If it can be helpful, here is the VNormals texture.

Posted Image

Sponsor:

#2 Tsus   Members   -  Reputation: 1061

Like
1Likes
Like

Posted 15 January 2012 - 05:23 AM

Hi!

I think, when you sample the neighbor positions you are jumping too far. Texture coordinates are living in [0,1]x[0,1]. So, you should actually take a step of size 1/width in x-direction and 1/height in y-direction.
So here we go:
int2 dim;
Positions.GetDimensions(dim.x, dim.y);
float2 stepSize = 1.0 / dim;
float3 diff = Positions.Sample(Filter, In.texCoord + coord1 * stepSize) - p;

You could also pass 1/width and 1/height to the shader as constants.
However, with that small code piece you can find out whether that’s the problem or not.

If you would use the Load intrinsics you'd have to specify the offset in pixels, though. If you don't need a sampler (i.e. filtering) you should always use Load, since it is faster.

Cheers!

#3 ArthurD   Members   -  Reputation: 100

Like
0Likes
Like

Posted 15 January 2012 - 10:01 AM

Thanks a lot!

This explains why I would get nothing if I didn't wrap my sampler. I can continue with the implementation with this issue solved.




Old topic!
Guest, the last post of this topic is over 60 days old and at this point you may not reply in this topic. If you wish to continue this conversation start a new topic.



PARTNERS