Jump to content

  • Log In with Google      Sign In   
  • Create Account


Trouble Smoothly Moving Player Sprite


Old topic!
Guest, the last post of this topic is over 60 days old and at this point you may not reply in this topic. If you wish to continue this conversation start a new topic.

  • You cannot reply to this topic
6 replies to this topic

#1 CaptainKraft   Members   -  Reputation: 265

Like
0Likes
Like

Posted 06 July 2012 - 03:11 PM

I'm having trouble smoothing out the movement of a player in the game I'm working on. I've just started screwing around with Java2D stuff so it's all very basic fyi.

The problem is that my player stops moving when changing to the opposite direction. Here's an example to explain it further:

When I hold 'D' to move the player right, then push and hold 'A' to change direction, everything works fine. However, when I release 'A' while still holding 'D', my player stops instead of going back to the right. This is clearly because I haven't pressed 'D' again, but I want him to move as long as I'm holding the key, not just when I press it.

I hope that makes sense, and here is the relevant code (hopefully I get it all in here). Any help would be greatly appreciated. Thanks

Here is the key even stuff.
[source lang="java"] // key event stuff addKeyListener(new KeyAdapter(){ public void keyPressed(KeyEvent ke){ if(ke.getKeyCode() == KeyEvent.VK_W){ p1.playerDirections(Player.MOVE_UP); } if(ke.getKeyCode() == KeyEvent.VK_S){ p1.playerDirections(Player.MOVE_DOWN); } if(ke.getKeyCode() == KeyEvent.VK_A){ p1.playerDirections(Player.MOVE_LEFT); } if(ke.getKeyCode() == KeyEvent.VK_D){ p1.playerDirections(Player.MOVE_RIGHT); } } public void keyReleased(KeyEvent ke){ if(ke.getKeyCode() == KeyEvent.VK_W){ p1.stopY(); } if(ke.getKeyCode() == KeyEvent.VK_S){ p1.stopY(); } if(ke.getKeyCode() == KeyEvent.VK_A){ p1.stopX(); } if(ke.getKeyCode() == KeyEvent.VK_D){ p1.stopX(); } } public void keyTyped(KeyEvent ke){ } }); }[/source]
Here is the player class stuff:

[source lang="java"] public Player(World w){ world = w; playerImg = new ImageIcon("res/player.png").getImage(); playerRect = new Rectangle(50, 50, playerWidth, playerHeight); } private void setXDir(int dir){ xDir = dir; } private void setYDir(int dir){ yDir = dir; } public void update(){ } public void draw(Graphics g){ g.drawImage(playerImg, playerRect.x, playerRect.y, playerWidth, playerHeight, null); } // setting directions for player movement public void playerDirections(int nav){ switch(nav){ default: System.out.println("That is not a valid entry for changing maps."); case MOVE_UP: setYDir(-1); break; case MOVE_DOWN: setYDir(1); break; case MOVE_LEFT: setXDir(-1); break; case MOVE_RIGHT: setXDir(1); break; } } // move player based on directions // methods for controlling movement public void move(){ playerRect.x += xDir; playerRect.y += yDir; } public void stopX(){ setXDir(0); } public void stopY(){ setYDir(0); }[/source]

Sponsor:

#2 DevLiquidKnight   Members   -  Reputation: 834

Like
0Likes
Like

Posted 06 July 2012 - 03:17 PM

One suggestion I have is to use physics to make the movement instead of moving the sprites statically unless your trying to get that look. Then you can just apply impulses to move your sprite around. You will get much smoother movement, by updating your sprite this way, and it will look more realistic. Check out this link.

Edited by DevLiquidKnight, 06 July 2012 - 03:20 PM.


#3 Pash   Members   -  Reputation: 233

Like
0Likes
Like

Posted 09 July 2012 - 07:20 AM

It's because the way you are handling moving your player around the screen with the KeyEvent class.....is the simple answer.

You havent mentioned in your post in any way - why you think this unexpected result is happening (as in the player just stops). Read the code back to yourself and then tell us why.

We would need to see your complete code to give more suggestions. You are probably using an AL for example.

Hint: There will be several changes to make to the different class files.
Please Add Rep if I helped // Working on untitled 2D platformer (more to come soon)
Twitter - @MarkPashby

#4 Narf the Mouse   Members   -  Reputation: 318

Like
0Likes
Like

Posted 10 July 2012 - 04:46 PM

Your code is being executed when a key is triggered or released. Try checking when a key is pressed (which is what you want, after all).

#5 eFoDay   Members   -  Reputation: 300

Like
2Likes
Like

Posted 11 July 2012 - 12:24 PM

You could try separating the movement from the key listener:

[source lang="cpp"] // key event stuff addKeyListener(new KeyAdapter(){ public void keyPressed(KeyEvent ke){ if(ke.getKeyCode() == KeyEvent.VK_W){ bMoveUp = true; } if(ke.getKeyCode() == KeyEvent.VK_S){ bMoveDown = true; } if(ke.getKeyCode() == KeyEvent.VK_A){ bMoveLeft = true; } if(ke.getKeyCode() == KeyEvent.VK_D){ bMoveRight = true; } } public void keyReleased(KeyEvent ke){ if(ke.getKeyCode() == KeyEvent.VK_W){ bMoveUp = false; } if(ke.getKeyCode() == KeyEvent.VK_S){ bMoveDown = false; } if(ke.getKeyCode() == KeyEvent.VK_A){ bMoveLeft = false; } if(ke.getKeyCode() == KeyEvent.VK_D){ bMoveRight = false; } } public void keyTyped(KeyEvent ke){ } });[/source]

[source lang="cpp"] // check if player is moving and set direction if (bMoveUp) setYDir(-1);[color=#000000] else if (bMoveDown) setYDir(1);[/color][color=#000000] else setYDir(0);[/color][color=#000000][font=Consolas,] if (bMoveLeft) setXDir(-1);[/font][/color][color=#000000][font=Consolas,] else if (bMoveRight) setXDir(1);[/font][/color][color=#000000] else setXDir(0);[/color][/source]

#6 CaptainKraft   Members   -  Reputation: 265

Like
0Likes
Like

Posted 11 July 2012 - 12:53 PM

You could try separating the movement from the key listener:


Thanks for that. I actually mimicked the movement from a Ludum Dare submission which helped a ton. I pretty much did what you just mentioned. Now if I could just figure out this damn collision detection...

#7 fastcall22   Crossbones+   -  Reputation: 3970

Like
2Likes
Like

Posted 11 July 2012 - 12:54 PM

A small modification's of eFoDay's snippet:

// check if player is moving and set direction

int dx = 0;
int dy = 0;

if ( bMoveUp ) dy--;
if ( bMoveDown ) dy++;
if ( bMoveLeft ) dx--;
if ( bMoveRight ) dx++;

setXDir( dx );
setYDir( dy );

WW91J3ZlIGdvdCBhIHNlY3JldCBib251cyBwb2ludCE=





Old topic!
Guest, the last post of this topic is over 60 days old and at this point you may not reply in this topic. If you wish to continue this conversation start a new topic.



PARTNERS