5 replies to this topic

[FDsagizi]

Hi

if defined AS_PROCESS_METADATA - CScriptBuilder crash on this script code:

std::string script = "class ";

Edited by Andreas Jonsson, 06 October 2012 - 06:09 PM.

[Andreas Jonsson]

Thanks. I'll look into this

[Andreas Jonsson]

I couldn't reproduce the crash. But I made some code changes in revision 1427 that I think may have caused the crash for you.

Let me know if the problem still persists.

[FDsagizi]

I use revision 1427

you can see imgae

pos == 6

http://gyazo.com/da7...e4987b7166d540b

std::string scirt_text = "class ";
builder.AddSectionFromMemory( scirt_text.c_str() , "test" );
builder.BuildModule();

Edited by FDsagizi, 07 October 2012 - 12:44 AM.

[Andreas Jonsson]

What compiler are you using?

I can only imagine the crash is due to the modifiedScript[pos] accessing one byte beyond the size of the string. Still, the code is only reading from this position, so it shouldn't crash.

[Andreas Jonsson]

I've made another change in revision 1428, so now the modifiedScript[pos] won't be called when the position is already beyond the size of the script.