8 replies to this topic

[King of the Boneheads]

I'm less-then-beginner in C++ at the moment and I'm working on my first official game: A Text Adventure.
I realized it should be simple enough to do, and I want to start with a basic one. Can I have 1 .cpp file for each room? Here's some example rooms:

|R1|R2|R3|
|R4|R5|R6|
|R7|R8|R9|

So l want it to make it so you start in the bottom room, it tells you what the room looks like, the name of the room, and gives you 3 choices.
Type in "N" for north "E" for east "W" for west.
So if you want to go north to the middle room, you type in "N" and hit enter.
Then you appear in the middle room, and the same thing happens.
However, I want to be able to have locked doors & keys.
So lets say there's a key in the top-right room, and you collect it if you walk into the room. Then there's door1 (you just collected key1) all around the middle room. Then if you try to walk in, it will act as if the door isn't there and you let you in. Otherwise it says you need the key.
Might be confusing, and I'm willing to take the time to write this, but I really want to make it happen.

Thanks in Advance.

Regards, King of the Boneheads.

[Inuyashakagome16]

You really don't "need" any more files to do what you want. You could (because you did state you were a beginner) setup a while loop and some conditional statements and work through the rooms

if(direction == 'n' || direction == 'N')
{
	 cout << "Moving North through the door";
}

For the locked key situation you could hard code it so certain rooms are always locked:

if(direction == 'e' || direction == 'E')
{
	 if(hasKey1)
	 {
		  cout << "You unlocked the door.";
	 }
	 else
	 {
		  cout << "The door ahead is locked.";
	 }
}

EDIT: You "can" if you want the extra files honestly. I figured it would be easier to work with one file at a time till you become more experienced with C++ is all. My apologies.

Edited by Inuyashakagome16, 10 October 2012 - 06:57 AM.

[King of the Boneheads]

You really don't "need" any more files to do what you want. You could (because you did state you were a beginner) setup a while loop and some conditional statements and work through the rooms

if(direction == 'n' || direction == 'N')
{
	 cout << "Moving North through the door";
}

For the locked key situation you could hard code it so certain rooms are always locked:

if(direction == 'e' || direction == 'E')
{
	 if(hasKey1)
	 {
		  cout << "You unlocked the door.";
	 }
	 else
	 {
		  cout << "The door ahead is locked.";
	 }
}

EDIT: You "can" if you want the extra files honestly. I figured it would be easier to work with one file at a time till you become more experienced with C++ is all. My apologies.

Thanks!

[MrDaaark]

1 code file for each room is not a good way to do this.

Make a class that will be your room type, and then handle all rooms in a general way. Give each room a name, and then point to which room each direction goes to, and if it's locked. You might also want a list of any items that are in the room.

Then you can handle your entire game in one easy, general purpose, loop.

[Inuyashakagome16]

1 code file for each room is not a good way to do this.

Make a class that will be your room type, and then handle all rooms in a general way. Give each room a name, and then point to which room each direction goes to, and if it's locked. You might also want a list of any items that are in the room.

Then you can handle your entire game in one easy, general purpose, loop.

That would be the way. I couldn't find the right way to say it without sounding dumb in some way. That's the method i would honestly go with. I wasn't sure if Boneheads had gotten that far into learning C++.

[MrDaaark]

I'm trying to put together a little example...

[MrDaaark]

Here is something I hacked together quick to show how to handle all rooms without coding each one. It's a little sloppy as I was pressed for time and haven't written C++ in a LONG time now. I added space to define keys, but I do not check for them.

edit: Looks better on PasteBin: http://pastebin.com/cYh15CWk

// ExampleTextAdventure.cpp : Defines the entry point for the console application.
//
#include "stdafx.h"
#include <string>
#include <vector>
#include <iostream>

using namespace std;
//This class will be the data type that all rooms are based on. It will contain data that is general to all rooms
class CRoom
{
public:
string Name;
//a list of exit name strings, and key name strings
//if key string is empty, door is unlocked
string ExitNorth, KeyNorth;
string ExitEast, KeyEast;
string ExitSouth, KeySouth;
string ExitWest, KeyWest;
//Constrcutor, for easy room initalization!
CRoom(string name,
  string exitnorth, string keynorth,
  string exiteast, string keyeast,
  string exitsouth, string keysouth,
  string exitwest, string keywest)
{
  Name = name;
  ExitNorth = exitnorth; KeyNorth = keynorth;
  ExitEast = exiteast; KeyEast = keyeast;
  ExitSouth = exitsouth; KeySouth = keysouth;
  ExitWest = exitwest; KeyWest = keywest;

  return;
}
~CRoom()
{
  //nothing to do!
  //strings clean themselves up

  return;
}
};

//game class, just to keep player and room data organized
class CGame
{
public:
//an array of keys
vector <string> Key;

//an array of rooms
vector <CRoom> Room;
int CurrentRoom;
string Input;

CGame()
{

  //add 9 rooms using the constructor to fill them out quickly
  //123
  //456
  //789
  Room.push_back(CRoom("Room 1", "","",   "Room 2","", "Room 4","", "",""));
  Room.push_back(CRoom("Room 2", "","",   "Room 3","", "Room 5","", "Room 1",""));
  Room.push_back(CRoom("Room 3", "","",   "","",   "Room 6","", "Room 5",""));
  Room.push_back(CRoom("Room 4", "Room 1","", "Room 5","", "Room 7","", "",""));
  Room.push_back(CRoom("Room 5", "Room 2","", "Room 6","", "Room 8","", "Room 4",""));
  Room.push_back(CRoom("Room 6", "Room 3","", "","",   "Room 9","", "Room 5",""));
  Room.push_back(CRoom("Room 7", "Room 4","", "Room 8","", "","",   "",""));
  Room.push_back(CRoom("Room 8", "Room 5","", "Room 9","", "","",   "",""));
  Room.push_back(CRoom("Room 9", "Room 6","", "","",   "","",   "Room 8",""));

  //set the current room to room 5, right in the middle
  CurrentRoom = FindRoom("Room 5");
  return;
}

//a prompt function
bool Prompt()
{
  cout << "\n\n\n";
  cout << "You are in " + Room[CurrentRoom]. Name << endl;
  cout << "Enter a direction to travel (n,e,s,w), or q to quit" << endl;
  cout << "-> ";

  //read player input
  string Input;
  cin >> Input;
  int NewRoom = 0;
  switch (Input[0])
  {
   //if the user entered 'q', return false
  case 'Q':
  case 'q':
   return false;
   break;
   //user wants to go north
  case 'N':
  case 'n':
   //check to see if that room exists
   //if FindRoom found a legal room, assign it as the current room
   NewRoom = FindRoom(Room[CurrentRoom].ExitNorth);  
   if (NewRoom > -1) CurrentRoom = NewRoom;
   else cout << "You can't travel in that direction from here" << endl;
   break;
  case 'E':
  case 'e':
   NewRoom = FindRoom(Room[CurrentRoom].ExitEast);
   if (NewRoom > -1) CurrentRoom = NewRoom;
   else cout << "You can't travel in that direction from here" << endl;
   break;
  case 'S':
  case 's':
   NewRoom = FindRoom(Room[CurrentRoom].ExitSouth);
   if (NewRoom > -1) CurrentRoom = NewRoom;
   else cout << "You can't travel in that direction from here" << endl;
   break;
  case 'W':
  case 'w':
   NewRoom = FindRoom(Room[CurrentRoom].ExitWest);
   if (NewRoom > -1) CurrentRoom = NewRoom;
   else cout << "You can't travel in that direction from here" << endl;
   break;
   //if the user enters an unrecognized command...
  default:
   cout << "Invalid command" << endl;
  }

  return true;
}


//Find a room index based on it's name
//returns an int that is the index of the room in the array
//or -1 if it's not found
int FindRoom(string RoomName)
{
  for (int i = 0; i < Room.size(); ++i)
  {
   //if the room name matches 'RoomName', return the room index
   if (Room[i].Name == RoomName)
   {
	return i;
   }
  }

  //if the code gets down here, the room with 'RoomName' wasn't found
  //so -1 is returned to indicate failure
  return -1;
}
};

int _tmain(int argc, _TCHAR* argv[])
{

//this will hold the input from the player
string Input;
//intialize a new instance of the game class
CGame Game;
while(1)
{
  //run the prompt, and break if the returns false;
  if (!Game.Prompt()) break;
}

cout << "Byeeeeeeeeee" << endl;
return 0;
}

edit: What is up with the code tags? turned my formatting into a disaster!

Edited by Daaark, 10 October 2012 - 03:19 PM.

[BeerNutts]

This might be a bit more complex than what you are looking for, but here's a simple example I put together for the heck of it. There are 5 source files for this, and I'll list them here, but it's generic enough, it should handle a good, fun game. The only thing I would modify is better handling of SpecializedCheck() function. I think this should be integrated into the rooms as well.

// TItem.h Handles Items in a text Adventure Game
#ifndef TITEM_H
#define TITEM_H
#include <string>
class TItem
{
public:
  TItem(std::string name, std::string description) :
  Name(name),
  Description(description),
  HasBeenUsed(false) {}
  ~TItem() {}

  bool IsUsable() { return !HasBeenUsed; }
  void UseItem() { HasBeenUsed = true; }

  std::string GetName() { return Name; }
  std::string getDescription() { return Description; }

private:
  std::string Name;
  std::string Description;
  bool HasBeenUsed;
};
#endif

// TRoom.h Handles Rooms in a text Adventure Game
#ifndef TROOM_H
#define TROOM_H
#include <string>
#include <vector>
#include "TItem.h"
#include "TPlayer.h"
class TRoom
{
public:
  TRoom(std::string description, std::string name);
  ~TRoom() {}
  // AddItem puts an item in the room to be displayed when looking, and get be picked up
  // an "Item" (which can be carried in your inventory, used, and picked up) should
  // probably be it's own class, and you would pass it to Add Item.  it would have a name, and a description at least.
  void AddItem(TItem item);
  // SetExit set a room to move to when going that direction
  void SetExit(std::string exitDirection, std::string roomConnection, bool enabled = true);
  void EnableExit(std::string direction, bool enabled);
  // Update handles the command given to it, like "look" will print the Description
  // it returns the new room to move to
  void TRoom::Update(std::string command, std::string& currentRoom, TPlayer &player);

  std::string GetName();
  std::string GetDescription();

  // Allows you to change the description
  void SetDescription(std::string description);
private:
  // structure to store the exits
  struct ExitInfo {
	std::string Direction;
	std::string RoomToMove;
	bool IsEnabled;
  };

  std::string Name;
  std::string Description;

  std::vector<ExitInfo> RoomsToMove;

  std::vector<TItem> Items;
};

#endif

// Player.h Handles Player in a text Adventure Game
#ifndef TPLAYER_H
#define TPLAYER_H
#include <string>
#include "TItem.h"
class TPlayer
{
public:
  TPlayer(std::string name) :
  Name(name) {}
  ~TPlayer() {}

  void AddItem(TItem item)
  { Inventory.push_back(item); }

  bool UseItem(std::string itemName)
  {
	for (int i = 0; i < Inventory.size(); i++) {
	  if (Inventory[i].GetName() == itemName &&
		  Inventory[i].IsUsable()) {
		Inventory[i].UseItem();
		return true;
	  }
	}
	return false;
  }

  void GetInventory(std::vector<TItem>& items)
  { items = Inventory; }

  std::string GetName() { return Name; }

private:
  std::string Name;
  std::vector<TItem> Inventory;

};

#endif

// TRoom.cpp Handles Rooms in a text Adventure Game
#include "TRoom.h"
#include <iostream>
TRoom::TRoom(std::string description, std::string name)
{
  Description = description;
  Name = name;
}
void TRoom::AddItem(TItem item)
{
  Items.push_back(item);
}
void TRoom::SetExit(std::string exitDirection, std::string roomConnection, bool enabled)
{
  ExitInfo exitInfo;

  exitInfo.Direction = exitDirection;
  exitInfo.RoomToMove = roomConnection;
  exitInfo.IsEnabled = enabled;
  RoomsToMove.push_back(exitInfo);

}
void TRoom::EnableExit(std::string direction, bool enabled)
{
  for (int i = 0; i < RoomsToMove.size(); i++) {
	if (RoomsToMove[i].Direction == direction) {
	  RoomsToMove[i].IsEnabled = enabled;
	  break;
	}
  }
}
void TRoom::Update(std::string command, std::string& currentRoom,
				   TPlayer &player)
{
  // Check for look first
  if (command == "look" || command == "l") {
	std::cout << Description << std::endl;
	for (int i = 0; i < Items.size(); i++) {
	 std::cout << "You see a " << Items[i].GetName() << std::endl;
	}
	
	std::cout << "Valid Exits are:";
	for (int i = 0; i < RoomsToMove.size(); i++) {
	  if (RoomsToMove[i].IsEnabled) {
		std::cout << " " << RoomsToMove[i].Direction;
	  }
	}
	return;
  }
  if (command.compare(0, 4, "get ") == 0) {
	// Someone typed "get <object>", see if we have the <object>
  
	std::string object = command.substr(4);  
	for (int i = 0; i < Items.size(); i++) {
	  if (Items[i].GetName() == object) {
		// we have the item, give it to the player
		std::cout << "You pick up " << object  << " and carry it with you.";
		player.AddItem(Items[i]);
		// remove the item from our vector
		Items.erase(Items.begin() + i);
		return;
	  }
	}
	std::cout << "You cannot pickup " << object;
	return;
  }
  // Check for a direction
  for (int i = 0; i < RoomsToMove.size(); i++) {
	if (command == RoomsToMove[i].Direction && RoomsToMove[i].IsEnabled) {
	  // Move to this room
	  currentRoom = RoomsToMove[i].RoomToMove;
	  return;
	}
  }

  std::cout << "I do not understand " << command;
  return;
}
std::string TRoom::GetDescription()
{
  return Description;
}
void TRoom::SetDescription(std::string description)
{
  Description = description;
}
std::string TRoom::GetName()
{
  return Name;
}

// GameMain.cpp Handles The mian loop in a text Adventure Game
#include "TRoom.h"
#include "TPlayer.h"
#include <iostream>
void LoadRooms();
bool CheckStandardInput(std::string input, bool &bRunning);
bool SpecializedCheck(std::string input, TPlayer &player,
					  TRoom &currentRoom, bool &bRunning);
// The vector holding all the rooms
std::vector<TRoom> Rooms;
int main(int argc, char *argv[])
{
  LoadRooms();

  TPlayer Player("Mark");

  std::cout << "Hello " << Player.GetName() << " Welcome to My test Adventure Game.";

  bool bRunning = true;
  TRoom &CurrentRoom = Rooms.front();

  // Print the first room's description
  std::string temp;
  CurrentRoom.Update("l", temp, Player);

  while(bRunning) {
	std::string input;
	std::cout << std::endl << "> ";
	getline( std::cin, input, '\n' );
	//std::cin >> input;
  
	if (!CheckStandardInput(input, bRunning)) {
	  // Perform Specialized check (for specific things)
	  if (!SpecializedCheck(input, Player, CurrentRoom, bRunning)) {
		std::string roomName = CurrentRoom.GetName();
		CurrentRoom.Update(input, roomName, Player);
		// Change rooms
		if (roomName != CurrentRoom.GetName()) {
		  for (int i = 0; i < Rooms.size(); i++) {
			if (Rooms[i].GetName() == roomName) {
			  CurrentRoom = Rooms[i];
			
			  // Print new rooms description
			  CurrentRoom.Update("l", roomName, Player);
			  break;
			}
		  }
		}
	  }
	}
  }

  std::cout << "Thanks for Playing!";
}
void LoadRooms()
{
  // Typically, you would load the rooms from a file here, but I'll hard code it for now
  // We create the rooms then link them togetehr After
  TRoom Closest("You Are in a Large Closest.  There is an Exit to the North.", "Closest");

  // This room has a broom
  TItem Broom("broom", "It's an old Broom.");
  Closest.AddItem(Broom);

  // The Closest is linked to a kitchen
  TRoom Kitchen("This is an old kitchen, With a Dirty Floor.  There is an exit to the south.", "Kitchen");

  // No Item, but if you use Broom, it will show a trap door leading down
  TRoom TreasureRoom("You've Found a Treasure Room with chests filled with Gold!  You can retire rich now.  Congratulations!", "TreasureRoom");

  // now set the exits; Trap door going down not set yet, so make usable false
  Closest.SetExit("n", Kitchen.GetName());
  Kitchen.SetExit("s", Closest.GetName());
  Kitchen.SetExit("d", TreasureRoom.GetName(), false);
  TreasureRoom.SetExit("u", Kitchen.GetName());

  Rooms.push_back(Closest);
  Rooms.push_back(Kitchen);
  Rooms.push_back(TreasureRoom);
}
bool CheckStandardInput(std::string input, bool &bRunning)
{
  if (input == "q" || input == "quit") {
	bRunning = false;
	return true;
  }
  if (input == "h" || input == "help") {
	std::cout << "Commands are: get, use, n, s, e, w, u, and d";
	return true;
  }

  return false;
}
bool SpecializedCheck(std::string input, TPlayer &player,
					  TRoom &currentRoom, bool &bRunning)
{
  // only special command is "use broom" if the player has the broom and he's in the kitchen
  if (input == "use broom") {
	// UseItem() will only wirk if player has it and it hasn't been used
	if (currentRoom.GetName() == "Kitchen" && player.UseItem("broom")) {
	  std::cout << "You sweep the floor, and find a trap door leading Down!";
	
	  // Change the room's description and set exit usable
	  currentRoom.SetDescription("This is an old kitchen. There is an exit to the south.  You've uncovered a trap door leading down.");
	  currentRoom.EnableExit("d", true);
	  return true;
	}
  }  
  return false;
}

Edited by BeerNutts, 11 October 2012 - 02:05 PM.

[BeerNutts]

Oops, there's a little bug in my code. I was assigning a separate TRoom CurrentRoom from the Rooms vector, but that wasn't holding the changes to the actual rooms themselves. Here's the updated main() function:

int main(int argc, char *argv[])
{
  LoadRooms();
 
  TPlayer Player("Mark");
 
  std::cout << "Hello " << Player.GetName() << " Welcome to My test Adventure Game.";
 
  bool bRunning = true;
  int currentRoom = 0;
 
  // Print the first room's description
  std::string temp;
  Rooms[currentRoom].Update("l", temp, Player);
 
  while(bRunning) {
    std::string input;
    std::cout << std::endl << "> ";
    getline( std::cin, input, '\n' );
    //std::cin >> input;
   
    if (!CheckStandardInput(input, bRunning)) {
	  // Perform Specialized check (for specific things)
	  if (!SpecializedCheck(input, Player, Rooms[currentRoom], bRunning)) {
	    std::string roomName = Rooms[currentRoom].GetName();
	    Rooms[currentRoom].Update(input, roomName, Player);
	    // Change rooms
	    if (roomName != Rooms[currentRoom].GetName()) {
		  for (int i = 0; i < Rooms.size(); i++) {
		    if (Rooms[i].GetName() == roomName) {
			  currentRoom = i;
			 
			  // Print new rooms description
			  Rooms[currentRoom].Update("l", roomName, Player);
			  break;
		    }
		  }
	    }
	  }
    }
  }
 
  std::cout << "Thanks for Playing!";
}