Back to General and Gameplay Programming

_itoa_s, strcpy_s, strcat_s. What are these doing exactly

Tim Lawton · 2012-11-29T20:54:48

EDIT: Hey there, I've just realized that the title may be kind of misleading. so I'm rewriting this part. Basically I have added a new method which holds the following 'functions' in the title, and I believe its causing my program to break at a very strange point in my 'UpdateSentence' method. Here is the method I have just recently added "setFPS" in my Text class. bool Text::setFPS(int fps, ID3D11DeviceContext* deviceContext) { char tempS[16]; char fpsS[16]; float red = 1.0f; float green = 1.0f; float blue = 1.0f; bool r; if(fps > 9999) //Truncate the fps { fps = 9999; } _itoa_s(fps, tempS, 10); strcpy_s(fpsS, "FPS: "); strcat_s(fpsS, tempS); /* if(fps >= 60) //if FPS is above or equal to 60 set text colour to green { red = 0.0f; green = 1.0f; blue = 0.0f; } if(fps < 60) //if FPS is below 60 set text colour to yellow { red = 1.0f; green = 1.0f; blue = 0.0f; } if(fps < 30) //if FPS is below 30 set text colour to red { red = 1.0f; green = 0.0f; blue = 0.0f; } */ r = UpdateSentence(sentence3, fpsS, 20, 20, red, green, blue, deviceContext); if(!r) { return false; } return true; } Now the application isn't breaking/crashing at this point, it's breaking at another method called "UpdateSentence" which you can see in the screenshot here: http://img547.imageshack.us/img547/3619/accessviolation2.png Here is the break I'm getting, it seems to be happening with adding colour to the function and I have no idea why its playing up now when it previously wasn't. Also if someone needs to see more code just ask and I can show If someone could shine some light on this I would be greatful

General and Gameplay Programming Programming

Started by Tim Lawton November 29, 2012 06:20 PM

11 comments, last by Tim Lawton 11 years, 4 months ago

alvaro

21,604

November 29, 2012 08:38 PM

Oh, please ignore my comment. I thought we were talking about strcat(). I need some rest. ;)

Khatharr

8,814

November 29, 2012 08:54 PM

Oh, please ignore my comment. I thought we were talking about strcat(). I need some rest. ;)

lol, I know that feeling.

As a side note:

[source lang="cpp"]_itoa_s(fps, tempS, 10);
strcpy_s(fpsS, "FPS: ");
strcat_s(fpsS, tempS);
[/source]

Could be:
[source lang="cpp"]sprintf_s(fpsS, "FPS: %i", tempS);[/source]
If you want to use C style string handling.

void hurrrrrrrr() {__asm sub [ebp+4],5;}

There are ten kinds of people in this world: those who understand binary and those who don't.

Tim Lawton

179

Author

November 29, 2012 08:54 PM

[quote name='Xuchilbara' timestamp='1354213223' post='5005387']
Now the application isn't breaking/crashing at this point, it's breaking at another method called "UpdateSentence" which you can see in the screenshot here:

Then why don’t you show the code for UpdateSentence()?

Also, sentence3 is garbage when it is passed to UpdateSentence(). I assume it is a member of the Text class.
Naming conventions such as m_ would go a long way to help people realize from where variables are coming.
It needs to be initialized—this has nothing to do with the functions listed in the topic.

L. Spiro
[/quote]

Ah thats done it, it wasn't initializing correctly and going straight to garbage, it is working now thanks alot everyone!

Also in essence, _itoa_s, strcpy_s, strcat_s, wasn't even the problem, sorry for being misleading :/

_itoa_s, strcpy_s, strcat_s. What are these doing exactly

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

_itoa_s, strcpy_s, strcat_s. What are these doing exactly

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

Reticulating splines