6 replies to this topic

[dkrusu]

It seems that angelscript doesn't support octals, any plans for this?

Krusu

[Andreas Jonsson]

I don't have any plans to implement this myself. However, if you would like to do it and send me a patch I can certainly include it in the SDK.

Regards,
Andreas

[dkrusu]

This was actually quite easy to implement. Any integer that is prefixed with a 0 is considered a octal just like in C. I added a simple test case, but I wasn't sure exactly where to stick it so I put it in test_bits.

Krusu

[dkrusu]

Forgot to check if the number is actually a valid octal (0-7), I'll upload the patch as soon as I fix this.

Edited by dkrusu, 10 December 2012 - 05:37 PM.

[dkrusu]

Okay, it now validates the octal. It does add another loop through the numbers, maybe you can think of a better way to validate it?

Attached Files

•  Octals.patch.zip   1.57KB   32 downloads

[Andreas Jonsson]

Thanks for the patch. I'll look into this as soon as I can and have it merged with the SDK.

Regards,
Andreas

[Andreas Jonsson]

I received another patch from ketmar that added support for binary numbers in addition to octal. I've checked in that in revision 1571.

 

The nice thing about that patch is the consistency with the prefixes, example:

 

int binary = 0b11111111;
int octal = 0o7777;
int decimal = 0d999999;
int hexadecimal = 0xFFFFFFFF;