5 replies to this topic

[xSharp]

Hello everyone!

I have been reading around GameDev a lot lately, and everyone here seems to give good feedback when people post their first project. I am hoping to get some feedback on mine as well.


I recently finished this game as a final project for one of my classes at college. I decided to do a battleship clone I call "Naval Commander". I used python 2.7.3 and pygame 1.9.1.

I have finished one other game before while following a tutorial, but since I made this game on my own I really consider it as my first completed game, even though it isn't much. I was running out of time toward the end of the project, so I started rushing a few things and it may not look the best. I also just started using python this semester, so I probably didn't do a lot of stuff the most "pythonic" way either. I tried to comment a lot, so hopefully that helps.

Among other things, I am hoping to get feedback on the design and organization of the code. I questioned myself with a lot of things like which class does what, or if I made too many or too few classes. I would really appreciate someone's view on that.

I Included the source code, but the exe was too big to upload here. If anyone wants the exe, just let me know and I will upload it somewhere else.


Any feedback will be much appreciated. Thank you for reading!


p.s.: if you run the game, be warned the sound effects are kind of loud.

Attached Files

•  src.zip   164.16K   109 downloads

Edited by xSharp, 12 December 2012 - 02:57 PM.

[ultramailman]

Cool game. It looks pretty complete. Sound effects aren't too loud either, but I do wonder why it said I don't have a sound card.

Here are my opinions:
1. the fps counter in the title is kind of distracting... perhaps add an event to toggle it to appear/disappear on the screen?
2. So many "from import"'s... I don't think it is best practice to have too many of those, but perhaps it's just me.

Other than those, I think everything is good. I didn't look too much into the code though.

[miicchhii]

I would also say that the FPS counter is distracting,
and its annoying always to click continue after a ship sank,

But i think its done very well so far!
GZ!

PS: in my oppinion its not a bad thing to have all those "from import"s, better to read than when putting it all in one file

Edited by miicchhii, 12 December 2012 - 10:04 AM.

[xSharp]

Cool game. It looks pretty complete. Sound effects aren't too loud either, but I do wonder why it said I don't have a sound card.

Thank you! I thought the sfx were a bit loud, but I'm glad they weren't for you!
As for the sound card issue, I don't think I had that problem, and I am not sure what would cause that. =\

Here are my opinions:
1. the fps counter in the title is kind of distracting... perhaps add an event to toggle it to appear/disappear on the screen?
2. So many "from import"'s... I don't think it is best practice to have too many of those, but perhaps it's just me.
Other than those, I think everything is good. I didn't look too much into the code though.

1. Ahh yes, that is a good idea! I was so used to it being there I sort of forgot about it.
2. I wasn't too sure about this part either, I just didn't want to have one huge file. But I agree, all the imports are kind of annoying!

I would also say that the FPS counter is distracting,
and its annoying always to click continue after a ship sank,

But i think its done very well so far!
GZ!

PS: in my oppinion its not a bad thing to have all those "from import"s, better to read than when putting it all in one file

Yes, I will have to do something about the FPS counter. I will probably add a toggle in like ultramailman said.

I can see the clicking getting annoying. I might change it to do a short pause or was thinking of adding another pop up that will dissapear after a couple of seconds.

Thank you both for the feedback, I really appreciate it!

[Riphath]

Just looking at your code, you tend to comment things that almost don't need it. While it's definitely better to be over commenting, you also tend to name variables and other things really well, so some of those comments seem redundant. That may just be my personal taste, but consider putting more relevant information in the comments instead of just repeating what's already said in the names you've given. I kinda don't like this game, because I lost against the computer when I first played haha! Other than that, it seems really well done!

[xSharp]

Just looking at your code, you tend to comment things that almost don't need it. While it's definitely better to be over commenting, you also tend to name variables and other things really well, so some of those comments seem redundant. That may just be my personal taste, but consider putting more relevant information in the comments instead of just repeating what's already said in the names you've given.

The last game I worked on I didn't comment at all, so I am still a bit of a "comment noob". But I see what you mean, I did put quite a few useless comments on there. Well, that and I had to do a presentation and explain this to the class, so some of those I put there on purpose. If it was just for me to look at, I probably would have cut back a bit.

I kinda don't like this game, because I lost against the computer when I first played haha! Other than that, it seems really well done!

Well, I'm glad at least someone enjoyed the game! haha ;)


Thank you for the input!

Edited by xSharp, 12 December 2012 - 06:57 PM.