Jump to content

  • Log In with Google      Sign In   
  • Create Account


Monday morning code...

  • You cannot reply to this topic
14 replies to this topic

#1 Ashaman73   Crossbones+   -  Reputation: 7130

Like
2Likes
Like

Posted 25 February 2013 - 02:17 PM

Monday morning code is this kind of code, where you write some seemingly easy code in hour just before first coffee and your co-workers need at least the rest of the week to figure out what went wrong. You would deny this code until you see the blame in svn, after that you start to believe in global conspirators.

 

Here's some java code I tracked down which caused some ugly bug ph34r.png

 

// determine objects to copy
MyClass sourceObj = getSourceObject();
MyClass destObj = getDestinationObject();

// copy now
destObj = sourceObj;

 



Sponsor:

#2 Alpha_ProgDes   Crossbones+   -  Reputation: 4688

Like
4Likes
Like

Posted 25 February 2013 - 08:47 PM

Pass pointers by value for the win......?

 

Monday mornings should be referred to as the "Hours of the n00bpocalypse"


Edited by Alpha_ProgDes, 25 February 2013 - 08:47 PM.

Beginner in Game Development? Read here.
 
Super Mario Bros clone tutorial written in XNA 4.0 [MonoGame, ANX, and MonoXNA] by Scott Haley
 
If you have found any of the posts helpful, please show your appreciation by clicking the up arrow on those posts Posted Image
 
Spoiler

#3 slicer4ever   Crossbones+   -  Reputation: 3499

Like
0Likes
Like

Posted 23 March 2013 - 07:45 AM

it's saturday morning, this code doesn't cause a crash, but is just an stupid oversight i caught myself doing:

 

 

Tile *World::GetTile(unsigned int x, unsigned int y){ //Same as above, but we can specify x/y coordinates instead of index positions.
    if(x<0 || x>=m_Width ) return nullptr;  //We check that the x-axis is inside the world.
    if(x<0 || y>=m_Height) return nullptr; //We check that the y-axis is inside the world.
    return m_Tiles+(x+y*m_Width);
}

 

completly idiotic on my part, unsigned numbers are never less than zero;-)


Edited by slicer4ever, 23 March 2013 - 07:46 AM.

Check out https://www.facebook.com/LiquidGames for some great games made by me on the Playstation Mobile market.

#4 TheChubu   Crossbones+   -  Reputation: 4101

Like
0Likes
Like

Posted 23 March 2013 - 07:49 AM

One can never be sure enough! :P

 

Also check if nullptr is actually null.


"I AM ZE EMPRAH OPENGL 3.3 THE CORE, I DEMAND FROM THEE ZE SHADERZ AND MATRIXEZ"

 

My journals: dustArtemis ECS framework and Making a Terrain Generator


#5 Bacterius   Crossbones+   -  Reputation: 8533

Like
10Likes
Like

Posted 23 March 2013 - 11:07 PM

Might want to fix the second x < 0 to y < 0 too. I mean, it doesn't change anything, but at least it looks right happy.png


The slowsort algorithm is a perfect illustration of the multiply and surrender paradigm, which is perhaps the single most important paradigm in the development of reluctant algorithms. The basic multiply and surrender strategy consists in replacing the problem at hand by two or more subproblems, each slightly simpler than the original, and continue multiplying subproblems and subsubproblems recursively in this fashion as long as possible. At some point the subproblems will all become so simple that their solution can no longer be postponed, and we will have to surrender. Experience shows that, in most cases, by the time this point is reached the total work will be substantially higher than what could have been wasted by a more direct approach.

 

- Pessimal Algorithms and Simplexity Analysis


#6 Puyover   Members   -  Reputation: 187

Like
0Likes
Like

Posted 21 April 2013 - 10:29 AM

If this was C++ there would be some chance of success due to operator overload, but... tongue.png



#7 NEXUSKill   Members   -  Reputation: 456

Like
0Likes
Like

Posted 15 May 2013 - 01:48 PM

I usually avoid writing any code monday morning, think about stuff, do some testing, identify issues and think of solutions... only start coding after lunch


Game making is godlike

LinkedIn profile: http://ar.linkedin.com/pub/andres-ricardo-chamarra/2a/28a/272



#8 Freya   Members   -  Reputation: 801

Like
0Likes
Like

Posted 23 May 2013 - 03:03 PM

I once made this "beauty" at work...

 

// Write
bool result = insert(results, data);

if ( m_CurrentSet )
{
       result = result || insert(*m_CurrentSet, data);
}
 

The idea was to store the latest of anything that has been written to file in memory, to make sure the latest set of data was in memory. However, this being a real time application, which in theory should run forever (and generates data for a multi-million dollar service), the results were pretty poor.

 

No harm done, since this was in a test and not production.


Working on a game "Burnt islands".
Dev blog       
"Burnt islands" on Indie DB

#9 Arthur Souza   Members   -  Reputation: 1418

Like
0Likes
Like

Posted 01 June 2013 - 08:58 AM

I ALWAYS end up making two comparisons on X or using X value for both X and Y on something, hahahaha, eventually have some reeeeallly weird behavior and track it to that, lmao


A.

Lotus - Action RPG In development http://www.gamedev.n...die-rpg-engine/ |
Personal blog In Portuguese: lotuzgames.wordpress.com |


#10 _orm_   Members   -  Reputation: 112

Like
1Likes
Like

Posted 07 June 2013 - 08:48 AM

One can never be sure enough! tongue.png

 

Also check if nullptr is actually null.

nullptr is a C++11 keyword that is guaranteed to be null.



#11 Alpha_ProgDes   Crossbones+   -  Reputation: 4688

Like
0Likes
Like

Posted 07 June 2013 - 09:30 AM

Here's some recent Monday-morning like code

 

 

if (ddl.SelectedValue == "Ticket")
   LoadPassengerList(currentTrainNumber.Text);
   PassengerPanel.Visible = false;
 

 

 

 

See what I did there......?


Beginner in Game Development? Read here.
 
Super Mario Bros clone tutorial written in XNA 4.0 [MonoGame, ANX, and MonoXNA] by Scott Haley
 
If you have found any of the posts helpful, please show your appreciation by clicking the up arrow on those posts Posted Image
 
Spoiler

#12 Juliean   GDNet+   -  Reputation: 2437

Like
0Likes
Like

Posted 07 June 2013 - 10:42 AM

See what I did there......?

 

Judging from your formatting, I'd say you forgot to put parenthesis after the if, so that the third line was executed regardless of the selected value? If so, it would be interesting what the results of this was biggrin.png


Edited by Juliean, 07 June 2013 - 10:45 AM.


#13 Paradigm Shifter   Crossbones+   -  Reputation: 5256

Like
1Likes
Like

Posted 07 June 2013 - 11:23 AM

Just a wild guess, I'd say the PassengerPanel became invisible regardless of whether the selected value was "Ticket" ;)


"Most people think, great God will come from the sky, take away everything, and make everybody feel high" - Bob Marley

#14 TheChubu   Crossbones+   -  Reputation: 4101

Like
2Likes
Like

Posted 07 June 2013 - 06:37 PM

One can never be sure enough! tongue.png

 

Also check if nullptr is actually null.

nullptr is a C++11 keyword that is guaranteed to be null.

That was the point of my comment mellow.png Comparing if unsigned values are negative... checking if nullptr is null... rings a bell?


"I AM ZE EMPRAH OPENGL 3.3 THE CORE, I DEMAND FROM THEE ZE SHADERZ AND MATRIXEZ"

 

My journals: dustArtemis ECS framework and Making a Terrain Generator


#15 DekuTree64   Members   -  Reputation: 985

Like
2Likes
Like

Posted 10 June 2013 - 01:59 AM

Here's some recent Monday-morning like code

 

 

if (ddl.SelectedValue == "Ticket")
   LoadPassengerList(currentTrainNumber.Text);
   PassengerPanel.Visible = false;
 

 

 

 

See what I did there......?

laugh.png Classic. "Hey, I just need to add one more thing in this if case... *copy, paste, compile*, no error, I'm such a good programmer! *moves on*"

 

2 weeks later, someone else: "Why is this stupid thing vanishing all the time? angry.png "







PARTNERS