Jump to content

  • Log In with Google      Sign In   
  • Create Account


Template specialization and class references

  • You cannot reply to this topic
9 replies to this topic

#1 Conoktra   Members   -  Reputation: 140

Like
0Likes
Like

Posted 15 March 2013 - 09:16 AM

Consider the following:

 

class Vector3 {
public:
	f64 x, y, z;
};

// pass an unkown userdata type to lua
template<typename T> inline void luaPushArg(lua_State * const LuaState, T arg) {
	tolua_pushusertype(LuaState, (void*)&arg, typeid(T).name() + 6);
}

void testFunction(const Vector3 &v) {
	luaPushArg(LuaState, v);
	luaCallFunction("TestFunction"); // CRASH (only sometimes though!)
	luaPop();
}

 

 

What went wrong here?  Can you spot the bug?  This one was a real pain in the tush.  luaPushArg() would work with all my specialized types (int, float, etc) that I was passing to Lua, but when I passed classes it would sometimes crash.  Turns out that luaPushArg() is taking a T arg instead of a T &arg.  This means that a new copy of 'v' is created inside testFunction() when it calls luaPushArg().  luaPushArg() then pushes the newly created object onto the Lua stack.  Upon luaPushArg()'s return, the pointer too the class object that was just pushed onto the lua stack is now invalidated.  Sometimes it would crash, sometimes it wouldn't.  This one was a real nightmare.

 

 

Hehehe biggrin.png.  I can't wait for C11 support in GCC, that way bugs like this can be avoided using type-generic expression macros.


Edited by Conoktra, 15 March 2013 - 09:20 AM.


Sponsor:

#2 ApochPiQ   Moderators   -  Reputation: 15063

Like
3Likes
Like

Posted 15 March 2013 - 01:56 PM

typeid(T).name() + 6
W.


T.


F.

#3 Ectara   Crossbones+   -  Reputation: 2916

Like
0Likes
Like

Posted 15 March 2013 - 02:40 PM

typeid(T).name() + 6
W.


T.


F.

I was assuming that it was to skip past name mangling output, but holy crap is that non-portable, and would cause serious problems if you have two classes with the same name.



#4 Conoktra   Members   -  Reputation: 140

Like
0Likes
Like

Posted 20 March 2013 - 12:17 PM

typeid(T).name() + 6
W.


T.


F.

 

tolua++ needs to know the class's typename or else its treated as a void* inside lua.  The "typeid(T).name + 6" skips the "class " prefix and only passes the classes unique type name ("class MyClass" -> "MyClass") which is what tolua++ expects.  luaPushArg() has specialized template instances for all non-class types (thus avoiding the issue of instantiating the template with, say, an int).  That way I can pass any class to lua without having to define a specialized instance of luaPushArg() for each class type.  With hundreds of classes exported to lua, this saves a lot of time and code.

 

 

holy crap is that non-portable

Portability isn't an issue.  If it was fixing it would be a matter of a couple of #ifdefs.  Whoopdeedoo.

 

 

would cause serious problems if you have two classes with the same name.

Its not possible to have two classes with the same typename.  Period. Try to compile this:

 

class A { };
class A { }; // error C2011: 'A' : 'class' type redefinition

Edited by Conoktra, 20 March 2013 - 12:23 PM.


#5 swiftcoder   Senior Moderators   -  Reputation: 9856

Like
0Likes
Like

Posted 20 March 2013 - 12:43 PM


would cause serious problems if you have two classes with the same name.

Its not possible to have two classes with the same typename.  Period. Try to compile this:
class A { };
class A { }; // error C2011: 'A' : 'class' type redefinition


That assumes that you are actively preventing/renaming nested classes?
#include <iostream>

struct Foo {
	class A {};
};

struct Bar {
	class A {};
};

int main()
{
    std::cout << typeid(Foo::A).name() << std::endl;
    std::cout << typeid(Bar::A).name() << std::endl;
}
Although my platform (clang on Mac) seems to provide fully mangled names:
tristam$ ./a.out 
N3Foo1AE
N3Bar1AE

Tristam MacDonald - Software Engineer @Amazon - [swiftcoding]


#6 wintertime   Members   -  Reputation: 1642

Like
0Likes
Like

Posted 20 March 2013 - 12:45 PM

not sure about the typeid resulting from that, but:

namespace {
class A {};
}
class A {};


#7 swiftcoder   Senior Moderators   -  Reputation: 9856

Like
0Likes
Like

Posted 20 March 2013 - 12:58 PM

not sure about the typeid resulting from that, but:

namespace {
class A {};
}
class A {};


Just because it is anonymous, doesn't mean it isn't named under the hood (and, in fact, it pretty much has to be for name resolution):
tristamm$ ./a.out 
N12_GLOBAL__N_11AE
1A

Tristam MacDonald - Software Engineer @Amazon - [swiftcoding]


#8 wintertime   Members   -  Reputation: 1642

Like
0Likes
Like

Posted 20 March 2013 - 01:02 PM

The point was more that its not impossible to compile classes with same name.smile.png



#9 swiftcoder   Senior Moderators   -  Reputation: 9856

Like
0Likes
Like

Posted 20 March 2013 - 01:05 PM

The point was more that its not impossible to compile classes with same name.smile.png

Sure, but he specified "same typename", which is a different story.

Tristam MacDonald - Software Engineer @Amazon - [swiftcoding]


#10 Conoktra   Members   -  Reputation: 140

Like
0Likes
Like

Posted 20 March 2013 - 07:43 PM

The point was more that its not impossible to compile classes with same name.smile.png

Even the most sound code can be broken when you throw scenarios at it that are specifically designed to break it.  My compiler doesn't mangle the class names nor do I use namespaces, hence neither is an issue.







PARTNERS