Jump to content

  • Log In with Google      Sign In   
  • Create Account

problems with memset


Old topic!

Guest, the last post of this topic is over 60 days old and at this point you may not reply in this topic. If you wish to continue this conversation start a new topic.


  • You cannot reply to this topic
7 replies to this topic

#1   Members   -  Reputation: 917

Like
0Likes
Like

Posted 26 March 2013 - 01:19 PM

Here's the code:

 

class gg{
public:
	char ce[10];
	gg(char j = ' ') { memset(ce,j,sizeof(ce));};
};
int main() {
	gg x('m');
	cout << x.ce << endl;

    
}

 

 

It outputs all those 10 ms,and then a series of weird symbols appear,why does that happen?



#2   Moderators   -  Reputation: 9968

Like
4Likes
Like

Posted 26 March 2013 - 01:22 PM

Your string is not null terminated and so the stream is printing whatever follows the last element until the first null character. Add a '\0' at the end to mark the end of the string.



#3   Members   -  Reputation: 917

Like
0Likes
Like

Posted 26 March 2013 - 01:26 PM

Thank a lot



#4   Crossbones+   -  Reputation: 5531

Like
0Likes
Like

Posted 26 March 2013 - 01:30 PM

perhaps the easiest thing to do is:

 

char ce[10];       // declare string

ce[0]=0;             // set string to ""


Norm Barrows

Rockland Software Productions

"Building PC games since 1989"

rocklandsoftware.net

 

PLAY CAVEMAN NOW!

http://rocklandsoftware.net/beta.php

 

 


#5   Crossbones+   -  Reputation: 5832

Like
4Likes
Like

Posted 26 March 2013 - 01:40 PM

Uh, no. He's about to overwrite the 10 chars in ce with 10 'm' characters so making it the empty string before you do that isn't very useful.

 

You need to do this

 

memset(ce, j, sizeof(ce) - 1);

ce[sizeof(ce)-1] = '\0';

 

You'll want to up the array size to 11 if you want to store 10 'm' characters in the array though as well as the null terminator.

 

Note: this only works since sizeof char is defined as 1.


"Most people think, great God will come from the sky, take away everything, and make everybody feel high" - Bob Marley

#6   Senior Moderators   -  Reputation: 17606

Like
1Likes
Like

Posted 26 March 2013 - 05:24 PM

Note: this only works since sizeof char is defined as 1.

You can solve this by using sizeof(char):

memset(ce, j, sizeof(ce) - sizeof(char));

 

However, unless I'm very mistaken, sizeof(char) is guaranteed to be 1.


Tristam MacDonald - Software Engineer @ Amazon - [swiftcoding] [GitHub]


#7   Crossbones+   -  Reputation: 12937

Like
0Likes
Like

Posted 26 March 2013 - 05:28 PM

Note: this only works since sizeof char is defined as 1.

You can solve this by using sizeof(char):

 

memset(ce, j, sizeof(ce) - sizeof(char));

 

However, unless I'm very mistaken, sizeof(char) is guaranteed to be 1.

 

Only if the char array is previously initialized to zero, which I believe is not the case for local variables (their value, and, for pointers, the memory they point to, is undefined).

 

EDIT: never mind that. And, yes, sizeof(char) is defined to be 1 by the C and C++ standard. Don't have the references with me now, though. Of course it's best to get in the habit of using vectors (and strings) if using C++, there's no overhead and it's just simpler and safer to use, not to mention more idiomatic.


Edited by Bacterius, 26 March 2013 - 05:30 PM.

“If I understand the standard right it is legal and safe to do this but the resulting value could be anything.”


#8   Crossbones+   -  Reputation: 5832

Like
0Likes
Like

Posted 26 March 2013 - 05:29 PM

Yeah I know, that's why I said it was DEFINED as 1 ;)


"Most people think, great God will come from the sky, take away everything, and make everybody feel high" - Bob Marley




Old topic!

Guest, the last post of this topic is over 60 days old and at this point you may not reply in this topic. If you wish to continue this conversation start a new topic.




PARTNERS