Jump to content

  • Log In with Google      Sign In   
  • Create Account


Is there a simpler way of doing this?


Old topic!
Guest, the last post of this topic is over 60 days old and at this point you may not reply in this topic. If you wish to continue this conversation start a new topic.

  • You cannot reply to this topic
4 replies to this topic

#1 YNV_DeViouS   Members   -  Reputation: 128

Like
0Likes
Like

Posted 28 July 2013 - 11:58 PM

I am new to c++ and this is my first c++ program. I am experimenting with little things, but is there any simpler way of writing this code, and by writing this code is there some way I can use length for both char * c and char * x? Thanks for your help in advance.

ScreenShot1_zps51c790cc.jpg



Sponsor:

#2 haegarr   Crossbones+   -  Reputation: 3259

Like
2Likes
Like

Posted 29 July 2013 - 01:08 AM

is there any simpler way of writing this code

Routines are used to write reusable code only once. E.g.

void
writeTextLine(char const* text, int length) {
    ... put the writing herein
}

(Using the routine is shown below in the next comment.)

 

 

is there some way I can use length for both char * c and char * x?

"length" is a variable can be overwritten:

int length;
char * c = "Hallo World!\n";
char * x = "\nI'm a C++ program";
length = 13;
writeTextLine( c, length );
length = 18;
writeTextLine( x, length );

However, with the routine at hand, using "length" in the main part is somewhat oversized, because the following solution would do the same thing:

char * c = "Hallo World!\n";
char * x = "\nI'm a C++ program";
writeTextLine( c, 13 );
writeTextLine( x, 18 );

Next, the size of the length of character arrays can be determined by using a pre-defined routine, namely "strlen". Using it would avoid the need of counting the character arrays' characters at all. This works, of course, only if you don't want to write just a part of a text line.

 

 

However, a problem with your code is the usage of character arrays instead of the string class. Although legal, it is an error-prone way of doing things.

 

 

P.S.: Please stop posting code snippets as screen shots. Post them as text surrounded by the "code" tags (see the button labeled "< >" in the tool bar of the editor panel). It makes reading easier and it makes copy-&-paste of snippets into answers possible.


Edited by haegarr, 29 July 2013 - 01:10 AM.


#3 Zaoshi Kaba   Crossbones+   -  Reputation: 2860

Like
5Likes
Like

Posted 29 July 2013 - 01:44 AM

Since you're using C++ you should refrain from using char* for text. string class was made specifically for that.

// at the top
#include <string>
using std::string;

// in main
string c = "Hello world\n";
for(int i = 0; i < c.length(); i++) {
    cout << c[ i ];
    Sleep(150);
}

// alternatively
cout << c; // print whole string at once


#4 YNV_DeViouS   Members   -  Reputation: 128

Like
1Likes
Like

Posted 29 July 2013 - 02:19 PM

Thank you for the help. It does make more sense to use string instead of char now that you guys have explained things, and from now on i will post code snippets instead of screen shots, thanks for the reminder.



#5 Yrjö P.   Crossbones+   -  Reputation: 1410

Like
2Likes
Like

Posted 29 July 2013 - 04:56 PM



 

Since you're using C++ you should refrain from using char* for text. string class was made specifically for that.

// at the top
#include <string>
using std::string;

// in main
string c = "Hello world\n";
for(int i = 0; i < c.length(); i++) {
    cout << c[ i ];
    Sleep(150);
}

And you should refrain from using "for" to iterate through entire containers in order because range-for was made specifically for that. tongue.png

for (auto c : "Hello world!\n") {
    cout << c;
    Sleep(150);
}

(In this very specific scenario, it doesn't actually help to use the string class. Good idea 99% of the time, though.)






Old topic!
Guest, the last post of this topic is over 60 days old and at this point you may not reply in this topic. If you wish to continue this conversation start a new topic.



PARTNERS