Jump to content

  • Log In with Google      Sign In   
  • Create Account

We're offering banner ads on our site from just $5!

1. Details HERE. 2. GDNet+ Subscriptions HERE. 3. Ad upload HERE.


Why are their bumps in my shadow mapping?


Old topic!
Guest, the last post of this topic is over 60 days old and at this point you may not reply in this topic. If you wish to continue this conversation start a new topic.

  • You cannot reply to this topic
15 replies to this topic

#1 SIC Games   Members   -  Reputation: 617

Like
2Likes
Like

Posted 28 August 2014 - 12:33 AM

I just started implemending Shadow Mapping in my engine and I see inside the editor there's bumps inside the shadow map. I'm wondering what they are?

 

The current set up I have is an orthographic Left Handed view for rendering depth. The depth stencil is rendered as DXGI_FORMAT_D24_UNORM_S8_UINT and is bounded both as depth stencil and shader resource. The texture format for the depth stencil is DXGI_FORMAT_R24G8_TYPELESS The shader resource view is formated as DXGI_FORMAT_R24_UNORM_X8_TYPELESS.

 

Is it a format issue?

 

Snapshot1.jpg

 

If anyone needs to see sniplets of code I'll share.


Game Engine's WIP Videos - http://www.youtube.com/sicgames88


Sponsor:

#2 MJP   Moderators   -  Reputation: 11590

Like
7Likes
Like

Posted 28 August 2014 - 12:36 AM

Having a stair-step pattern is totally expected, since it's just aliasing due to rasterization. However in your picture the edges are rounded, which is strange. Are you using bilinear filtering when sampling the shadow map, or performing any other filtering/blurring on the shadow map before you sample it?



#3 SIC Games   Members   -  Reputation: 617

Like
0Likes
Like

Posted 28 August 2014 - 01:02 AM

No, I double checked to see what my sampler state was set to and it was originally set to D3D11_FILTER_MIN_MAG_MIP_LINEAR_POINT I can't remember but it was point sampling. So, I thought it could be what you were mentioning about biLinear filtering - so I changed it to D3D11_FILTER_MIN_MAG_MIP_LINEAR and kept the clamp still there.

 

When I perform the projection I did :

float2 projTexCoord;
projTexCoord.x = +input.lightVector.x / input.lightVector.w / 2.0f + 0.5f;
projTexCoord.y = -input.lightVector.x / input.lightVector.w / 2.0f + 0.5f;

The lightVector is the camera orthographic video from the light into the constant buffer inside the shader.

 

At first I thought that was the issue but like you asked - no bluring or any bilinear filtering was used At least I don't think - I'm unsure what bilinear filtering is actually. The depth stencil is not MSAA and the sample count is set to 1 and the quality is set to 0.


Game Engine's WIP Videos - http://www.youtube.com/sicgames88


#4 SIC Games   Members   -  Reputation: 617

Like
0Likes
Like

Posted 28 August 2014 - 01:04 AM

Wait I corrected my statement above - I checked what bilinear filter is and apparently the point sampling is bilinear. So yes; I did - I didn't know it. I changed it to trilinear and apparently the same result. Do you think just antsicopy filtering or perhaps point sampling will help?


Game Engine's WIP Videos - http://www.youtube.com/sicgames88


#5 mightypigeon   Members   -  Reputation: 512

Like
6Likes
Like

Posted 28 August 2014 - 05:32 AM

The rounded edges are due to your shadow filtering, perhaps try D3D11_FILTER_MIN_MAG_MIP_POINT for your filter.




#6 SIC Games   Members   -  Reputation: 617

Like
0Likes
Like

Posted 28 August 2014 - 09:19 AM

Now I got the stair stepping that MJP was mentioning by using point sampling. Just to make sure I was using point sampling - I changed it from clamp to border. Inside the rendering

ID3D11SamplerState *Samplers = { device->pointSampler, device->clampSampler };
device->getDeviceContext()->PSSetSamplers(0,2,Samplers);

the clampSampler is configured for the D3D11_FILTER_MIN_MAG_MIP_POINT and address modes are set to border.


Game Engine's WIP Videos - http://www.youtube.com/sicgames88


#7 SIC Games   Members   -  Reputation: 617

Like
0Likes
Like

Posted 28 August 2014 - 09:28 AM

So, the resulting image I received is Snapshot1.jpg

 

I looked at Crysis 3 shadowing and was completely amazed - voxel cone tracing techniques were used but I'm far away from even implementing that in my engine. A lot more to read and research.

 

Now back to reading DirectX 11 by Frank Luna because he covers the stair stepping issue and suggests to use PCF Kernels to reduce the stair stepping.

 

Are Kernels specially designed in the hardware? I kept on seeing in shader tutorials about Kernels - which through me off a bit. There was a shader tutorial of edge detection using 3x3 kernel and a simple gaussian blur using a 3x3 kernel.


Game Engine's WIP Videos - http://www.youtube.com/sicgames88


#8 L. Spiro   Crossbones+   -  Reputation: 14027

Like
4Likes
Like

Posted 28 August 2014 - 03:08 PM

http://codeflow.org/entries/2013/feb/15/soft-shadow-mapping/

PCF is covered. All samples have full source code and explanations.
Since it is WebGL, they are all basic enough for beginners.


L. Spiro
It is amazing how often people try to be unique, and yet they are always trying to make others be like them. - L. Spiro 2011
I spent most of my life learning the courage it takes to go out and get what I want. Now that I have it, I am not sure exactly what it is that I want. - L. Spiro 2013
I went to my local Subway once to find some guy yelling at the staff. When someone finally came to take my order and asked, “May I help you?”, I replied, “Yeah, I’ll have one asshole to go.”
L. Spiro Engine: http://lspiroengine.com
L. Spiro Engine Forums: http://lspiroengine.com/forums

#9 SIC Games   Members   -  Reputation: 617

Like
0Likes
Like

Posted 28 August 2014 - 03:46 PM

Most of the stuff from that website L. Spiro is able to translated to DirectX? I added the site to my home page for later reading.

 

What I understand is the hard edges are shadow artifiects from the shadow map's boundary - which is normal. The shadow acne I was getting was due to the light's camera view relative to the camera. I didn't show the shadow acne.

 

In what depth sohuld ia have the shadow map 1 - 1000 (max) or 1 - 100?


Game Engine's WIP Videos - http://www.youtube.com/sicgames88


#10 L. Spiro   Crossbones+   -  Reputation: 14027

Like
2Likes
Like

Posted 28 August 2014 - 04:11 PM

The range of the depth of the shadow depends on the projection matrix you use to render into it and later to retrieve from it, and that matrix is derived from the farthest and nearest objects’ bounding boxes from the light’s point of view. He has hard-coded it for the tutorials for the sake of simplicity.

It is trivial to translate to Direct3D. Mostly, use lerp() instead of mix() and ddx()/ddy() instead of dFdx()/dFdy(). Other little things will be easy to spot and translate as you go.


L. Spiro


It is amazing how often people try to be unique, and yet they are always trying to make others be like them. - L. Spiro 2011
I spent most of my life learning the courage it takes to go out and get what I want. Now that I have it, I am not sure exactly what it is that I want. - L. Spiro 2013
I went to my local Subway once to find some guy yelling at the staff. When someone finally came to take my order and asked, “May I help you?”, I replied, “Yeah, I’ll have one asshole to go.”
L. Spiro Engine: http://lspiroengine.com
L. Spiro Engine Forums: http://lspiroengine.com/forums

#11 SIC Games   Members   -  Reputation: 617

Like
0Likes
Like

Posted 31 August 2014 - 12:11 PM

And Tada!

 

Snapshot1.jpg

 

A couple of things I've changed. When creating the depth stencil view - I also created a depth stencil state with stencil enabled and depth enabled.

 

My program would constantly crash like a mad man - found out it was the XMVECTOR and XMMATRIX inside a 32 bit Dynamic Library. The engine will be brough into the x64 bit later on. So as far as setting up the view and projection matrixes from the light source - I multiplied them both and stored them into a XMFLOAT4x4 inside the ShadowMap class.

 

Now this isn't multisampled - I could multisample it then blur it a bit with gaussian blur. I just don't like the dark area way above on the plane floor. Is this another depth buffer issue when it starts to self shadow or is this normal?

 

The jagged lines got better with perspective set instead of orthographic view. I read perspective is good for spot lights and point lights and Orthrographic is good for Directional Lights.

 

Another issue I noticed is sometimes the shadow map will detatch from the box when I move it around make it float. The bais is set to 0.001f - would I have to perhaps configure the DepthBias inside the Rasterization State?

 

Another thing I changed was the shadow map resolution from whatever the scene height and width was to 2048. The program crashes when I try to use 4096x4096.

 

I believe changing the resolution higher made the shadow map turn out nicer; also changing the near plane and far plane to be 1.0f to 1000.0f.

 

I read on MSDN that a depth texel sampled too big will cause shadow acne. Also depth texel that sampled to close to the light cameras view port will cause sharp and changed lines. Shadow map resolution will also cause jagged shapes inside the shadow map. I may have got some of this confused what MSDN - I'm trying to remember it all.

 

Instead of the camera position being (100, -100, 100) I changed it to (-10,50,-50) which helped as well.

 

On the DepthStencilView I thought the higher the depth stencil resolution DXGI_FORMAT_D32_FLOAT would be better but I couldn't notice any differience. So I changed it back to DXGI_FORMAT_D24_UNORM_S8_UINT;

 

 


Game Engine's WIP Videos - http://www.youtube.com/sicgames88


#12 SIC Games   Members   -  Reputation: 617

Like
0Likes
Like

Posted 31 August 2014 - 12:13 PM

Also if you look closely I noticed the shadow map is projected onto the cube - that can't be normal, right?


Game Engine's WIP Videos - http://www.youtube.com/sicgames88


#13 SIC Games   Members   -  Reputation: 617

Like
0Likes
Like

Posted 31 August 2014 - 12:29 PM

The comment above asking about the self projection of the shadow map on the cube - was because of depth bias in the shadowmap.

 

So I changed a few things - I made the sampler state to be BiLinear with multisample and this is how it looks:

 

Snapshot1.jpg

 

Now, I'll get around to blurring it to a nice soft blur.


Game Engine's WIP Videos - http://www.youtube.com/sicgames88


#14 LancerSolurus   Members   -  Reputation: 612

Like
2Likes
Like

Posted 31 August 2014 - 01:24 PM

I would suspect the dark area behind the cube is beyond the edge of your shadow map. I had an issue like that, I simply did a range test for the edge and didn't render the shadow beyond that. Later on I will go back and see if it's possible to adjust texture clipping to nullify the need for the range test. Just an idea of what it may be...


******************************************************************************************
Youtube Channel


#15 HScottH   Members   -  Reputation: 512

Like
1Likes
Like

Posted 31 August 2014 - 03:32 PM

Nicely done.  As your scene gets larger and more complicated, you will find back-face issues, and the "peter-panning" (shadow separation from base of caster).

 

I moved from PCF filtering to Variance shadow maps; they were faster and solved many of the problems.

 

I then tried Exponential shadow maps, and perform a gaussian blur.  This is what I settled on.



#16 SIC Games   Members   -  Reputation: 617

Like
0Likes
Like

Posted 31 August 2014 - 04:27 PM

I don't plan on sticking to one technique when it comes to shadow mapping. I'm going to try and understand various of ways. I like shadow volumes but which will come later. I want to try sparse voxel global illumination as well as well as the shadow voxelization used in CryEngine 3. What's sad about the shadow mapping - I've gone from 60 frames per second and when I place three objects in a screne it drops down to 30 frames per second. Hopefully, when I rework the rendering system and the deferred rendering system - the frame drops won't be so drastic.

 

I've been doing research about shadows in deferred shading - what I can tell it's not lighting per pixel par say - it's more light volumes than what forward pass rendering does. For point lights one can draw a sphere or a billboard of a circle and blend them together. Which again - the rendering system needs to be reworked a lot for performance and quality.

 

I'm pretty sure there'll be some issues if I stick with this type of shadow mapping. I'm going to look up some of your suggestion HScott like Exponential shadow map. What caught my eye is sub-pixel shadow mapping. I really like that.


Game Engine's WIP Videos - http://www.youtube.com/sicgames88





Old topic!
Guest, the last post of this topic is over 60 days old and at this point you may not reply in this topic. If you wish to continue this conversation start a new topic.



PARTNERS