For some reason my application crashes when I try to print out the values of my std::vector, which is filled with std::strings.

Here's how I declare the vector :

	std::vector <std::string> map
	{
		"###############################################################",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"###############################################################",
	};

And here's how I try to print it out :

	for (int i = 0; i < map.size(); i++)
	{
		printf(map[i].c_str());
	}

The crash message I get is :

Exception thrown at 0x01157216 in ConsoleGame.exe: 0xC0000005: Access violation reading location 0x00000018.

Weird; that code runs fine for me. (It's missing newline characters though)

Forgot to mention that the error leads me to line 512 in the file xstring.

Access violation reading location 0x00000018.

Forgot to mention that the error leads me to line 512 in the file xstring.

for (int i = 0; i < map.size(); i++)
{
printf(map.c_str());
}

Are you by any chance using XCode?

Btw one more thing: It's a security risk to do printf( myCStringVariable ); Perform instead printf( "%s", myCStringVariable );

Cheers

Are you by any chance using XCode?

Btw one more thing: It's a security risk to do printf( myCStringVariable ); Perform instead printf( "%s", myCStringVariable );

Cheers

Could you elaborate on why that's a security risk?

Access violation reading location 0x00000018.

Looks like you are calling a member function on a null object.

Such as:

myThing = null;
myThing->DoSomething();

Look on your stack trace, go back out on the stack to the outermost function that you wrote, and look for a null pointer on any object.

For example, maybe a null pointer value for the string you are trying to print.

Forgot to mention that the error leads me to line 512 in the file xstring.

You're looking in the wrong spot. While it is remotely possible that you found a bug in the standard library, consider that the libraries are used by millions of programmers around the globe every day. The odds that it works correctly for everybody else but is broken for you is astonishingly small.

Always assume the error is in your code, not in the standard library.

for (int i = 0; i < map.size(); i++)
{
printf(map.c_str());
}

Following a hunch, it could be that map doesn't exist, or that it doesn't contain a string (it is empty).

I checked the size of the vector, which for some reason is 0.

I don't understand why though, I've tried giving it a value in the constructor, and in the header file and it still has a value of 0.

Here's some more code :

MapManager.h

#pragma once

#include <vector>
#include <iostream>

class MapManager
{

public:

	std::vector <std::string> map =
	{
		"###############################################################",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"#                                                             #",
		"###############################################################"
	};

	void DrawMap();

	static MapManager &GetInstance();

private:

	MapManager();
	~MapManager();

};

MapManager.cpp

#include "MapManager.h"



MapManager::MapManager()
{

}

void MapManager::DrawMap()
{

	std::cout << map[0].c_str() << std::endl;

	for (int i = 0; i < map.size(); i++)
	{
		printf(map[i].c_str());
	}
}

MapManager &MapManager::GetInstance()
{
	MapManager temp;
	return temp;
}

MapManager::~MapManager()
{
}