I am working on my first RPG in Visual Basic. I have gotten to a point where I need a good damage equation for when attacking enemies. The statistics I have are Strength, Endurance, Agility, Power, and Intelligence. I have a basic equation using the attacker''s Strength and the enemy''s Endurance, as below.

If characterStrength > enemyEndurance Then
  enemyHP = enemyHP - characterStrength - 5 + Random(characterLevel)
elseif characterStrength < enemyEndurance then
  enemyHP = enemyHP - characterStrength + 5 + Random(characterLevel)
end if
 

If the attacker has greater attack then the defender’s endurance, do extra damage. If attacking strength is less than defending endurance, do less damage. The Random statement adds some randomness to the attack, based on the character’s level. As the character goes up in levels, his attacks can increase too. I also have here the accompanying Random function, just for completeness.

Public Function Random(ByVal num As Long) As Long
  Random = Int(num * Rnd)
End Function
 

Now, this is just some pseudo code I wrote up, just to get started. What I would like to do is to add something to check for the Agility of the character and enemy, and make them both miss sometimes when attacking, and also to sometimes do double damage. As this is my first RPG, I would like some suggestions for including the Agility and occasionally lucky hits through code. Grant Palin

Thanks Serge, the equation you provided looks pretty good. I've revised it as below. I corrected a few errors...There was an End If missing at the bottom.

If Random(characterLevel) < x Then ‘Miss   enemyHP = enemyHPElseIf Random(characterLevel) >=x and Random(characterLevel)  If characterStrength > enemyEndurance Then    enemyHP = enemyHP - characterStrength - 5 - Random(characterLevel)  ElseIf characterStrength < enemyEndurance Then    enemyHP = enemyHP - characterStrength + 5 - Random(characterLevel)  End IfElseIf Random(characterLevel) >=n Then ‘Lucky hit- double damage  If characterStrength > enemyEndurance Then    enemyHP = enemyHP - 2*(characterStrength - 5 + Random(characterLevel))  ElseIf characterStrength < enemyEndurance Then    enemyHP = enemyHP - 2*(characterStrength + 5 + Random(characterLevel))  End IfEnd If  

Note that at the bottom of the code, for the double damage section, I removed the second Random number in each of those two equations, and as you can see, added a 2* in front, to double the effect. I also changed the + in front of each of the Random numbers to -, since I don't want to be giving HP back to the enemy! Only in the first set of equations, though. If I did the same in the second set, I would be losing damage. Anyway, let me know if there are any errors in my editing, and if you have any other ideas, just leave a message here!

Grant Palin

[edited by - gpalin on July 26, 2002 12:48:24 AM]

If I were you I wouldn''t use arbitrary numbers such as ''2*'' or ''-5''. I''d rather make an universal and logical system
But it''s up on you of course.

quote:
If I were you I wouldn''t use arbitrary numbers such as ''2*'' or ''-5''. I''d rather make an universal and logical system.

Why??

Here''s my equation as I have it now, after some revision.

If Random(50) < x Then ‘Miss  Damage = 0   enemyHP = enemyHPElseIf Random(50) >= x and Random(50) < n Then ’Normal hit  If characterStrength > enemyEndurance Then    Damage = characterStrength + 5 + Random(characterLevel)    enemyHP = enemyHP - Damage  ElseIf characterStrength < enemyEndurance Then    Damage = characterStrength - 5 + Random(characterLevel)    enemyHP = enemyHP - Damage  End IfElseIf Random(50) >=n Then ‘Lucky hit- double damage  If characterStrength > enemyEndurance Then    Damage = 2 * (characterStrength + 5 + Random(characterLevel))    enemyHP = enemyHP - Damage  ElseIf characterStrength < enemyEndurance Then    Damage = 2 * (characterStrength - 5 + Random(characterLevel))    enemyHP = enemyHP - Damage  End IfEnd If 

This advanced equation adds checking for the value of a random number; if the random number is below a constant value, no damage is done (a miss). If the value is between the previous constant and the second constant, the damage is a normal amount (normal damage). And if the value is above the second constant, the damage is doubled (lucky attack).

I''d still like to add something for Agility. I''ve got an idea. and I''ll put it online when I''ve got it fleshed out.

Grant Palin

Okay, here''s my new equation.

If Random(50) < x Then ‘Miss  Damage = 0   enemyHP = enemyHPElseIf Random(50) >= x and Random(50) < n Then ’Normal hit  If characterStrength > enemyEndurance Then    Damage = characterStrength + 5 + (characterAgility - enemyAgility) + Random(characterLevel)    enemyHP = enemyHP - Damage  ElseIf characterStrength < enemyEndurance Then    Damage = characterStrength - 5 + (characterAgility - enemyAgility) + Random(characterLevel)    enemyHP = enemyHP - Damage  End IfElseIf Random(50) >=n Then ‘Lucky hit- double damage  If characterStrength > enemyEndurance Then    Damage = 2 * (characterStrength + 5 + (characterAgility - enemyAgility) + Random(characterLevel))    enemyHP = enemyHP - Damage  ElseIf characterStrength < enemyEndurance Then    Damage = 2 * (characterStrength - 5 + (characterAgility - enemyAgility) + Random(characterLevel))    enemyHP = enemyHP - Damage  End IfEnd If 

This version of the equation uses the Agility stats of the attacker and defender. If the attacker has more Agility, he does more damage, and less Agility means less damage.

I am thinking of removing the random numbers based on the character levels, since they don''t seem to have much of an effect on the total damage. If anyone has thoughts on this, please let me know.


Grant Palin

I wouldn''t use numbers like *2 or -5 because

1. You may forget why they''re there
2. They''re hard to change later

It''s much easier to make a variable such as COMBAT_PENALTY or COMBAT_BONUS and use that instead because it would fix the above problems.

Allow me to suggest a few things.

1) Write your character class as an object with all of your listed statistics as properties.

It will be alot easier to keep track of it all, trust me,
but i will stick to your linear method for now.

2) Try not to do as much math on the fly. I''m assuming that like any good RPG there will be alot of combat involved. If your going to call this function alot, which you will, you should resolve as much upfront as possible.

How will you handle armor, how will you change it?

See if any of this looks good:


Const CHAINMAIL_VALUE = 30


Private Function NewAC As Long

NewAC = Agility + EquippedArmorValue

End Function

Private Function ToHit AS Long

ToHit = CharacterStrength + Int(Rnd * 100) + 1

End Function


When your character changes armor then

EquippedArmorValue = CHAINMAIL_VALUE
CurrentAC = NewAC




When your character actually attacks:

If ToHit >= MonsterArmorClass Then

ResolveDamage

Else

You Missed

End If



Kind of tough really to read because i haven''t coded without objects since i''ve learned to do them but definitely don''t recalculate anything in your to hit swing that you can calculate once and carry with you. Invent an ArmorClass that will carry each creatures chance to avoid damage with it, so you don''t have to recalculate it. Also think about your code and your game, you don''t want write a line of code for each incidence in your program, you really just want to write the rules they will use and then toss a bunch of data at your rules. And finally, for the third time(i think) pre-calculate everything you can. VB math functions are really slow. Maybe you could Pre-generate a whole bunch of random numbers when your app loads and then iterate through an array to get your to hit seed. (make any sense?)

Best of Luck!


Dreddnafious Maelstrom

"If i saw farther, it was because I stood on the shoulders of giants."

Sir Isaac Newton

quote:Original post by Dreddnafious Maelstrom
Allow me to suggest a few things.

1) Write your character class as an object with all of your listed statistics as properties.

You mean like this??

Public Type Character  Name As String  Sex As String  Race As String  Class As String  Strength As Long  Endurance As Long  Agility As Long  Power As Long ''Controls the effectiveness of spells  Intelligence As Long ''Controls the number of spell points  MaxHP As Long ''Maximum Hit points  CurHP As Long ''Current HP  MaxSP As Long ''Maximum Spell points  CurSP As Long ''Current SP  Level As Long ''Current level  Experience As Long ''Current experience  ExpToNextLvl As Long ''Experience to next level  Gold As LongEnd TypePublic Hero As Character 

quote:
It will be a lot easier to keep track of it all, trust me,
but I will stick to your linear method for now.

No need, I have a fair grasp of classes, like I showed above. If you thought of that because I had all those seperate variables, that was just some pseudocode I wrote up to get me started. Here''s the real code that I have in the game now...

  If Random(50) < x Then ''Miss- no damage    Damage = 0    Enemy(CurrentType).CurHP = Enemy(CurrentType).CurHP  ElseIf Random(50) >= x And Random(50) < n Then ''Normal hit    If Hero.Strength > Enemy(CurrentType).Endurance Then      Damage = Hero.Strength + 5 + Random(Hero.Level)      Enemy(CurrentType).CurHP = Enemy(CurrentType).CurHP - Damage    ElseIf Hero.Strength < Enemy(CurrentType).Endurance Then      Damage = Hero.Strength - 5 + Random(Hero.Level)      Enemy(CurrentType).CurHP = Enemy(CurrentType).CurHP - Damage    End If  ElseIf Random(50) >= n Then ''Lucky hit- double damage    If Hero.Strength > Enemy(CurrentType).Endurance Then      Damage = 2 * (Hero.Strength + 5 + Random(Hero.Level))      Enemy(CurrentType).CurHP = Enemy(CurrentType).CurHP - Damage    ElseIf Hero.Strength < Enemy(CurrentType).Endurance Then      Damage = 2 * (Hero.Strength - 5 + Random(Hero.Level))      Enemy(CurrentType).CurHP = Enemy(CurrentType).CurHP - Damage    End If  End If 

quote:
2) Try not to do as much math on the fly. I''m assuming that like any good RPG there will be alot of combat involved. If your going to call this function alot, which you will, you should resolve as much upfront as possible.

It''s not a real-time game, if that''s what you''re wondering. I don''t know nearly enough yet to do real-time. My game is played through forms I created in Visual Basic, and combat is turn-based. I don''t think your statement above would be as much of an issue, would it?

That aside, I don''t really understand- should I seperate the calculations somehow? That doesn''t seem to make sense to me, since I''m only doing them in one place: the Combat form. Could you explain yourself some more?

quote:
How will you handle armor, how will you change it?

See if any of this looks good:


Const CHAINMAIL_VALUE = 30


Private Function NewAC As Long

NewAC = Agility + EquippedArmorValue

End Function

Private Function ToHit AS Long

ToHit = CharacterStrength + Int(Rnd * 100) + 1

End Function


When your character changes armor then

EquippedArmorValue = CHAINMAIL_VALUE
CurrentAC = NewAC




When your character actually attacks:

If ToHit >= MonsterArmorClass Then

ResolveDamage

Else

You Missed

End If



Kind of tough really to read because i haven''t coded without objects since i''ve learned to do them but definitely don''t recalculate anything in your to hit swing that you can calculate once and carry with you. Invent an ArmorClass that will carry each creatures chance to avoid damage with it, so you don''t have to recalculate it. Also think about your code and your game, you don''t want write a line of code for each incidence in your program, you really just want to write the rules they will use and then toss a bunch of data at your rules. And finally, for the third time(i think) pre-calculate everything you can. VB math functions are really slow. Maybe you could Pre-generate a whole bunch of random numbers when your app loads and then iterate through an array to get your to hit seed. (make any sense?)

I''m not doing anything with armor yet. I''m trying to get the basic game running first, and to tell the truth, I''m not sure yet exactly which way it''s going to go. All I have (more or less) fully functioning yet are the Character Creation and Combat forms.

However, please do keep up with the helpful advice!

quote:
Best of Luck!

Thanks!!

Grant Palin