#### Archived

This topic is now archived and is closed to further replies.

# Code Reviews, A Call to Action

This topic is 6799 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

## Recommended Posts

##### Share on other sites
*gives standing ovation*

What an article! Code Reviews are kind of like posting to the GDNet message boards in fast-motion, and with less ego

The second case of your story is definitely better, IMO. Not only did they learn how a CSV class works, but they also shared ideas. Although they ended up using an already-built CSV in both cases, that is certainly not always the case (especially in game programming). The general equation is:

group_experience += (member1_experience ^ member2_experience ...)

(I''m using the exponent operator here.)

Or, perhaps an even more realistic equation would be as follows:

group_experience += ((member1_experience ^ member2_experience ...) - (member1_ego ^ member2_ego ...));

I feel that inflated egos are a team''s worst nightmare. But there''s something more important than just ego. Ego affects a team most because it affects communication. Code Reviews seem to be an excellent source of good communication. Anything that increases the amount of good communcation in a team increases the team''s chance for success. Anyway, that''s enough of my opinions

- null_pointer
Sabre Multimedia

##### Share on other sites
I guess there is always the chance of bruising an ego...and to be honest, I used to NOT be open to having a group of people picking through my code. It always seemed so invasive..kinda like a physical exam.

But, after reading that article on gamasutra, I have been in high gear trying to get some sort of code review process implemented on our team.

I think that the biggest draw back in our scenario is that every one is always soo busy that they will automatically try to shootdown anything that might take away from development time.

Anyways...for those of you who haven''t read the article, check it out.

##### Share on other sites
quote:

I think that the biggest draw back in our scenario is that every one is always soo busy that they will automatically try to shootdown anything that might take away from development time.

That is the whole point, it saves time in the long run. Though I suppose many people are only able to see the short term loss that will happen instead of the overall savings in time that could (and probably will) occur.

Why wouldn''t people want other people to fix bugs instead of having to hunt them down themselves? I hate hunting down bugs.

bcj

##### Share on other sites
Don''t touch my code, I''ll review it myself.

##### Share on other sites
I really don''t like people seeing my code; the urge to just copy a little is there. If someone is reviewing my code, and he sees something he likes (which happens often in my code ), he might go, "Well, I''ll just copy a little". Then somewhere else, same thing. And the truth is, once they see a way of doings things that they like, they''re gonna copy it almost regardless; why waste time making your own when the better way to do it is right it front of you?
I know this is a worse case scenario, but admit it: if you see something you like, you do have maybe the slightest urge to just "take a little". I admit it happens to me, and the urge is there, but I don''t steal code. It just doesn''t seem fair (also, most peoples coding styles is way different than mine, since mines the best anyway ).

##### Share on other sites
Zipster you''re missing the point of a code review. I suggest you read the gamasutra article. The whole point of it is to learn from others work and to make sure you know whats going on in their code so if they ever leave someone else can pick up where they were without wasting time trying to figure out what their code does. It also helps kill bugs and bad design before it starts.

Josh

##### Share on other sites
Zipster, do you know how arrogant that makes you sound?

Code reviews are a great thing. No matter how good you think you are, someone will think of something better, or something different that you may not have thought about.

You definately do not have the attitude of a good team member. I for one wouldn''t want to work with you. Team members share information, they don''t horde it.

As for stealing code... Do you use DirectX? Win32 API? I guarantee that you didn''t learn the Win32 API or DirectX without "stealing" examples other people wrote. Oh no! You''re not the coding god you think you are! You thief!!! If you are the one person who learns everything from only the documentation (with no code snippets), then I apologize.

<< most peoples coding styles is way different than mine, since mines the best anyway >>

::rolls eyes::

Books to check out:
Game Architecture and Design
Code Complete

Josh
http://www.jh-software.com

##### Share on other sites
quote:
As for stealing code... Do you use DirectX? Win32 API? I guarantee that you didn''t learn the Win32 API or DirectX without "stealing" examples other people wrote. Oh no! You''re not the coding god you think you are! You thief!!! If you are the one person who learns everything from only the documentation (with no code snippets), then I apologize.

Do you know how rude that makes you sound?

I''m giving my honest opinion (not harming anyone), but assholes like you can''t wait to pounch on someone that doesn''t agree with you!! Oh yeah!! YOU''RE always right now, huh? YOU''RE way is ALWAYS the best way, huh?!?! Because YOU think sharing code is the best way, EVERYONE should, or they''re arrogant!?!?!!? If you could of just told me I misunderstand the principle and tell me to read the article, then fine, but instead you had to be rude. Its people like you I WOULDN''T share code with, if all I got "constructive criticism" like yours!

Next time, I suggest you straighten out your attitude before you attack innocent posters.

##### Share on other sites
ahem...now that i calmed down, i would like to say something:
quote:
This forum isn''t about flaming each other and calling each other arrogent (ahem), its about helping others, and imforming them of their misunderstandings.

I would like to apoligize for being rude in my last post, Josh, as I don''t want to hold a grudge against anyone. But what i said in the last parahragh was 100%. if you don''t agree, say so, and maybe tell the person yor view: perswaysion (however you spell it ).
as for not sharing code, i didn''t clarify, and thats my mistake . What i meant was that i don''t like sharing code with those NOT INVOLVED on the project. If im on a team, well then no shit id have to share code if i wanted to stay on a team.

I just hope we can all be friends and not jump to conclusions and be rude.

1. 1
Rutin
33
2. 2
3. 3
4. 4
5. 5

• 13
• 9
• 9
• 9
• 14
• ### Forum Statistics

• Total Topics
633328
• Total Posts
3011380
• ### Who's Online (See full list)

There are no registered users currently online

×