• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.

Archived

This topic is now archived and is closed to further replies.

Bogart

HELP! std::vector Debug Assertion Failed _BLOCK_TYPE_IS_VALID

4 posts in this topic

Hi all, Below is some sample code that causes a Debug Assertion Failed error in VC++6. It's one of those _BLOCK_TYPE_IS_VALID(pHead->nBlockUse) dealies. This is an example of what I'm trying to do. It's a much more simplified version, but still generates the error. The problem is that the vector push_back calls the destructor for newBarrel and BAM I get the above error.
  
#include <vector>
using namespace std;

///////////////////////////////////////////

// CBarrel

class CBarrel
{
public:
	int		m_nNumMonkeys;
	int*	m_pMonkeys;

public:
	CBarrel() : m_nNumMonkeys(0), m_pMonkeys( NULL )	{}
	~CBarrel()											{ Destroy(); }

	bool	Destroy();
};

bool CBarrel::Destroy()
{
	if ( m_pMonkeys )
		delete [] m_pMonkeys;

	return true;
}
///////////////////////////////////////////


///////////////////////////////////////////

// CZoo

class CZoo
{
public:
	std::vector<CBarrel>	m_pBarrelList;

public:	
	CZoo()					{}
	virtual ~CZoo()			{ m_pBarrelList.clear(); }

	void AddMonkeys( int nNumMonkeys );
};

void CZoo::AddMonkeys( int nNumMonkeys )
{
	CBarrel	newBarrel;

	newBarrel.m_nNumMonkeys = nNumMonkeys;
	newBarrel.m_pMonkeys = new int[nNumMonkeys];
	
	m_pBarrelList.push_back( newBarrel );
}

///////////////////////////////////////////

int main(int argc, char* argv[])
{
	CZoo*	pZoo = new CZoo;

	pZoo->AddMonkeys( 3 );
	pZoo->AddMonkeys( 5 );
	pZoo->AddMonkeys( 2 );
	
	delete pZoo;

	return 0;
}
  
What I'm trying to do, in essence, is have a dynamically allocatable array that gets allocated by another object and pushed onto the back of a list of such objects. Then, that object is responsible for clearing the list and deallocating the memory of each object by calling it's destructor (which is done by the m_pMonkeyList.clear() statement). Why do I get this error when I do the push_back? Why is the destructor being called prematurely (if that's indeed what the problem is)? Any help would be appreciated... Thanks, Bogart [edited by - Stoffel on September 12, 2002 2:30:29 PM]
0

Share this post


Link to post
Share on other sites
I think the problem is because your CBarrel class doesn't have an assignment operator and a copy constructor.

EDIT: As it is now, std::vector has to use the default copy constructor, witch means the data in CBarrel::m_pMonkeys is never copied, just the pointer. Wich means that various barrels will free each others monkeys and such...

[edited by - LNK2001 on September 12, 2002 2:07:48 PM]
0

Share this post


Link to post
Share on other sites
Yup, that''s the problem. You could fix this by either:
- adding the copy constructor and assignment operator to CBarrel
- make your barrel use a std::vector instead of keeping your own array; the default copy ctor and assignment op will then "do the right thing"

I suggest the second method.
0

Share this post


Link to post
Share on other sites
Thanks all,

That did the trick. I added a copy constructor and an assignment operator.

I didn't want to use a std::vector for these arrays since they're huge in my real code and didn't want to worry about the overhead of std::vector constantly resizing.

Thanks again for the help!

Bogart

EDIT: Here's what I added to the CBarrel class in case anyone cares

// copy constructor
CBarrel( const CBarrel &barrel ) :
m_nNumMonkeys( barrel.m_nNumMonkeys ),
m_pMonkeys( new int[barrel.m_nNumMonkeys] )
{
memcpy( m_pMonkeys, barrel.m_pMonkeys, sizeof( int ) * barrel.m_nNumMonkeys );
}

// assignment operator
const CBarrel &operator = ( const CBarrel &barrel )
{
m_nNumMonkeys = barrel.m_nNumMonkeys;
m_pMonkeys = new int[m_nNumMonkeys];
memcpy( m_pMonkeys, barrel.m_pMonkeys, sizeof( int ) * barrel.m_nNumMonkeys );
return *this;
}

[edited by - Bogart on September 12, 2002 2:45:39 PM]
0

Share this post


Link to post
Share on other sites
quote:
Original post by Bogart
I didn''t want to use a std::vector for these arrays since they''re huge in my real code and didn''t want to worry about the overhead of std::vector constantly resizing.



Use the reserve member function of std::vector to reserve memory for push_back() operations. std::vector, if used properly, is just as good as a plain array.
0

Share this post


Link to post
Share on other sites