Back to General and Gameplay Programming

Help with an object oriented window class

elendil67 · 2002-12-03T12:06:33

I am making myself a window class as part of an engine, but it gives a runtime error. From debug information, it screws up at CreateWindowEx(). Does anyone know what I have done wrong? Thanks for your consideration. ///////////////////////////////////////////////////////////////////////// // Name: Create() // Desc: Create() is a function to create a window. // Inpt: Width, height, fullscreen?, icon, handle to instance ///////////////////////////////////////////////////////////////////////// int CWindow::Create(int width, int height, bool fullscreen, char *icon, HINSTANCE hInstance) { ///////////////////////////////////////////////////////////////////////// // The style variable declared here will make the window a popup window // if the fullscreen variable is selected; if not, it will make an // overlapped window. ///////////////////////////////////////////////////////////////////////// int style; if(fullscreen) { style = WS_POPUP; } else { style = WS_OVERLAPPEDWINDOW; } ///////////////////////////////////////////////////////////////////////// // Fill in the window class with the values desired to make the window. ///////////////////////////////////////////////////////////////////////// m_cWC.cbSize = sizeof(WNDCLASSEX); m_cWC.style = CS_HREDRAW | CS_VREDRAW; m_cWC.lpfnWndProc = (WNDPROC)WndProc; m_cWC.cbClsExtra = 0; m_cWC.cbWndExtra = 0; m_cWC.hInstance = hInstance; m_cWC.hIcon = LoadIcon(NULL, icon); m_cWC.hCursor = LoadCursor(NULL, IDC_ARROW); m_cWC.hbrBackground = (HBRUSH)GetStockObject(WHITE_BRUSH); m_cWC.lpszMenuName = NULL; m_cWC.lpszClassName = "CWINDOW"; m_cWC.hIconSm = LoadIcon(NULL, icon); ///////////////////////////////////////////////////////////////////////// // Register the class. ///////////////////////////////////////////////////////////////////////// if(!RegisterClassEx(&m_cWC)) { MessageBox(m_hWnd, "Could not register the window class.", "Error", MB_OK); return 1; } ///////////////////////////////////////////////////////////////////////// // Create the window. ///////////////////////////////////////////////////////////////////////// if(!(m_hWnd = CreateWindowEx(NULL, "CWINDOW", "CWindow", style, 0, 0, width, height, NULL, NULL, hInstance, NULL))) { MessageBox(m_hWnd, "Could not create the window.", "Error", MB_OK); return 1; } return 0; } P.S. The problem is not from the whole window procedure thing, I have that cleared up. [edited by - elendil67 on December 1, 2002 5:09:25 PM]

General and Gameplay Programming Programming

Started by elendil67 December 01, 2002 04:02 PM

16 comments, last by elendil67 21 years, 4 months ago

Evil Bill

126

December 01, 2002 06:38 PM

About the sig, just use the Width= and Height= values of your image.
Here: <img src="http://www.gras-wien.gruene.at/pics/napster.gif" border=0 width=100 height=135> =

Edit: oops, i broke it :s

[edited by - Evil Bill on December 1, 2002 7:51:11 PM]

Member of the Unban Mindwipe Society (UMWS)

elendil67

122

Author

December 02, 2002 07:43 PM

Forget the sig... do you guys no whats wrong??? Yes, I am using system icons. Thanks so far for your help

When you go homeTell them of us, and say:For your tomorrow,We gave our today.

Qw3r7yU10p!

819

December 02, 2002 08:01 PM

text is better than pictures

Oluseyi

2,123

December 02, 2002 08:09 PM

quote:Original post by elendil67
do you guys no whats wrong?

Of course not, you''ve given us nothing with which to diagnose your problem. What is the exact error ("a runtime error" is not exact)? What are the values of the various parameters when the error occurs?

Ask a good question if you want good answers.

DerekSaw

243

December 02, 2002 10:42 PM

WndProc problem?

"after many years of singularity, i'm still searching on the event horizon"

Evil Bill

126

December 03, 2002 06:40 AM

quote:Original post by Evil Bill
Does it work if you set the WndProc to DefWindowProc? (I know you said its not, but thats all i can see could cause the problem)...

Edit: "Forget the sig..." I wish we could

[edited by - Evil Bill on December 3, 2002 10:27:55 AM]

Member of the Unban Mindwipe Society (UMWS)

Anonymous

December 03, 2002 07:00 AM

listen to Evil Bill and Oluseyi and everyone else.

* post the error message. you should be using a call to FormatMessage with GetLastError to get a meaningful error message rather than your generic and useless error message. see the MSDN docs on FormatMessage for an example.
* post the code of the calling function.
* post the code to your static WndProc. why are you type casting your WndProc to a WNDPROC?
* post the code to your class non-static WndProc.

are you using a singleton class instance or not? if not, post the code that attempts to get your class instance pointer to your static WndProc because your not using the "standard" method for doing so.

there''s a lot that goes on behind the scenes when creating a window. and not all of it happens in the CreateWindow/Ex function. there are window messages that are queued up and handled, particularly WM_NCCREATE and WM_CREATE, which also could be part of the problem.