Back to General and Gameplay Programming

char memory leak?

TDragon · 2002-12-10T10:09:56

I have a function that will read a string from a file and convert it to a number (using fread() and atoi()). Problem is, I think there''s a memory leak somewhere, because one of my global integers keeps getting overwritten. Could someone look at my code and tell me what I should change? The idea is to be able to assign an integer to the return value of the function, thus: int value = ReadNumber(afile, 96); such that when the function reaches a character of value 96 (or whatever is passed) it converts what it has into a number and returns the number. I think the problem is actually happening at the calling of the atoi() function. int ReadNumber(FILE *thefile, char stopval) { int number, i, exloop; char extra; char string[5]; i = 0; exloop = 0; while(!exloop) { fread(&extra, sizeof(char), 1, thefile); if(char1 == stopval) { exloop = 1; } else { string[i] = char1; } i++; } string[i] = NULL; number = atoi((const char *)string); return number; } Twilight Dragon

General and Gameplay Programming Programming

Started by TDragon December 02, 2002 05:04 PM

11 comments, last by TDragon 21 years, 4 months ago

civguy

308

December 10, 2002 01:24 AM

quote:Original post by sark
C++? 21st Century? C++ is not a modern language... and it shows. I dont mean to start a flame war, but any language where you have to use forward declarations doesnt classify as a "21st century language" to me.

What I meant was that he shouldn''t concern himself with increase in file size and that C++ doesn''t have any disadvantages anymore, when compared to C (situation was different 10 years ago). Not that C++ was a new and hot language.

niyaw

158

December 10, 2002 01:33 AM

quote:Original post by civguy
push_back for strings? Sounds pretty tedious to me, when there''s operator+=

you can see i''m using vectors much more often than strings.

GdWiki

TDragon

679

Author

December 10, 2002 10:09 AM

What I meant with those comments was that, since C++ compiles much more strictly (at least with my compiler), I''ll have to go back and change some of my more sloppy sections of code in that program. Since this is a makeshift program anyway, and is getting rather long already (I had hoped to be finished with it by now and to get on with the more important thing: the actual game engine), I don''t want to go back and do all that. Thus the extra typing.

Also, I''ll have to familiarize my self with the std::string library; thus far I''ve only used C-strings and been quite content.

Twilight Dragon

{[JohnE, Chief Architect and Senior Programmer, Twilight Dragon Media{[+++{GCC/MinGW}+++{Code::Blocks IDE}+++{wxWidgets Cross-Platform Native UI Framework}+++

char memory leak?

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

char memory leak?

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

Reticulating splines