How come...

Daniel Schroeder · 2003-03-04T10:54:17

How come when I declare a class with the .h and .cpp, sometimes I have to #include the .cpp at the bottom of my .h file, and sometimes I don''t. My problem, to make it more clear, is when I declare a class with a header and implementation file, when I go to compile and run my program, sometimes I get a bunch of unresolved external errors when it tries to link my .h and .cpp together. To fix the problem, I simply #include the .cpp after the class declaration in the .h file, which I shouldn''t have to, but it fixes the problem. This will clear the problem up until after working on my program some more, and trying to link all the files again, I''ll get the same error as before, and to fix it up this time, I simply remove the #include .cpp from the .h file, then everything works fine again. And this basically just goes back and forth with my removing the .cpp then next time including the .cpp. Does anybody know why this is. I''m using Visual Studio 6, C++, and I''m not using templates or anything like that. I do have the #include .h in the .cpp, and use ifndef blah define blah in both my .h and .cpp. Also, I do not have this problem with just this class, it has happened with others, but does not happen with all of them. Anybody have any ideas? Thanks in advance - Dan He who laughs, lasts

General and Gameplay Programming Programming

Started by deadlydog March 02, 2003 12:49 PM

11 comments, last by deadlydog 21 years, 1 month ago

deadlydog

170

Author

March 03, 2003 11:11 AM

This is the exact error I get:

Linking...
Connex.obj : error LNK2005: "public: __thiscall CBlock::CBlock(int,int,int,int,int,int,int,int)" (??0CBlock@@QAE@HHHHHHHH@Z) already defined in CBlock.obj
Connex.obj : error LNK2005: "public: __thiscall CBlock::~CBlock(void)" (??1CBlock@@QAE@XZ) already defined in CBlock.obj
Connex.obj : error LNK2005: "public: void __thiscall CBlock::ChangeBlockType(int)" (?ChangeBlockType@CBlock@@QAEXH@Z) already defined in CBlock.obj
Connex.obj : error LNK2005: "public: bool __thiscall CBlock::RotateBlockClockwise(void)" (?RotateBlockClockwise@CBlock@@QAE_NXZ) already defined in CBlock.obj
Connex.obj : error LNK2005: "public: bool __thiscall CBlock::RotateBlockCounterClockwise(void)" (?RotateBlockCounterClockwise@CBlock@@QAE_NXZ) already defined in CBlock.obj
Connex.obj : error LNK2005: "public: bool __thiscall CBlock::MoveBlockLeft(void)" (?MoveBlockLeft@CBlock@@QAE_NXZ) already defined in CBlock.obj
Connex.obj : error LNK2005: "public: bool __thiscall CBlock::MoveBlockRight(void)" (?MoveBlockRight@CBlock@@QAE_NXZ) already defined in CBlock.obj
Connex.obj : error LNK2005: "public: bool __thiscall CBlock::MoveBlockDown(void)" (?MoveBlockDown@CBlock@@QAE_NXZ) already defined in CBlock.obj
Connex.obj : error LNK2005: "public: bool __thiscall CBlock::MoveBlockUp(void)" (?MoveBlockUp@CBlock@@QAE_NXZ) already defined in CBlock.obj
Connex.obj : error LNK2005: "public: bool __thiscall CBlock::MoveEntireBlockToCell(int,int)" (?MoveEntireBlockToCell@CBlock@@QAE_NHH@Z) already defined in CBlock.obj
Connex.obj : error LNK2005: "public: int __thiscall CBlock::ReturnBlockCellRow(void)const " (?ReturnBlockCellRow@CBlock@@QBEHXZ) already defined in CBlock.obj
Connex.obj : error LNK2005: "public: int __thiscall CBlock::ReturnBlockCellColumn(void)const " (?ReturnBlockCellColumn@CBlock@@QBEHXZ) already defined in CBlock.obj
Connex.obj : error LNK2005: "public: int __thiscall CBlock::ReturnBlockStartingCellRow(void)const " (?ReturnBlockStartingCellRow@CBlock@@QBEHXZ) already defined in CBlock.obj
Connex.obj : error LNK2005: "public: int __thiscall CBlock::ReturnBlockStartingCellColumn(void)const " (?ReturnBlockStartingCellColumn@CBlock@@QBEHXZ) already defined in CBlock.obj
Connex.obj : error LNK2005: "public: bool __thiscall CBlock::IsEntireBlockMoveValid(struct sBlock &)const " (?IsEntireBlockMoveValid@CBlock@@QBE_NAAUsBlock@@@Z) already defined in CBlock.obj
Connex.obj : error LNK2005: "public: void __thiscall CBlock:

laceEntireBlockOnBoard(int)" (?PlaceEntireBlockOnBoard@CBlock@@QAEXH@Z) already defined in CBlock.obj
Connex.obj : error LNK2005: "public: void __thiscall CBlock::EraseEntireBlockFromBoard(void)" (?EraseEntireBlockFromBoard@CBlock@@QAEXXZ) already defined in CBlock.obj
Connex.obj : error LNK2005: "public: bool __thiscall CBlock::SetBlockCellRow(int)" (?SetBlockCellRow@CBlock@@QAE_NH@Z) already defined in CBlock.obj
Connex.obj : error LNK2005: "public: bool __thiscall CBlock::SetBlockCellColumn(int)" (?SetBlockCellColumn@CBlock@@QAE_NH@Z) already defined in CBlock.obj
Connex.obj : error LNK2005: "public: bool __thiscall CBlock::SetBlockCellStartRow(int)" (?SetBlockCellStartRow@CBlock@@QAE_NH@Z) already defined in CBlock.obj
Connex.obj : error LNK2005: "public: bool __thiscall CBlock::SetBlockCellStartColumn(int)" (?SetBlockCellStartColumn@CBlock@@QAE_NH@Z) already defined in CBlock.obj
Connex.obj : error LNK2005: "public: void __thiscall CBlock::DrawAllBlocks(void)" (?DrawAllBlocks@CBlock@@QAEXXZ) already defined in CBlock.obj
Connex.obj : error LNK2005: "private: void __thiscall CBlock::LoadBlocksIntoBlockData(void)" (?LoadBlocksIntoBlockData@CBlock@@AAEXXZ) already defined in CBlock.obj
Debug/Connex.exe : fatal error LNK1169: one or more multiply defined symbols found
Error executing link.exe.

- Dan
He who laughs, lasts

-Dan- Can't never could do anything | DansKingdom.com | Dynamic Particle System Framework for XNA

Qw3r7yU10p!

819

March 04, 2003 02:56 AM

Don''t put the CBlock.cpp file in the CBlock.h file

Insert the CBlock.cpp file put it into your project. The file will compile into an object file which will then be linked with whatever other .cpp files are using the CBlock.h file. They will find the functions defined just once in the CBlock.obj file.

Okay?

deadlydog

170

Author

March 04, 2003 10:54 AM

Thnx for all the replies everyone. The problem was just that I was using the ifndef and define''s in my .cpp as well as my .h''s. Once I took them out of my .cpp file, everything worked fine without the include .cpp in the .h. So winner was Neophyte. Thnx for the solution, and thanks for all the other suggestions from everyone else.

- Dan
He who laughs, lasts

-Dan- Can't never could do anything | DansKingdom.com | Dynamic Particle System Framework for XNA

How come...

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

How come...

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

Reticulating splines