The code impact would not be that great with any of the examples unless called serveral thousand times or greater. Each revision is better and yes the compiler would know to bit shift when doing operation against a constant.

Though I do beleive that it betteris written with hungrain notation on the respect of readiblity. And I'm the type of guy that the curly bracket is on its own line..... Easily showing you where your if statement of loop begins and ends by tracking it back up to the next one on the same line with correct indentation.

optimizations does not play any roll during development any. It is best to leave that for last as you might have to rewrite half of it anyways. Like proformance gains from accessing array's with ++-> is faster than indexing into it. by advancing the pointer to the correct location speeds this type of operation up.

Of coarse there are many other types statments that any group programmers may use. But the point is that the all must agree on readiblity and when to think about optimizations. If you see one glaring at you and you feel like you can not close the file with out changing it then, I would suggest commenting the original out the making the modification. Otherwise it would give me perfect reason to slap you upside the head for not talking to others about it, and removing code that could have well be optimized out of use anyways.

Edit -- bad grammer..

[edited by - afterburn on June 6, 2003 2:03:08 PM]