I hope you realize that such a conversion will never be perfect. How do you hope to express a square root as a fraction?

But ignoring infinte sequences (even recurring), I would suggest keeping the same method, but done slightly differently. Start by multiplying the float by N! where N is a number around say 20. Test to see if this is within a certain amount of an integer. If not... try a larger value of N. Give up when N reaches a given size or when float*N! is greater than 9 digits (or however long the mantissa in a float is). It is important to allow it to give up, as any realistic fraction converter would just approximate nasty fractions to nice ones. There is not enough data in a float to do it to many digits.

Once you have this integer, call it A. Then the fraction will
be A/N!. You can cancel down if you feel bloody minded, but then you are back to where you are started with doing numbers one by one.

The speedup is precalculating N! so there is only one multiplication for several numbers.

NB: You may complain that you could get smaller numbers using the product from 1 to N of N, but that would not give the right ratio of primes. N! is likely to be a multiple of any non-prime a good deal higher than N, while the other isn''t.

Aren''t all floating points stored in the binary format?

If that''s the case, it means that there is a finite number of binary digits after the point. If you know that number, n, your fraction is just the numbers after the point, divided by 2 ^ n. In decimal,

3.942 = 3 + 942 / 10 ^ 3

HTH,

Cédric

The way to go if you want nice results quite fast:

use continued fractions...
every number can be expressed as:

                  1a = n0 + ---------------------                      1         n1 +  ---------------                           1                 n2 +  --------                          ...  

This fraction can be infinite or finite, depending on the number a considered.

Ok, now the trick you should use:
take a float.
---> it's an integer part n0
---> plus a fractional part f0

take the inverse of f0.
again it's an integer part n1 and a fractional part f1.

Apply this recursively until some criteria is met (for example if ni is quite big, 1/ni -> 0 and then you can halt).

At this point you have a nice sequence of ni's which you can reduce to a single fraction A/B; it should be pretty easy since you already write the whole library.

Well that's it. Note that there's plenty of room for optimizations in the way you're gonna program this idea.

As far as I know, it's THE way to go if you want to convert float to fractions. But also notice that some floats convert badly to fraction (especially the numbers which are not in Q, like the square roots and so on...).

Hope it helps,
jods

[edited by - jods on July 6, 2003 11:44:06 AM]

Why not just do something like this:

If the variable has 3 decimal places.. multiply by 1000 (remove decimal places!). Then you can simply find the lowest common denominator and find the fraction.