Back to General and Gameplay Programming

MORE C help needed! :)

CoiN · 2000-06-28T10:00:58

This is the piece of code thats givin'' me problems:void main(void) { int count; double average[10]; char names[10][50]; for (count=1;count<10;count++) { printf ("\nEnter name %d... ", count); gets (names[count]); printf ("\nEnter Average %d... ", count); scanf ("%lf", &average[count]); } for (count=1;count<10;count++) { printf ("\n%d. %s %lf", count, name[count], average[count]); } } Its a simple piece of code which reads ten strings, and ten doubles. Ive done this type of thing lots of times but yet this will not seem to work. The Progblem: After the program reads the first string and double in, the next time it loops round it just skips past the gets() function and prints Enter Average and waits on on scanf for an input. This seems pretty strange to me but I must be doin somin wrong Thanks in Advance....

General and Gameplay Programming Programming

Started by CoiN June 27, 2000 11:13 AM

15 comments, last by CoiN 23 years, 9 months ago

CoiN

122

Author

June 27, 2000 02:59 PM

May aswell get another question in here

Should this piece of code work?

    void main(void){     char *p;     scanf ("%s", p);     printf ("%s", p);}

Im sure i remember using character pointers to hold strings this way, but my mind has gone blank today

djsteffey

1,347

June 27, 2000 03:10 PM

why not just use cin and cout
it makes the code look so much better and easier to read
you dont have to make all those function calls.......i know using cin and cout really do call functions but this is hidden from you and is easy to implement

    #include <iostream.h>void main(){    double average[10];    char names[10][50];    for (int count=0; count < 10; count++)    {        cout << "Enter name " << count << endl;        cin >> names[count];        cout << "Enter average " << count << endl;        cin >> average[count];    }    for (int i=0; i<10; i++)    {        cout << names<i> << "    " << average[i] << endl;    }

"Now go away or I shall taunt you a second time"
- Monty Python and the Holy Grail
themGames Productions

Stoffel

250

June 27, 2000 03:22 PM

quote:
Should this piece of code work?

void main(void)
{
char *p;
scanf ("%s", p);
printf ("%s", p);
}

No. p is a pointer to a character or character array, but it isn''t initialized, so it points to nothing. You''ll get an access error. You need to add:

p = new char[50];

in order to get it to work. Also, after you''ve used p (i.e. at the end of the program), you should delete it:

delete [] p;

Gladiator

127

June 27, 2000 03:23 PM

CoiN, to answer your question, yes, you CAN do that, but that doesn''t mean it''s correct. You write to random memory, and most of the time that will cause a GPF if you''re working under Windows, if you''re in DOS, you might not get any errors, but the program is going to crash someone''s computer (including yours) if it unexpectedly write to a memory location it''s not supposed to... In order to fix the problem you have to allocate enough memory to hold your array of chars (string). Other than that, the code is going to work, especially in DOS...

Hope this helps!

..-=ViKtOr=-..