quote:Original post by EstorBoring task. That code is C, not C++ so fixing it to use exceptions and the idioms that go with it (RAII) would mean rewriting it. With C++ stuff (e.g. streams, strings, exceptions) it''d look pretty different and a lot shorter, that I can assure.
exeptions... exeptions... ok show me please, haw will be lookin this code with exeprions ???
quote:Original post by Estor
exceptions... exceptions... ok show me please, haw will be lookin this code with exceptions???
#include <stdio.h>#include <stdlib.h>int err = 0;// Err values// 0 - no error and return value is buffer adres// if return value = NULL then// 1 - name is a NULL ponter// 2 - file is empty// 3 - out of memory// 4 - file errorchar*LoadFile (char *name){ FILE *fhnd; char *buf; size_t len; if (name) { fhnd = fopen (name, "rb"); if (fhnd) { fseek (fhnd, 0, SEEK_SET); fseek (fhnd, 0, SEEK_END); len = ftell (fhnd); fseek (fhnd, 0, SEEK_SET); if (len) { buf = (char*) malloc (len + 1); if (buf) { if (fread (buf, 1, len, fhnd) == len) { fclose (fhnd); return (buf); } err++; } err++; free (buf); } err++; } err++; fclose (fhnd); } err++; return (NULL);}voidSYS_Error (char* e){ if (e) printf ("%s", e); exit(1);}intmain (){ char *ptr = LoadFile ("blebleble.txt"); if (!ptr) { switch (err) { case 1: SYS_Error ("Invalid file name"); break; case 2: SYS_Error ("file is empty"); break; case 3: SYS_Error ("out of memory"); break; case 4: SYS_Error ("file error"); break; default: SYS_Error ("???? what a hell ????"); break; } } free (ptr); return (0);}
#include <fstream>#include <iostream>#include <sstream>#include <stdexcept>#include <string>std::string LoadFile(const std::string& name){ std::ifstream foo(name.c_str()); std::stringstream bar; if (foo.fail()) throw std::runtime_error("Couldn''t open file."); bar << foo.rdbuf(); if (foo.fail()) throw std::runtime_error("Error reading file."); std::string result = bar.str(); if (result.size() == 0) throw std::runtime_error("File is empty."); return result;}int main(){ try { std::string text = LoadFile("\\foo.txt"); } catch (std::exception& e) { std::cout << e.what() << std::endl; }}
void MyFunc(int *aNumber){ if (aNumber == NULL) { return; } else { *aNumber++; }} quote:Original post by rsegal
Ok so here''s a new for you guys since I got such an awesome response from my first post. Should void functions be using return.void MyFunc(int *aNumber){ if (aNumber == NULL) { return; } else { *aNumber++; }}
...
void MyFunc(int *aNumber){ if (aNumber == NULL) return; *aNumber++;} 
quote:Original post by rsegal
Ok so here''s a new for you guys since I got such an awesome response from my first post. Should void functions be using return.void MyFunc(int *aNumber){ if (aNumber == NULL) { return; } else { *aNumber++; }}
The visual c++ compiler is cool with it and execution of such a call seems to have no problems. I have no problem with it either. I really think this is an aestethic thing, something that a teacher might take marks off for.
[edited by - rsegal on December 17, 2003 3:09:51 PM]
void MyFunc(int *aNumber){ if (aNumber) *aNumber++;}
