Back to General and Gameplay Programming

Am I Leaking? STL + Texture Manager...

GroZZleR · 2003-12-19T19:54:01

Hey all, I've got this texture manager in the works. Right now I'm just getting comfortable with STL, because I've never worked with it before. I'm jus wondering if the following code is leaking memory or not. I use new without delete in a vector, but does the STL Vector clean it up for me? Or do I still have to go in and delete it? Here it is: #include <stdio.h> #include <string.h> #include <vector> using namespace std; class CTexture { public: CTexture(char *szTextureName) { sprintf(m_szTextureName, szTextureName); m_iReferenceCount = 1; } void IncreaseReferenceCount(void) { m_iReferenceCount++; } void DecreaseReferenceCount(void) { m_iReferenceCount--; } int GetReferenceCount(void) { return m_iReferenceCount; } char *GetTextureName(void) { return m_szTextureName; } private: int m_iReferenceCount; char m_szTextureName[255]; }; class CTextureManager { public: ~CTextureManager() { m_TextureList.clear(); } CTexture *LoadTexture(char *szTextureName) { // Is the texture already loaded? for(vector<CTexture *>::iterator TextureIterator = m_TextureList.begin(); TextureIterator != m_TextureList.end(); TextureIterator++) { if(strcmp(szTextureName, (*TextureIterator)->GetTextureName()) == 0) { (*TextureIterator)->IncreaseReferenceCount(); return (*TextureIterator); } } // Its not loaded, lets press on. m_TextureList.push_back(new CTexture(szTextureName)); return (CTexture *)m_TextureList.back(); } void UnloadTexture(CTexture *pTexture) { // Find The Texture... for(vector<CTexture *>::iterator TextureIterator = m_TextureList.begin(); TextureIterator != m_TextureList.end(); TextureIterator++) { if(pTexture == (*TextureIterator)) { (*TextureIterator)->DecreaseReferenceCount(); // If we have 0 or less (less?! WTF!) references to the texture, delete it. if((*TextureIterator)->GetReferenceCount() < 1) m_TextureList.erase(TextureIterator); return; } } return; } void UnloadTexture(char *szTextureName) { // Find The Texture... for(vector<CTexture *>::iterator TextureIterator = m_TextureList.begin(); TextureIterator != m_TextureList.end(); TextureIterator++) { if(strcmp(szTextureName, (*TextureIterator)->GetTextureName()) == 0) { (*TextureIterator)->DecreaseReferenceCount(); // If we have 0 or less (less?! WTF!) references to the texture, delete it. if((*TextureIterator)->GetReferenceCount() < 1) m_TextureList.erase(TextureIterator); return; } } return; } void PrintTextureList(void) { for(vector<CTexture *>::iterator TextureIterator = m_TextureList.begin(); TextureIterator != m_TextureList.end(); TextureIterator++) printf("\t%s\n", (*TextureIterator)->GetTextureName()); return; } vector<CTexture *> m_TextureList; }; int main() { CTextureManager Manager; CTexture *pTexture1a = Manager.LoadTexture("One"); CTexture *pTexture1b = Manager.LoadTexture("One"); CTexture *pTexture1c = Manager.LoadTexture("One"); CTexture *pTexture2a = Manager.LoadTexture("Two"); CTexture *pTexture2b = Manager.LoadTexture("Two"); Manager.PrintTextureList(); printf("%s\n", pTexture1a->GetTextureName()); printf("%s\n", pTexture1b->GetTextureName()); printf("%s\n", pTexture1c->GetTextureName()); printf("%s\n", pTexture2a->GetTextureName()); printf("%s\n", pTexture2b->GetTextureName()); printf("REF COUNT: %d | %d\n", pTexture1a->GetReferenceCount(), pTexture2a->GetReferenceCount()); Manager.UnloadTexture(pTexture2b); printf("REF COUNT: %d | %d\n", pTexture1a->GetReferenceCount(), pTexture2a->GetReferenceCount()); Manager.PrintTextureList(); printf("\n"); Manager.UnloadTexture(pTexture2a); Manager.PrintTextureList(); return 0; } It works exactly how I want it to work thusfar, but I just want to make sure I'm not creating a memory leaked mess before I continue with it =) Thanks all! [edited by - GroZZleR on December 15, 2003 5:16:09 PM]

General and Gameplay Programming Programming

Started by GroZZleR December 15, 2003 04:15 PM

12 comments, last by GroZZleR 20 years, 4 months ago

Ronin Magus

142

December 18, 2003 02:41 PM

quote:Original post by Enokh
I thought that if you have a vector in a class which is in static memory (ex: int x) then when that variable exists the scope the vector inside it will completely erase itself as well automatically. Don''t even need a deconstructor... Am I wrong here?

Do you mean that if you have a vector inside an object, and the object goes out of scope (destructs) then the vector will erase itself? If that''s what you meant, then yes.. the vector erases itself in its destructor.

daveandrews.org - a Christian Programmer''s Weblog | Dusty Engine - a task engine using Irrlicht | Computer Guys Run the World
How to be a Programmer

GroZZleR

820

Author

December 18, 2003 02:49 PM

But I''m allocating memory itself inside the vector...

vector.pushback(new CObject);

So when the vector goes out of scope, the list of pointers is lost but the memory itself is not freed.

Ready4Dis

180

December 19, 2003 12:59 AM

quote:Original post by krez
even if the pointer was NULL (0), you could still delete it (you don''t need the "if" much less the "assert"). if it wasn''t NULL, but pointed to an invalid address, neither would help anyway.

i''d check that the pointer wasn''t NULL or invalid before putting it in the vector.

eh, don''t mind me, i was just pointing it out in case someone else reading didn''t know. i guess it sounded like i was trying to press my style on you. i hope i didn''t come off as a dick.

You completely did not read, and/or comprehend, what he just said.

Yes, you CAN call delete on something that is NULL without issue, but, it should not ever be null, and if it is, he would like to know about it (error checking). If you just call delete without any type of checking, there is no way to know when something goes bad.

tiutiu

122

December 19, 2003 07:54 PM

for managers (mesh or texture) i use an std::map, and smart pointers instead of pointers. So when i use the clear() method, smartpointer destructor takes care of memory deletion.
I think its a kinda good use of SPs. Opinions anyone?

Am I Leaking? STL + Texture Manager...

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

Am I Leaking? STL + Texture Manager...

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

Reticulating splines