Bug in dice rolling

unrealfragmaster · 2004-04-11T14:06:27

I have this code to roll 4 dice, add them up, and take away the smallest. The value is then assigned to a variable such as strength, the roll is then repeated and the result assigned to dexterity, then repeated etc. But there seems to be a bug, it works ok most of the time, but sometimes in the last couple of rolls, the Smallest Value is not correct, eg it says 2 when in the rolls you can see that there was a 1. I have the sleep(3000); in there just so I can see each result before it fills up a small dos screen ;-) //FIRST IS THE STRENGTH CALCULATION int NUMBER_OF_SIDES =6; srand( (unsigned)time( NULL ) ); int strengthroll[4]; for (int i = 0; i < 4; ++i) strengthroll[i] = 1 + rand() % NUMBER_OF_SIDES; int sum = 0; // Start the total sum at 0. for (i=0; i<4; i++) { sum+=strengthroll[i]; } system("cls"); cout<<"\nThe die rolls for strength are: "; for(int u=0; u < 4; u++) cout<<strengthroll[u]<<" "; cout <<"\nThe total of the strength rolls is " <<sum; int smallest; smallest = 999999; for(i=1; i<u; i++) //check until condition i=n if(strengthroll[i] < smallest) smallest = strengthroll[i]; strength = sum - smallest; cout<<"\nSmallest value= "<<smallest; cout<<"\n"<<charname<<"'s strength is "<<strength; //SECOND IS THE DEXTERITY CALCULATION int dexterityroll[4]; for (i = 0; i < 4; ++i) dexterityroll[i] = 1 + rand() % NUMBER_OF_SIDES; sum = 0; // Start the total sum at 0. for (i=0; i<u; i++) { sum+=dexterityroll[i]; } Sleep(3000); cout<<"\nThe die rolls for dexterity are: "; for(u=0; u < 4; u++) cout<<dexterityroll[u]<<" "; cout <<"\nThe total of the dexterity rolls is " <<sum; int smalldex; smalldex = 999999; for(i=1; i<u; i++) //check until condition i=n if(dexterityroll[i] < smalldex) smalldex = dexterityroll[i]; dexterity = sum - smalldex; cout<<"\nSmallest value= "<<smalldex; cout<<"\n"<<charname<<"'s dexterity is "<<dexterity; //THIRD IS THE CONSTITUTION CALCULATION int constitutionroll[4]; for (i = 0; i < 4; ++i) constitutionroll[i] = 1 + rand() % NUMBER_OF_SIDES; sum = 0; // Start the total sum at 0. for (i=0; i<u; i++) { sum+=constitutionroll[i]; } Sleep(3000); cout<<"\nThe die rolls for constitution are: "; for(u=0; u < 4; u++) cout<<constitutionroll[u]<<" "; cout <<"\nThe total of the constitution rolls is " <<sum; int smallcon; smallcon = 999999; for(i=1; i<u; i++) //check until condition i=n if(constitutionroll[i] < smallcon) smallcon = constitutionroll[i]; constitution = sum - smallcon; cout<<"\nSmallest value= "<<smallcon; cout<<"\n"<<charname<<"'s constitution is "<<constitution; //FOURTH IS THE INTELLIGENCE CALCULATION int intelligenceroll[4]; for (i = 0; i < 4; ++i) intelligenceroll[i] = 1 + rand() % NUMBER_OF_SIDES; sum = 0; // Start the total sum at 0. for (i=0; i<u; i++) { sum+=intelligenceroll[i]; } Sleep(3000); cout<<"\nThe die rolls for intelligence are: "; for(u=0; u < 4; u++) cout<<intelligenceroll[u]<<" "; cout <<"\nThe total of the intelligence rolls is " <<sum; int smallint; smallint = 999999; for(i=1; i<u; i++) //check until condition i=n if(intelligenceroll[i] < smallint) smallint = intelligenceroll[i]; intelligence = sum - smallint; cout<<"\nSmallest value= "<<smallint; cout<<"\n"<<charname<<"'s intelligence is "<<intelligence; //FIFTH IS THE WISDOM CALCULATION int wisdomroll[4]; for (i = 0; i < 4; ++i) wisdomroll[i] = 1 + rand() % NUMBER_OF_SIDES; sum = 0; // Start the total sum at 0. for (i=0; i<u; i++) { sum+=wisdomroll[i]; } Sleep(3000); cout<<"\nThe die rolls for wisdom are: "; for(u=0; u < 4; u++) cout<<wisdomroll[u]<<" "; cout <<"\nThe total of the wisdom rolls is " <<sum; int smallwis; smallwis = 999999; for(i=1; i<u; i++) //check until condition i=n if(wisdomroll[i] < smallwis) smallwis = wisdomroll[i]; wisdom = sum - smallwis; cout<<"\nSmallest value= "<<smallwis; cout<<"\n"<<charname<<"'s wisdom is "<<wisdom; //SIXTH IS THE CHARISMA CALCULATION int charismaroll[4]; for (i = 0; i < 4; ++i) charismaroll[i] = 1 + rand() % NUMBER_OF_SIDES; sum = 0; // Start the total sum at 0. for (i=0; i<u; i++) { sum+=charismaroll[i]; } Sleep(3000); cout<<"\nThe die rolls for charisma are: "; for(u=0; u < 4; u++) cout<<charismaroll[u]<<" "; cout <<"\nThe total of the charisma rolls is " <<sum; int smallchar; smallchar = 999999; for(i=1; i<u; i++) //check until condition i=n if(charismaroll[i] < smallchar) smallchar = charismaroll[i]; charisma = sum - smallchar; cout<<"\nSmallest value= "<<smallchar; cout<<"\n"<<charname<<"'s charisma is "<<charisma; strength, dexterity etc are declared earlier in the program. [edited by - unrealfragmaster on April 11, 2004 12:12:05 PM]

For Beginners

Started by unrealfragmaster April 11, 2004 11:10 AM

10 comments, last by unrealfragmaster 20 years ago

unrealfragmaster

122

Author

April 11, 2004 12:49 PM

Now I am getting low values such as 3, 4, 4, 5, 3, 7, when it should be values such as 10, 16, 11 etc, as its out of 18.

www.gameplayzone.com - Game news and reviews

SDickson

122

April 11, 2004 01:55 PM

You're getting low values because you have the braces in the wrong place in your rollDice() function body.

Here's a version that works properly:

int rollDice()   {     	const int NUMBER_OF_SIDES = 6;     	// Summate 4 dice rolls	int Roll[4];	int i, sum=0;	 	for(i=0; i<4; ++i)	 	{ 		Roll[i] = rand()%NUMBER_OF_SIDES + 1; 	 		sum += Roll[i];		}	// Find the smallest roll	int smallest=Roll[0];	 	for(i=1;i<4;++i)	 	{        		if(Roll[i] < smallest)		{			smallest = Roll[i];	 		}	}	 			// Subtract the smallest roll from the sum	sum -= smallest;     	return sum;	 }int main( ){	srand( (unsigned)time(NULL) );	int strength = rollDice();	int dexterity = rollDice();	int charisma = rollDice();	int intelligence = rollDice();	return 0;}

and here's a version that does away with the array allocation and the second loop looking for smallest:

unsigned int rollDice()   {     	const int NUMBER_OF_SIDES = 6;     	// Summate 4 dice rolls	unsigned int sum=0;	unsigned int smallest = NUMBER_OF_SIDES;	for( unsigned int i=0; i<4; i++)	 	{ 		unsigned int roll = rand() % NUMBER_OF_SIDES + 1;		sum += roll;		if ( roll < smallest )		{			smallest = roll;		}	}	//  Subtract the lowest roll	sum -= smallest;		return sum;	 }

[edited by - SDickson on April 11, 2004 3:06:27 PM]

Bug in dice rolling

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

Bug in dice rolling

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

Reticulating splines