I have written a simple terrain engine using a bitmap for the heightfield terrain. The terrain is fine but when it comes to the lighting the hills look blocky ,I think the polygon normals i am giving to glNormal3fv(I am using OpenGL) are wrong but i cant see where I have gone wrong. can you have a look .Here is the relevant code. Sorry for the mess #define TERRAIN_MAP_X 64 #define TERRAIN_MAP_Z 64 #define MAP_SCALE 20.0f float diffuseLight1[] = { 1.0f, 1.0f, 1.0f, 1.0f }; float specularLight1[] = { 1.0f, 1.0f, 1.0f, 1.0f }; float lightPosition1[] = { -550.0f, -250.0f, -150.0f, 1.0f }; float ambientLight1[]={ 1.0f, 1.0f, 1.0f, 1.0f }; void InitScene4(); void Scene4(); void GetFaceNormal(float *norm,float pointa[3],float pointb[3],float pointc[3]); void CrossProduct(float *c,float a[3],float b[3]); void Normalise(float *vect); float normals[5000][3];//normals for the faces of the terrain void InitTerrain() { terrainTex = new Texture; imageData = terrainTex->LoadBitmapFile("Terrain2.bmp",&bitmapInfoHeader); for(int z= 0;z<TERRAIN_MAP_Z;z++) { for(int x=0;x<TERRAIN_MAP_X;x++) { terrain[x][z][0] = float(x)*MAP_SCALE; terrain[x][z][1] = (float)(imageData[(z*TERRAIN_MAP_Z+x)*3]); terrain[x][z][2] = -float(z)*MAP_SCALE; } } } void InitScene4() { InitTerrain(); // LIGHT1 is the world light glLightfv(GL_LIGHT1, GL_DIFFUSE, diffuseLight1); glLightfv(GL_LIGHT1, GL_SPECULAR, specularLight1); glLightfv(GL_LIGHT1, GL_POSITION, lightPosition1); glLightfv(GL_LIGHT1, GL_AMBIENT, ambientLight1); } void Scene4() { static float count=0.0f,count2=0.0f; glPushMatrix(); glTranslatef(-550.0f,-250.0f,-150.0f+count); glEnable(GL_TEXTURE_2D); glEnable(GL_DEPTH_TEST); glEnable(GL_CULL_FACE); glFrontFace(GL_CCW); glEnable(GL_LIGHTING); // enable lighting // Enable the lights //glEnable(GL_LIGHT0); glEnable(GL_LIGHT1); glBindTexture(GL_TEXTURE_2D, textures[1].texID); //loop through all of the terrains data points for(int z=0;z<TERRAIN_MAP_Z-1;z++) { glBegin(GL_TRIANGLE_STRIP); for(int x=0;x<TERRAIN_MAP_X-1;x++) { GetFaceNormal(normals[x+x*z],terrain[x][z],terrain[x+1][z],terrain[x][z+1]); glNormal3fv(normals[x+x*z]); //draw vertex 0 glColor3f(terrain[x][z][1]/255.0f, terrain[x][z][1]/255.0f, terrain[x][z][1]/255.0f); glTexCoord2f(0.0,0.0); glVertex3f(terrain[x][z][0],terrain[x][z][1],terrain[x][z][2]); //draw vertex 1 glColor3f(terrain[x+1][z][1]/255.0f, terrain[x+1][z][1]/255.0f, terrain[x+1][z][1]/255.0f); glTexCoord2f(1.0,0.0); glVertex3f(terrain[x+1][z][0],terrain[x+1][z][1],terrain[x+1][z][2]); //draw vertex 2 glColor3f(terrain[x][z+1][1]/255.0f, terrain[x][z+1][1]/255.0f, terrain[x][z+1][1]/255.0f); glTexCoord2f(0.0,1.0); glVertex3f(terrain[x][z+1][0],terrain[x][z+1][1],terrain[x][z+1][2]); //draw vertex 3 glColor3f(terrain[x+1][z+1][1]/255.0f, terrain[x+1][z+1][1]/255.0f, terrain[x+1][z+1][1]/255.0f); glTexCoord2f(1.0,1.0); glVertex3f(terrain[x+1][z+1][0],terrain[x+1][z+1][1],terrain[x+1][z+1][2]); } } glEnd(); glPopMatrix(); glDisable(GL_DEPTH_TEST); count += 5.0f; count2 -= 1.0f; } void GetFaceNormal(float *norm,float pointa[3],float pointb[3],float pointc[3]) { float vect[2][3]; //two vectors &#111;n plane of quad int a,b; //counters float point[3][3]; //2 dimensional array for pointa pointb and pointc //put pointa pointb and pointc in the two dimensional array for(a=0;a<3;a++) { point[0]<A href='http:// = pointa[a]; point[1][a] = pointb[a]; point[2][a] = pointc[a]; } //now calculate the two vectors &#111;ne from point[0] to point[1] and &#111;ne from point[0] to point[2] for(a=0;a<2;a++) { for(b=0;b<3;b++) { vect[a]<b> = point[2-a] - point[0]; } } CrossProduct(norm,vect[0],vect[1]); //calculates vector at 90° to 2 vectors Normalise(norm); //makes the vector length 1 } void CrossProduct(float *c,float a[3],float b[3]) { //finds the cross product of two vectors c[0] = a[1]*b[2] - b[1]*a[2]; c[1] = a[2]*b[0] - b[2]*a[0]; c[2] = a[0]*b[1] - b[0]*a[1]; } void Normalise(float *vect) { float length; int a; length=sqrt( //A^2 + B^2 + C^2 = length^2 pow(vect[0],2)+ pow(vect[1],2)+ pow(vect[2],2) ); for(a=0;a<3;a++) { vect[a] /= length; //divides vector by its length to normalise } } </b> ' Target=_Blank>Link</a>

Could you please expand on that please jaba

thanks