Code feedback on blackjack game

popcorn · 2004-06-07T05:10:37

IDE: Dev-C++ - 4.9.8.7 Language: C I have finished writing a game of blackjack and would like some general feedback on the code - where I can improve it etc. One of the things I would like to do is to improve the output. I would like to be able to get more control over how things are displayed on the screen but I only have experience of using standard C library functions like printf and puts etc. So any advice here would be great. #include <stdio.h> #include <stdlib.h> #define MAXCARDS 52 #define MAXHAND 5 #define MAXSTRING 20 enum SUIT {diamond, club, heart, spade}; enum TYPE {ace, two, three, four, five, six, seven, eight, nine, ten, jack, queen, king}; //card structure struct CARD { enum SUIT suit; enum TYPE type; }; struct CARD deck[MAXCARDS];//global variable //player structure struct PLAYER { struct CARD hand[MAXHAND]; int numofcards; int playertotal; int stick; }; //function prototypes void flush(); //card functions void createDeck(); void shuffleCards(); void dealCard(struct PLAYER *, int *); int getCardValue(struct PLAYER, int); void displayHand(struct PLAYER); //game functions void initialise(struct PLAYER *, struct PLAYER *, int *); void userMenu(struct PLAYER *, int *); void dealerAI(struct PLAYER *, int *); void calculateHandTotal(struct PLAYER *); void decideWinner(struct PLAYER, struct PLAYER); int main(int argc, char *argv[]) { //seed the randam number function srand((unsigned)time(NULL)); int index = 0;//index into deck of cards char play; struct PLAYER dealer = {0}; struct PLAYER player = {0}; createDeck();//create a deck of cards initialise(&dealer, &player, &index);//first time initialisation do { do { if(player.stick == 0) { printf("Player Menu\n"); userMenu(&player, &index); printf("players hand\n"); displayHand(player); } if(dealer.stick == 0) { calculateHandTotal(&dealer); dealerAI(&dealer, &index); printf("dealers hand\n"); displayHand(dealer); } }while(dealer.stick == 0 || player.stick == 0); //calculate the dealers total calculateHandTotal(&dealer); //calculate the players total calculateHandTotal(&player); //decide a winner decideWinner(dealer, player); flush();//to get rid of any characters in the buffer left over from menu select printf("Deal again(y/n): "); scanf("%c", &play;; flush(); if(play == ''y'') initialise(&dealer, &player, &index); }while(play != ''n''); system("PAUSE"); return 0; } //function definitions //function for carraige return problem void flush() { char ch; while((ch = getchar()) != ''\n''); } //card function definitions //create a fresh deck of cards void createDeck() { enum SUIT i;//looping variable enum TYPE j;//looping variable int num = 0; for(i = diamond; i <= spade; i++) { for(j = ace; j <= king; j++) { deck[num].suit = i; deck[num].type = j; num++; } } } //shuffle cards void shuffleCards() { int i;//looping variable for(i = 0; i < 30; i++) { int num1 = rand() % MAXCARDS; int num2 = rand() % MAXCARDS; struct CARD temp;//swapping variable temp = deck[num1]; deck[num1] = deck[num2]; deck[num2] = temp; } } //deal a card void dealCard(struct PLAYER *player, int *index) { if(player->numofcards == 5) { printf("Maximum hand reached. Stick has been selected\n"); player->stick = 1; } else { player->hand[player->numofcards] = deck[*index]; (player->numofcards)++;//increment the number of cards the player has (*index)++;//increment the index } } int getCardValue(struct PLAYER player, int index) { int value; if(player.hand[index].type == ace || player.hand[index].type < ten) value = player.hand[index].type + 1; else value = 10; return value; } //Create the hand for the player to see void displayHand(struct PLAYER player) { char *pStringSuit[MAXHAND];//array of pointers to strings to hold the suit strings char *pStringType[MAXHAND];//array of pointers to strings to hold the type strings //suit string table char *pSuitName[] = {"Diamonds", "Clubs", "Hearts", "Spades"}; //type string table char *pTypeName[] = {"Ace", "Two", "Three", "Four", "Five", "Six", "Seven", "Eight", "Nine", "Ten", "Jack", "Queen", "King"}; int i;//looping variable //allocate memory for pointers to point to for(i = 0; i < player.numofcards; i++) { pStringSuit[i] = (char *) malloc(MAXSTRING); pStringType[i] = (char *) malloc(MAXSTRING); if( pStringSuit[i] == NULL ) printf("Could not allocate memory for pStringSuit\n"); if( pStringType[i] == NULL ) printf("Could not allocate memory for pStringType\n"); } //create the strings using an index into the appropriate string table for(i = 0; i < player.numofcards; i++) { //index to string table pStringSuit[i] = pSuitName[player.hand[i].suit]; pStringType[i] = pTypeName[player.hand[i].type]; } //display the cards to the player //display all the suits first for(i = 0; i < player.numofcards; i++) { printf("Suit:%s\t", pStringSuit[i]); } printf("\n"); //display the type of card for(i = 0; i < player.numofcards; i++) { printf("Type:%s\t", pStringType[i]); } printf("\n"); //free the memory for(i = 0; i < player.numofcards; i++) { free(pStringSuit[i]); printf("Memory freed for %d\n", i); free(pStringType[i]); printf("Memory freed for %d\n", i); } } //game function definitions //initialise the game void initialise(struct PLAYER *dealer, struct PLAYER *player, int *index) { shuffleCards();//shuffle the cards *index = 0; dealer->numofcards = 0; player->numofcards = 0; dealer->playertotal = 0; player->playertotal = 0; dealer->stick = 0; player->stick = 0; //deal first two cards to player and dealer dealCard(player, index); dealCard(dealer, index); dealCard(player, index); dealCard(dealer, index); //show the players hand displayHand(*player); } //twist or stick void userMenu(struct PLAYER *player, int *index) { int userchoice; int menu = 1; while(menu) { printf("1. Twist\n"); printf("2. Stick\n"); printf("Enter choice: "); scanf("%d", &userchoice); switch(userchoice) { case 1: dealCard(player, index); menu = 0; break; case 2: player->stick = 1; menu = 0; break; default: printf("Please select 1 or 2\n"); } } } //dealer AI void dealerAI(struct PLAYER *dealer, int *index) { if(dealer->playertotal <=16) { printf("Dealer takes another card\n"); dealCard(dealer, index); } else { printf("Dealer sticks\n"); dealer->stick = 1; } } //work out the total of a players hand void calculateHandTotal(struct PLAYER *player) { int i;//looping variable int hasAce = 0; player->playertotal = 0;//set player total back to zero for(i = 0; i < player->numofcards; i++) { if(player->hand[i].type == ace) hasAce = 1; player->playertotal = player->playertotal + getCardValue(*player, i); } //if the player has an ace and the conditions are right add another 10 to the playertotal if(hasAce && player->playertotal <= 11) player->playertotal = player->playertotal + 10; } //find a winner void decideWinner(struct PLAYER dealer, struct PLAYER player) { //display the total for each player printf("Dealers total is: %d\n", dealer.playertotal); printf("Your total is: %d\n", player.playertotal); //check to see if dealer is bust if(dealer.playertotal > 21) printf("Dealer is bust. You win.\n"); //check to see if player is bust if(player.playertotal > 21) printf("Dealer wins. You are bust.\n"); //if players are not bust, work out the winner if((dealer.playertotal > player.playertotal) && dealer.playertotal <= 21) printf("Dealer wins.\n"); else if((player.playertotal > dealer.playertotal) && player.playertotal <= 21) printf("You win.\n"); else if(dealer.playertotal == dealer.playertotal) printf("Dealer wins.\n"); } [\source] How about them apples?

For Beginners

Started by popcorn May 17, 2004 06:09 PM

20 comments, last by popcorn 19 years, 10 months ago

smart_idiot

1,298

June 07, 2004 02:09 AM

Could you use the <small> tag or something in your signature so it doesn''t look like it''s part of your post?

Chess is played by three people. Two people play the game; the third provides moral support for the pawns. The object of the game is to kill your opponent by flinging captured pieces at his head. Since the only piece that can be killed is a pawn, the two armies agree to meet in a pawn-infested area (or even a pawn shop) and kill as many pawns as possible in the crossfire. If the game goes on for an hour, one player may legally attempt to gouge out the other player's eyes with his King.

popcorn

151

Author

June 07, 2004 05:10 AM

quote:Could you use the tag or something in your signature so it doesn't look like it's part of your post?

Yeah I think I will change it. I've actually had people reply to my signature thinking that I was talking about apple macs or something.

[edited by - popcorn on June 7, 2004 6:10:37 AM]

How about them apples?

Code feedback on blackjack game

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

Code feedback on blackjack game

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

Reticulating splines