quote:Original post by Leanna
void Stack:ush(double item_to_push)
{
data[top_of_stack] = item_to_push;
top_of_stack++;
if (top_of_stack > SIZE)
cout << "Error \n";
}

getting closer. i apologize for not reading the entire thread, but if top_of_stack is the position of the actual item that is top_of_stack then you''ll want to increment top_of_stack _before_ you push the item_to_push onto the stack. if top_of_stack points to the first "empty" position at the top of the stack, ignore this:

think of it as a simple array and numbers.

say i have this:
int myArray[10];
myArray[o] = some_item;
int top_of_stack = 0; //top_of stack now "points" to some_item

if we go through your function now:
data[top_of_stack] = item_to_push;

at this point top_of_stack == 0, so you''ve put item_to_push into the zeroth position of the array. however, some_item was there, so you''ve now over-written it.

make sense? so increment top_of_stack _before_ you put the item into the array. you''ll want to do a check against SIZE between that increment and the actual insertion of the item_to_push.

hope this is all starting to make sense.

-me

Thank you for the help. I think I understand what you''re saying about the increment coming first. If the Push function is now correct, I will be needing help with the Pop function, and the others as well. I''ve tried writing the whole program, and it compiles without errors, however, when I run the program it''s not working correctly.
I''ll paste the whole thing below again.
Thank you again!
Leanna
#include <cstdlib>
#include <iostream>
using namespace std;

#define SIZE 6

class Stack
{
private:
double data[SIZE];
int top_of_stack;
public:
void Init();
void Push(double item_to_push);
double Pop();
};

void Stack::Init()
{
for (int k = 0; k < SIZE; k++)
data[k] = 0.0;

top_of_stack= 0;
}

void Stack:ush(double item_to_push)
{
top_of_stack++;
data[top_of_stack] = item_to_push;


if (top_of_stack > SIZE)
cout << "Error \n";
}

double Stack:op()
{
if (top_of_stack > 0)
top_of_stack--;

else cout<< "Error: Stack Empty \n";

}

int main()
{

Stack s1, s2;
int k;

s1.Init();
s2.Init();

cout << s1.Pop();

s1.Push(60);
s1.Push(50);
s1.Push(40);
s1.Push(30);
s1.Push(20);
s1.Push(10);

s2.Push(85);
s2.Push(75);
s2.Push(65);
s2.Push(55);
s2.Push(45);
s2.Push(35);

cout <<"\n--------------------First Stack----------------\n";
for (k=0; k<8; k++)
cout << s1.Pop() << endl;


cout <<"\n--------------------Second Stack----------------\n";
for (k=0; k<8; k++)
cout << s2.Pop() << endl;
system ("pause");
return 0;
}