Quote:
use sizeof() instead of strlen() for better results
Quote:Original post by Nurgle
strncpy(temp->filename, filename, strlen(temp->filename));
This completely destroys the possibility of a buffer overflow. In your code above, it's redundant, but still a good habit to get into.
If you find yourself not doing the right thing out of habit, you could always hack together a quick macro...
#define strcpy(dest, src) strncpy(dest, src, strlen(dest));
Quote:Original post by eyal
This really isn't a good idea. If you don't know what the destination buffer currently contains, you can't expect strlen to return its size. Nothing guarantees the buffer is null-terminated (and you can't do destBuffer[destSize-1] = '\0', since there might be a '\0' somewhere else in the buffer, in which case strlen will return a value smaller than the buffer's length).
See my second post
clicoder:
I wrote a small test app which does sizeof on a char[20], and it works fine (using gcc).
Quote:Original post by MichaelTQuote:Original post by Anonymous Poster
....which clearly is due to a bug.
I've tracked down the crashpoint to a location to a loop inside the the _crt.. function. ;) But thanks for the heads up.
Quote:Original post by siaspeteQuote:Original post by MichaelTQuote:Original post by Anonymous Poster
....which clearly is due to a bug.
I've tracked down the crashpoint to a location to a loop inside the the _crt.. function. ;) But thanks for the heads up.
No, it really is your fault. The crash in the CRT is because you're doing *something* wrong with memory.
Quote:Original post by siaspete
No, it really is your fault. The crash in the CRT is because you're doing *something* wrong with memory. Either writing to memory that doesn't belong to you, or overwriting the end of an array or something.
I know it seems strange that the crash is outside your code, but if the CRT was bugged so badly it would have been fixed by now.
Then again, you're using the latest VC6 service pack, right?
Quote:Original post by Wavewash
I can't tell exactly if this is the issue I had, but if the debugger is saying something along the lines of freed heap memory being written to at address. Then that probably means that siaspete is right about you going beyond an array bounds.
~Wave
Quote:Original post by MichaelT
The only message was that it could not read the memory location. I sincerely hope that I don't have a faulty memory chip though (hmmm, didn't think of that until now)
Quote:Original post by Nurgle
I wrote a small test app which does sizeof on a char[20], and it works fine (using gcc).
