# OpenGL Problem with smooth color shading

## Recommended Posts

Hi! I'm trying to create a simple skydome for my game. I am going to use vertex coloring to create a nice sky color that can be changed in realtime. My problem is that I don't get a smooth color transition between the vertices(not animation, ahven't come to that yet). Here's a screenshot to illustrate my problem: http://img82.exs.cx/my.php?loc=img82&image=DOME.jpg I use OpenGL and obviously have GL_SMOOTH set as shade model. The dome is drawn as a triangle strip from top to bottom in horisontal circles, not as vertical stripes. Maybe that has something to do with it? I don't know... Anyways, here's the code that I use and found at www.spheregames.com:
void CSky::CreateSkyDome()
{
int theta, phi;

//Allocate memory for the vertices
m_nrVertices = (int)((360/m_dTheta)*(90/m_dPhi)*4);
m_vertices = new Vector3D[m_nrVertices];

//Calculate and store the vertices
int n = 0;
for (phi=0; phi <= 90 - m_dPhi; phi += (int)m_dPhi)
{
for (theta=0; theta <= 360 - m_dTheta; theta += (int)m_dTheta)
{
n++;
n++;
n++;
if (phi > -90 && phi < 90)
{
n++;
}
}
}
}


phi is the latitude of the sphere and theta is the longitude(m_dPhi and m_dTheta between each "segment") And here's my code to draw the dome. I change the color of the vertices according to the y coordinate of each vertex. But as mentioned, I get the problem you see in the screenshot above.
void CSky::RenderSkyDome()
{
//Used to change the color
Vector3D tempVert(m_vertices[0]);
float color = 0;

//Draw the dome as a triangle strip
glBegin(GL_TRIANGLE_STRIP);
for (int i = 0; i < m_nrVertices; i++)
{
//Check to see if we should change the color
if (tempVert.y < m_vertices[i].y)
{
vert = m_vertices[i];
glColor3f(color, color, 1.0f);
color += 0.05f;
}

glVertex3f(m_vertices[i].x, m_vertices[i].y, m_vertices[i].z);
}
glEnd();
}


As I said, I found the code to generate the dome on the internet, and I don't fully understand it. But I would be glad if somebody could point out the problem and a solution. Thanks in advance William

##### Share on other sites
You say that you are using smooth shading, but for a sky dome, wouldn't you rather draw it with out any lighting?

##### Share on other sites
I don't use any lighting. It's the vertices colors I want interpolated between eachother. Therefore I use smooth shading, but I still don't get the result I want. Anybody know how to solve this? should I build the dome in some other way?

##### Share on other sites
I can't see your screen shot so it's hard to say what the problem is. Nothing obvious jumps out from the code you posted.

##### Share on other sites
Sorry for the broken image link...
Here's a screenshot:
http://img14.exs.cx/img14/2505/DOME.jpg

And as I mentioned in my first post, I have GL_SMOOTH set as shade model...

##### Share on other sites
i think i see the problem

looking at your code, as soon as you see a vertex in the strip that is higher up than the current highest Y, you consider it a new row and change the color

but this dome is made using triangle strips

which means, every other vertex alternates between the top and bottom edge of each horizontal band
(each band is a circular triangle strip)

thus, you end up with the same vertex color for both the top and bottom edges of each band, and when you smooth shade between 2 verts that are the same color, it looks flat

bottom line:
you need to rethink the way you decide to change colors, its happening at the wrong times

quick fix might be:
keep your current color detection code, but
try alternating between the new color and the last used color every other vertex, and the order matters, so try both ways

if you cant get that working, a less efficient but simpler way
is to just do a check on the Y value for every single vertex and set their color individually

and in the long term, you might consider using a vertex array
since the domecreate function is already outputting in array form....
that would mean having a color array in addition

##### Share on other sites
aww heck
here i'll write it for you
only takes a minute anyway

if this doesnt work try swapping the lines marked color band 1 and 2

void CSky::RenderSkyDome(){        //Used to change the color	Vector3D tempVert(m_vertices[0]);	float color = 0;float lastcolor=0;int swap=0;*/this is a swtich to toggle between top and bottom edge of each band*/        //Draw the dome as a triangle strip	glBegin(GL_TRIANGLE_STRIP);	for (int i = 0; i < m_nrVertices; i++)	{                //Check to see if we should change the color		if (tempVert.y < m_vertices[i].y)		{			vert = m_vertices[i];lastcolor=color;			color += 0.05f;		}if(swap){//color band 1                        glColor3f(color, color, 1.0f);}else{//color band 2                        glColor3f(lastcolor, lastcolor, 1.0f);}		glVertex3f(m_vertices[i].x, m_vertices[i].y, m_vertices[i].z);swap=swap^1;	}	glEnd();}

##### Share on other sites
Thanks for pointing that out haphazardlynamed! you were a great help!
I rewrote the function so that it uses the vertices y-coordinate directly to choose the color(glColor3f(yCoord, yCoord, 1) basically). Thanks for providing the code though!

I will probably switch to vertex arrays later, just wanted to get it working first.

## Create an account

Register a new account

• ### Forum Statistics

• Total Topics
628283
• Total Posts
2981823
• ### Similar Content

• By mellinoe
Hi all,
First time poster here, although I've been reading posts here for quite a while. This place has been invaluable for learning graphics programming -- thanks for a great resource!
Right now, I'm working on a graphics abstraction layer for .NET which supports D3D11, Vulkan, and OpenGL at the moment. I have implemented most of my planned features already, and things are working well. Some remaining features that I am planning are Compute Shaders, and some flavor of read-write shader resources. At the moment, my shaders can just get simple read-only access to a uniform (or constant) buffer, a texture, or a sampler. Unfortunately, I'm having a tough time grasping the distinctions between all of the different kinds of read-write resources that are available. In D3D alone, there seem to be 5 or 6 different kinds of resources with similar but different characteristics. On top of that, I get the impression that some of them are more or less "obsoleted" by the newer kinds, and don't have much of a place in modern code. There seem to be a few pivots:
The data source/destination (buffer or texture) Read-write or read-only Structured or unstructured (?) Ordered vs unordered (?) These are just my observations based on a lot of MSDN and OpenGL doc reading. For my library, I'm not interested in exposing every possibility to the user -- just trying to find a good "middle-ground" that can be represented cleanly across API's which is good enough for common scenarios.
Can anyone give a sort of "overview" of the different options, and perhaps compare/contrast the concepts between Direct3D, OpenGL, and Vulkan? I'd also be very interested in hearing how other folks have abstracted these concepts in their libraries.
• By aejt
I recently started getting into graphics programming (2nd try, first try was many years ago) and I'm working on a 3d rendering engine which I hope to be able to make a 3D game with sooner or later. I have plenty of C++ experience, but not a lot when it comes to graphics, and while it's definitely going much better this time, I'm having trouble figuring out how assets are usually handled by engines.
I'm not having trouble with handling the GPU resources, but more so with how the resources should be defined and used in the system (materials, models, etc).
This is my plan now, I've implemented most of it except for the XML parts and factories and those are the ones I'm not sure of at all:
I have these classes:
For GPU resources:
Geometry: holds and manages everything needed to render a geometry: VAO, VBO, EBO. Texture: holds and manages a texture which is loaded into the GPU. Shader: holds and manages a shader which is loaded into the GPU. For assets relying on GPU resources:
Material: holds a shader resource, multiple texture resources, as well as uniform settings. Mesh: holds a geometry and a material. Model: holds multiple meshes, possibly in a tree structure to more easily support skinning later on? For handling GPU resources:
ResourceCache<T>: T can be any resource loaded into the GPU. It owns these resources and only hands out handles to them on request (currently string identifiers are used when requesting handles, but all resources are stored in a vector and each handle only contains resource's index in that vector) Resource<T>: The handles given out from ResourceCache. The handles are reference counted and to get the underlying resource you simply deference like with pointers (*handle).
And my plan is to define everything into these XML documents to abstract away files:
Resources.xml for ref-counted GPU resources (geometry, shaders, textures) Resources are assigned names/ids and resource files, and possibly some attributes (what vertex attributes does this geometry have? what vertex attributes does this shader expect? what uniforms does this shader use? and so on) Are reference counted using ResourceCache<T> Assets.xml for assets using the GPU resources (materials, meshes, models) Assets are not reference counted, but they hold handles to ref-counted resources. References the resources defined in Resources.xml by names/ids. The XMLs are loaded into some structure in memory which is then used for loading the resources/assets using factory classes:
Factory classes for resources:
For example, a texture factory could contain the texture definitions from the XML containing data about textures in the game, as well as a cache containing all loaded textures. This means it has mappings from each name/id to a file and when asked to load a texture with a name/id, it can look up its path and use a "BinaryLoader" to either load the file and create the resource directly, or asynchronously load the file's data into a queue which then can be read from later to create the resources synchronously in the GL context. These factories only return handles.
Factory classes for assets:
Much like for resources, these classes contain the definitions for the assets they can load. For example, with the definition the MaterialFactory will know which shader, textures and possibly uniform a certain material has, and with the help of TextureFactory and ShaderFactory, it can retrieve handles to the resources it needs (Shader + Textures), setup itself from XML data (uniform values), and return a created instance of requested material. These factories return actual instances, not handles (but the instances contain handles).

Is this a good or commonly used approach? Is this going to bite me in the ass later on? Are there other more preferable approaches? Is this outside of the scope of a 3d renderer and should be on the engine side? I'd love to receive and kind of advice or suggestions!
Thanks!
• By nedondev
I 'm learning how to create game by using opengl with c/c++ coding, so here is my fist game. In video description also have game contain in Dropbox. May be I will make it better in future.
Thanks.

• So I've recently started learning some GLSL and now I'm toying with a POM shader. I'm trying to optimize it and notice that it starts having issues at high texture sizes, especially with self-shadowing.
Now I know POM is expensive either way, but would pulling the heightmap out of the normalmap alpha channel and in it's own 8bit texture make doing all those dozens of texture fetches more cheap? Or is everything in the cache aligned to 32bit anyway? I haven't implemented texture compression yet, I think that would help? But regardless, should there be a performance boost from decoupling the heightmap? I could also keep it in a lower resolution than the normalmap if that would improve performance.
Any help is much appreciated, please keep in mind I'm somewhat of a newbie. Thanks!

• Hi,
I'm trying to learn OpenGL through a website and have proceeded until this page of it. The output is a simple triangle. The problem is the complexity.
I have read that page several times and tried to analyse the code but I haven't understood the code properly and completely yet. This is the code: