• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
Licu

Pointer related bug in Angel Script 1.10 ?

4 posts in this topic

Hi, I've uploaded and tested the new 1.10 version in our engine and we've encountered a problem with global properties that are pointers to classes. I’ve registered a class with: engine->RegisterObjectType("class1", sizeof(Class1), asOBJ_CLASS); // or use asOBJ_GUESS After that registered a global property as a pointer to this class with: engine->RegisterGlobalProperty("class1 *pnt", &pnt); Registered a function member with: engine->RegisterObjectMethod("class1", "void function()", asFUNCTION(function), asCALL_CDECL_OBJFIRST); Trying to execute the function in the script gives me the following compilation error: No matching signatures to “function()” Illegal operation on this datatype Trying to use a member variable crashes the compilation. Here is a test application (constructed in your framework test): #include "utils.h" #define TESTNAME "TestGlobalObjectPointer" class Class1 { }; static void function(Class1 *_this) { } bool TestGlobalObjPointer() { bool fail = false; asIScriptEngine *engine = asCreateScriptEngine(ANGELSCRIPT_VERSION); engine->RegisterObjectType("class1", sizeof(Class1), asOBJ_CLASS); engine->RegisterObjectType("factory", 0, 0); // Register an object. Class1 obj; engine->RegisterGlobalProperty("class1 obj", &obj); // Register a pointer to object. Class1 *pnt = &obj; engine->RegisterGlobalProperty("class1 *pnt", &pnt); // Register class function. engine->RegisterObjectMethod("class1", "void function()", asFUNCTION(function), asCALL_CDECL_OBJFIRST); COutStream out; // Function call executed fine when using an object. int r = engine->ExecuteString(0, "obj.function();", &out); if( r < 0 ) { printf("%s: ExecuteString() failed %d\n", TESTNAME, r); fail = true; } // BUG??!! FUNCTION CALL WILL FAIL WHEN USING AN OBJECT POINTER. r = engine->ExecuteString(0, "pnt->function();", &out); if( r < 0 ) { printf("%s: ExecuteString() failed %d\n", TESTNAME, r); fail = true; } // WHEN USING A POINTER TO ACCESS A MEMBER VARIABLE COMPILING CRASHES. engine->Release(); return fail; } Now, probably this is related to previous discussions about removing pointers in Angel Script. If this is not a bug but rather a scripting aspect that is dropped, is it possible to do the same thing with references? Note that I’m not declaring any class objects in the script but rather all the engine interfaces are registered with the scripting engine as global properties. Regards, Adrian Licu Quad Software
0

Share this post


Link to post
Share on other sites
Pointers haven't been dropped yet, so this should work. You've probably encountered a bug. I will verify this during the day, and if the fix is simple I'll post it here.

Thanks for the test case, it should make it much easier to find the problem.

Regards,
Andreas

0

Share this post


Link to post
Share on other sites
I've found the bugs. They were caused by the changes that I made during the implementation of the native array.

The bug fixes are as follows:

In function asCCompiler::CompileExpressionPostOp() (as_compiler.cpp, line 3803):


void asCCompiler::CompileExpressionPostOp(asCScriptNode *node, asCByteCode *bc, sTypeInfo *type)
{
...

if( op == ttInc || op == ttDec )
{
...
}
else if( op == ttDot || op == ttArrow )
{
...

if( node->firstChild->nodeType == snIdentifier )
{
...

// Find the property offset and type
if( objType.tokenType == ttIdentifier )
{
// start FIX:
if( objType.pointerLevel )
{
// Convert to the type that is being pointed to
objType.pointerLevel = 0;
objType.objectType = objType.extendedType;
}
// end FIX
...
}
else
{
...
}
}
else
{
...

// Make sure it is an object we are accessing
if( type->dataType.tokenType != ttIdentifier && type->dataType.arrayDimensions == 0 )
{
...
}
else
{
// We need the pointer to the object
if( op == ttArrow && type->dataType.isReference )
bc->Instr(BC_RD4);

// start FIX:
asCObjectType *trueObj = type->dataType.objectType;
if( op == ttArrow )
trueObj = type->dataType.extendedType;
// end FIX:

sTypeInfo objType = *type;

// Compile function call
// FIX: changed the parameter
CompileFunctionCall(node->firstChild, bc, type, trueObj);

...
}
}
}
else if( op == ttOpenBracket )
{
...
}
}





0

Share this post


Link to post
Share on other sites
I also experienced similar pointer problems with 1.10.0, which seem to be fixed by the above changes. But here's a description of my problem in any case for reference.

AS code was as follows:

UIFont *medFont;
uint medFontHeight;

void onInit()
{
medFont = getFont("medium");
medFontHeight = medFont->getFontHeight();
// ...
}




Errors given: (call to method Build returns -1)
Info : Compiling void onInit()
Error : No matching signatures to 'getFontHeight()'
Error : Can't implicitly convert from 'const int' to 'uint&'.

The related source was declared with code snippets as follows:

// getFont declaration:

static UIFont * script_getFont(asBSTR *name)
{
return GameApp::getInstance()->getFont((char *)*name);
}

res = engine->RegisterGlobalFunction("UIFont * getFont(bstr &name)",
asFUNCTION(script_getFont), asCALL_CDECL);
// (verify res)

// ...

// UIFont & getFontHeight declaration:

const char *cl = "UIFont";
engine->RegisterObjectType(cl, sizeof(UIFont), asOBJ_CLASS);
res = engine->RegisterObjectMethod(cl, "uint getFontHeight()",
asMETHOD(UIFont, getFontHeight),
asCALL_THISCALL);
assert(res >= 0);


0

Share this post


Link to post
Share on other sites
Thanks for letting me know. You are describing the exact same problem.

The 1.10.1 WIP 1 (released earlier today) fixes the problem.


0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0