• Advertisement
Sign in to follow this  

OpenGL Need some pointers to my modification of Pauls Cel Shading program

This topic is 4801 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

Hello, For the last couple of days I've been trying to modify Pauls (as in www.paulsprojects.net) Cel Shading (the OpenGL version offcourse) example be able to handle multiple lights and colors (each light can have a diffrent color). So far I've managed to get the multiple lights working very good (just using the largest Dot product as the light to use), the shadows show very well and all. This is done the manual per Vertex lighting, not through ARB_vertex_program. Now, the colors are giving me a slight problem, mostly because I've never worked with Shaders before (not even this kind of shaders...). But the real problem is, they really are per vertex. And not smooth like the lighting. The most likly problem (or bottleneck) is that I'm assigning colors pretty much the same way as the vertexs. Namely through the use of a Color Array Pointer. Something else I would like to solve, is how to see if the vertex is occluded by something, so it doesn't get lit. And the last question is, how could I do something similar through a ARB_vertex_program shader (The one used under the button 2 of the program)? Thank you for your time, MLeoDaalder

Share this post


Link to post
Share on other sites
Advertisement
[looksaround]

So what's not clear about my post?

Am I the only one having this problem and is it increadibly easy and is considerd that everyone knows how to do this?


How should I post questions anyway so that I might get a respond?
Just for future questions?

Thank you,

MLeoDaalder

Share this post


Link to post
Share on other sites
i read your post a couple of times i still cant workout exactly what u want to do, perhaps a screenshot of what youve achieve sofar with a describtion of what u want to achieve

Share this post


Link to post
Share on other sites
Quote:
Original post by zedzeek
i read your post a couple of times i still cant workout exactly what u want to do, perhaps a screenshot of what youve achieve sofar with a describtion of what u want to achieve

Now that's what I call constructive! Thanks!

Ok, here is what I have:
These show that I have successfully implented multiple lights.
And a very crude lighted colors...
Cel Shading 1
Cel Shading 2


My goal is to make the colors fluid as well.
And to check for occlusion.
As shown in this picture there isn't any.
Cel Shading 3
It's most noticable in the inner ring of the torus.


Thank you for your interrest!

Share this post


Link to post
Share on other sites
im a bad explained but anyways

>>My goal is to make the colors fluid as well.<<

u mean the blockiness (staircase effect) in red on the second picture?, i believe this is caused by u saturating the color for that vertice once the color value has gone above 1.0 its not going any higher

>>And to check for occlusion.<<

thus u only want the light to affect pieces of the mesh that actually would recieve that light ie theyre not being blocked by other parts of the mesh, if thats the case then u need to look into shadowing techniques. ie if a pixel is in shadow then dont let that light contribute to its shading

Share this post


Link to post
Share on other sites
Quote:
Original post by zedzeek
im a bad explained but anyways

>>My goal is to make the colors fluid as well.<<

u mean the blockiness (staircase effect) in red on the second picture?, i believe this is caused by u saturating the color for that vertice once the color value has gone above 1.0 its not going any higher

In any of the colored parts.
The original color is r: 0.85, g: 0.75, b: 1.0
The upper left light has the color white.
The middle has the color: 1.0f, 0.0f, 0.5f
The upper right light has the color 1.0f, 1.0f, 0.0f

And this is my color/lighting part.

// Setting the initial color
for(int i=0;i<(torus.numVertices * 3);i+=3)
{
colorCoefficients[i ] = 0.95f;
colorCoefficients[i+1] = 0.75f;
colorCoefficients[i+2] = 1.0f;
//colorCoefficients = float((double)i / (double)(torus.numVertices * 3.0));
//0.75f, 0.95f, 1.0f
}
int z=0;
for(i=0; i<torus.numVertices; i++)
{
lightCoefficients = 0.0f;
for(int j=0; j<8; j++)
{
if(!(lightPositions[j].x == 0 && lightPositions[j].y == 0 && lightPositions[j].z == 0))
{
VECTOR3D lightDirection=(VECTOR3D(inverseModelMatrix*lightPositions[j])-torus.vertices.position).
GetNormalized();
if(torus.vertices.normal.DotProduct(lightDirection) > lightCoefficients)
{
lightCoefficients = torus.vertices.normal.DotProduct(lightDirection);
if(!(lightColors[j].x == 0 && lightColors[j].y == 0 && lightColors[j].z == 0))
{
//colorCoefficients[z ] += (float(lightColors[j].x) * torus.vertices.normal.DotProduct(lightDirection));
//colorCoefficients[z+1] += (float(lightColors[j].y) * torus.vertices.normal.DotProduct(lightDirection));
//colorCoefficients[z+2] += (float(lightColors[j].z) * torus.vertices.normal.DotProduct(lightDirection));
colorCoefficients[z ] += float(lightColors[j].x);
colorCoefficients[z+1] += float(lightColors[j].y);
colorCoefficients[z+2] += float(lightColors[j].z);
colorCoefficients[z ] /= 2.0f;
colorCoefficients[z+1] /= 2.0f;
colorCoefficients[z+2] /= 2.0f;
}
}
}
}
z += 3;
}



I tried to use the vector class (the dynamic array one), but something is wrong with it, so any light at 0,0,0 or a black light is not shown.

I know this isn't the best way... It's my first program trying to make my own light...

Quote:
>>And to check for occlusion.<<

thus u only want the light to affect pieces of the mesh that actually would recieve that light ie theyre not being blocked by other parts of the mesh, if thats the case then u need to look into shadowing techniques. ie if a pixel is in shadow then dont let that light contribute to its shading

Thanks for the pointer!

Share this post


Link to post
Share on other sites
Well, an update to the occlusion test...
I modified it from the Lensflare occlusion test (NeHe lesson 44).
And one thing I can say, it's killing my fps big time!
From about 85 to 20...
And it provides a completly occluded object...

But I also think this is a dual pass test.
Which means I will have to render the entire object for every light in the scene.

I suppose there isn't an better way?
Like a Vertex/Face Database?

[EDIT]
After some more fidling I got the framerate down to 0.20...
And for some reason I find this funny.
[grin]

And here is my occlusion test routine.
If I remove the glClear then I can see (sort of) what the light must see.


bool CheckShadow(TORUS* o, VECTOR3D* p, VECTOR3D* pos, VECTOR3D *dir)
{
glPushMatrix();
glLoadIdentity();

//draw torus
glDrawElements(GL_TRIANGLES, o->numIndices, GL_UNSIGNED_INT, o->indices);

// Translate to the light position
glTranslated(pos->x, pos->y, pos->z);
// Rotate to the light direction
glRotated(1.0f, dir->x, dir->y, dir->z);

GLint viewport[4]; //space for viewport data
GLdouble mvmatrix[16], projmatrix[16]; //space for transform matricex
GLdouble winx, winy, winz; //space for returned projected coords
GLdouble flareZ; //here we will store the transformed flare Z
GLfloat bufferZ; //here we will store the read Z from the buffer

glGetIntegerv (GL_VIEWPORT, viewport); //get actual viewport
glGetDoublev (GL_MODELVIEW_MATRIX, mvmatrix); //get actual model view matrix
glGetDoublev (GL_PROJECTION_MATRIX, projmatrix); //get actual projiection matrix

gluProject(p->x, p->y, p->z, mvmatrix, projmatrix, viewport, &winx, &winy, &winz);
flareZ = winz;

// we read back one pixel from th depth buffer (exactly where our flare should be drawn)
glReadPixels(winx, winy,1,1,GL_DEPTH_COMPONENT, GL_FLOAT, &bufferZ);

glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);

glLoadIdentity();

glPopMatrix();
if (bufferZ < flareZ)
return true;
else
return false;
}


And after some commenting stuff out I've found that glClear and glDrawElements are the things that slow it down.

[Edited by - mldaalder on November 27, 2004 9:38:01 AM]

Share this post


Link to post
Share on other sites
I've tried a couple of things for the shadow checking, but I haven't found it (yet)...
With it I mean a working method (not to speak of the FPS).


I also tried another implementation of the light colors.
I tried to use 3 1D textures. Representing Red, Green and Blue.
I thought of using multi texturing, but I figured out that they would cancel each other out because OpenGL fills in 0s for each missing component in glTexImage1D.

I've also tried 3D textures, but they didn't show up and (I calculated) to get a proper colors I'd have to use a texture with the size of:
256*256*256*3 = ~50MB.
Not a really good idea considering I have a 128MB Video card. :P

So any idea's for both of these 2 problems?
Or any basic ARB_fragment_program tutorials?

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
  • Advertisement
  • Popular Tags

  • Advertisement
  • Popular Now

  • Similar Content

    • By reenigne
      For those that don't know me. I am the individual who's two videos are listed here under setup for https://wiki.libsdl.org/Tutorials
      I also run grhmedia.com where I host the projects and code for the tutorials I have online.
      Recently, I received a notice from youtube they will be implementing their new policy in protecting video content as of which I won't be monetized till I meat there required number of viewers and views each month.

      Frankly, I'm pretty sick of youtube. I put up a video and someone else learns from it and puts up another video and because of the way youtube does their placement they end up with more views.
      Even guys that clearly post false information such as one individual who said GLEW 2.0 was broken because he didn't know how to compile it. He in short didn't know how to modify the script he used because he didn't understand make files and how the requirements of the compiler and library changes needed some different flags.

      At the end of the month when they implement this I will take down the content and host on my own server purely and it will be a paid system and or patreon. 

      I get my videos may be a bit dry, I generally figure people are there to learn how to do something and I rather not waste their time. 
      I used to also help people for free even those coming from the other videos. That won't be the case any more. I used to just take anyone emails and work with them my email is posted on the site.

      I don't expect to get the required number of subscribers in that time or increased views. Even if I did well it wouldn't take care of each reoccurring month.
      I figure this is simpler and I don't plan on putting some sort of exorbitant fee for a monthly subscription or the like.
      I was thinking on the lines of a few dollars 1,2, and 3 and the larger subscription gets you assistance with the content in the tutorials if needed that month.
      Maybe another fee if it is related but not directly in the content. 
      The fees would serve to cut down on the number of people who ask for help and maybe encourage some of the people to actually pay attention to what is said rather than do their own thing. That actually turns out to be 90% of the issues. I spent 6 hours helping one individual last week I must have asked him 20 times did you do exactly like I said in the video even pointed directly to the section. When he finally sent me a copy of the what he entered I knew then and there he had not. I circled it and I pointed out that wasn't what I said to do in the video. I didn't tell him what was wrong and how I knew that way he would go back and actually follow what it said to do. He then reported it worked. Yea, no kidding following directions works. But hey isn't alone and well its part of the learning process.

      So the point of this isn't to be a gripe session. I'm just looking for a bit of feed back. Do you think the fees are unreasonable?
      Should I keep the youtube channel and do just the fees with patreon or do you think locking the content to my site and require a subscription is an idea.

      I'm just looking at the fact it is unrealistic to think youtube/google will actually get stuff right or that youtube viewers will actually bother to start looking for more accurate videos. 
    • By Balma Alparisi
      i got error 1282 in my code.
      sf::ContextSettings settings; settings.majorVersion = 4; settings.minorVersion = 5; settings.attributeFlags = settings.Core; sf::Window window; window.create(sf::VideoMode(1600, 900), "Texture Unit Rectangle", sf::Style::Close, settings); window.setActive(true); window.setVerticalSyncEnabled(true); glewInit(); GLuint shaderProgram = createShaderProgram("FX/Rectangle.vss", "FX/Rectangle.fss"); float vertex[] = { -0.5f,0.5f,0.0f, 0.0f,0.0f, -0.5f,-0.5f,0.0f, 0.0f,1.0f, 0.5f,0.5f,0.0f, 1.0f,0.0f, 0.5,-0.5f,0.0f, 1.0f,1.0f, }; GLuint indices[] = { 0,1,2, 1,2,3, }; GLuint vao; glGenVertexArrays(1, &vao); glBindVertexArray(vao); GLuint vbo; glGenBuffers(1, &vbo); glBindBuffer(GL_ARRAY_BUFFER, vbo); glBufferData(GL_ARRAY_BUFFER, sizeof(vertex), vertex, GL_STATIC_DRAW); GLuint ebo; glGenBuffers(1, &ebo); glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, ebo); glBufferData(GL_ELEMENT_ARRAY_BUFFER, sizeof(indices), indices,GL_STATIC_DRAW); glVertexAttribPointer(0, 3, GL_FLOAT, false, sizeof(float) * 5, (void*)0); glEnableVertexAttribArray(0); glVertexAttribPointer(1, 2, GL_FLOAT, false, sizeof(float) * 5, (void*)(sizeof(float) * 3)); glEnableVertexAttribArray(1); GLuint texture[2]; glGenTextures(2, texture); glActiveTexture(GL_TEXTURE0); glBindTexture(GL_TEXTURE_2D, texture[0]); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR); sf::Image* imageOne = new sf::Image; bool isImageOneLoaded = imageOne->loadFromFile("Texture/container.jpg"); if (isImageOneLoaded) { glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, imageOne->getSize().x, imageOne->getSize().y, 0, GL_RGBA, GL_UNSIGNED_BYTE, imageOne->getPixelsPtr()); glGenerateMipmap(GL_TEXTURE_2D); } delete imageOne; glActiveTexture(GL_TEXTURE1); glBindTexture(GL_TEXTURE_2D, texture[1]); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR); sf::Image* imageTwo = new sf::Image; bool isImageTwoLoaded = imageTwo->loadFromFile("Texture/awesomeface.png"); if (isImageTwoLoaded) { glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, imageTwo->getSize().x, imageTwo->getSize().y, 0, GL_RGBA, GL_UNSIGNED_BYTE, imageTwo->getPixelsPtr()); glGenerateMipmap(GL_TEXTURE_2D); } delete imageTwo; glUniform1i(glGetUniformLocation(shaderProgram, "inTextureOne"), 0); glUniform1i(glGetUniformLocation(shaderProgram, "inTextureTwo"), 1); GLenum error = glGetError(); std::cout << error << std::endl; sf::Event event; bool isRunning = true; while (isRunning) { while (window.pollEvent(event)) { if (event.type == event.Closed) { isRunning = false; } } glClear(GL_COLOR_BUFFER_BIT); if (isImageOneLoaded && isImageTwoLoaded) { glActiveTexture(GL_TEXTURE0); glBindTexture(GL_TEXTURE_2D, texture[0]); glActiveTexture(GL_TEXTURE1); glBindTexture(GL_TEXTURE_2D, texture[1]); glUseProgram(shaderProgram); } glBindVertexArray(vao); glDrawElements(GL_TRIANGLES, 6, GL_UNSIGNED_INT, nullptr); glBindVertexArray(0); window.display(); } glDeleteVertexArrays(1, &vao); glDeleteBuffers(1, &vbo); glDeleteBuffers(1, &ebo); glDeleteProgram(shaderProgram); glDeleteTextures(2,texture); return 0; } and this is the vertex shader
      #version 450 core layout(location=0) in vec3 inPos; layout(location=1) in vec2 inTexCoord; out vec2 TexCoord; void main() { gl_Position=vec4(inPos,1.0); TexCoord=inTexCoord; } and the fragment shader
      #version 450 core in vec2 TexCoord; uniform sampler2D inTextureOne; uniform sampler2D inTextureTwo; out vec4 FragmentColor; void main() { FragmentColor=mix(texture(inTextureOne,TexCoord),texture(inTextureTwo,TexCoord),0.2); } I was expecting awesomeface.png on top of container.jpg

    • By khawk
      We've just released all of the source code for the NeHe OpenGL lessons on our Github page at https://github.com/gamedev-net/nehe-opengl. code - 43 total platforms, configurations, and languages are included.
      Now operated by GameDev.net, NeHe is located at http://nehe.gamedev.net where it has been a valuable resource for developers wanting to learn OpenGL and graphics programming.

      View full story
    • By TheChubu
      The Khronos™ Group, an open consortium of leading hardware and software companies, announces from the SIGGRAPH 2017 Conference the immediate public availability of the OpenGL® 4.6 specification. OpenGL 4.6 integrates the functionality of numerous ARB and EXT extensions created by Khronos members AMD, Intel, and NVIDIA into core, including the capability to ingest SPIR-V™ shaders.
      SPIR-V is a Khronos-defined standard intermediate language for parallel compute and graphics, which enables content creators to simplify their shader authoring and management pipelines while providing significant source shading language flexibility. OpenGL 4.6 adds support for ingesting SPIR-V shaders to the core specification, guaranteeing that SPIR-V shaders will be widely supported by OpenGL implementations.
      OpenGL 4.6 adds the functionality of these ARB extensions to OpenGL’s core specification:
      GL_ARB_gl_spirv and GL_ARB_spirv_extensions to standardize SPIR-V support for OpenGL GL_ARB_indirect_parameters and GL_ARB_shader_draw_parameters for reducing the CPU overhead associated with rendering batches of geometry GL_ARB_pipeline_statistics_query and GL_ARB_transform_feedback_overflow_querystandardize OpenGL support for features available in Direct3D GL_ARB_texture_filter_anisotropic (based on GL_EXT_texture_filter_anisotropic) brings previously IP encumbered functionality into OpenGL to improve the visual quality of textured scenes GL_ARB_polygon_offset_clamp (based on GL_EXT_polygon_offset_clamp) suppresses a common visual artifact known as a “light leak” associated with rendering shadows GL_ARB_shader_atomic_counter_ops and GL_ARB_shader_group_vote add shader intrinsics supported by all desktop vendors to improve functionality and performance GL_KHR_no_error reduces driver overhead by allowing the application to indicate that it expects error-free operation so errors need not be generated In addition to the above features being added to OpenGL 4.6, the following are being released as extensions:
      GL_KHR_parallel_shader_compile allows applications to launch multiple shader compile threads to improve shader compile throughput WGL_ARB_create_context_no_error and GXL_ARB_create_context_no_error allow no error contexts to be created with WGL or GLX that support the GL_KHR_no_error extension “I’m proud to announce OpenGL 4.6 as the most feature-rich version of OpenGL yet. We've brought together the most popular, widely-supported extensions into a new core specification to give OpenGL developers and end users an improved baseline feature set. This includes resolving previous intellectual property roadblocks to bringing anisotropic texture filtering and polygon offset clamping into the core specification to enable widespread implementation and usage,” said Piers Daniell, chair of the OpenGL Working Group at Khronos. “The OpenGL working group will continue to respond to market needs and work with GPU vendors to ensure OpenGL remains a viable and evolving graphics API for all its customers and users across many vital industries.“
      The OpenGL 4.6 specification can be found at https://khronos.org/registry/OpenGL/index_gl.php. The GLSL to SPIR-V compiler glslang has been updated with GLSL 4.60 support, and can be found at https://github.com/KhronosGroup/glslang.
      Sophisticated graphics applications will also benefit from a set of newly released extensions for both OpenGL and OpenGL ES to enable interoperability with Vulkan and Direct3D. These extensions are named:
      GL_EXT_memory_object GL_EXT_memory_object_fd GL_EXT_memory_object_win32 GL_EXT_semaphore GL_EXT_semaphore_fd GL_EXT_semaphore_win32 GL_EXT_win32_keyed_mutex They can be found at: https://khronos.org/registry/OpenGL/index_gl.php
      Industry Support for OpenGL 4.6
      “With OpenGL 4.6 our customers have an improved set of core features available on our full range of OpenGL 4.x capable GPUs. These features provide improved rendering quality, performance and functionality. As the graphics industry’s most popular API, we fully support OpenGL and will continue to work closely with the Khronos Group on the development of new OpenGL specifications and extensions for our customers. NVIDIA has released beta OpenGL 4.6 drivers today at https://developer.nvidia.com/opengl-driver so developers can use these new features right away,” said Bob Pette, vice president, Professional Graphics at NVIDIA.
      "OpenGL 4.6 will be the first OpenGL release where conformant open source implementations based on the Mesa project will be deliverable in a reasonable timeframe after release. The open sourcing of the OpenGL conformance test suite and ongoing work between Khronos and X.org will also allow for non-vendor led open source implementations to achieve conformance in the near future," said David Airlie, senior principal engineer at Red Hat, and developer on Mesa/X.org projects.

      View full story
    • By _OskaR
      Hi,
      I have an OpenGL application but without possibility to wite own shaders.
      I need to perform small VS modification - is possible to do it in an alternative way? Do we have apps or driver modifictions which will catch the shader sent to GPU and override it?
  • Advertisement