• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
crazy_andy

disableing menu items - mfc

7 posts in this topic

I have an MFC program with: CMenu menu1; menu1.LoadMenu(IDR_MENU1); SetMenu(&menu1); now this loads a menu perfectly fine. When I cleck file new (ID_FILE_NEW) I want to disable it, so it cant be pressed again. Im trying: menu1.EnableMenuItem(ID_FILE_NEW,MF_BYCOMAND|MF_GRAYED); now this returns -1 suggesting the menu item doesn't exist, but when I click on the new button in the resource editor, it says ID ID_FILE_NEW so what am I doing wrong? I have been googleing for ages but no success
0

Share this post


Link to post
Share on other sites
Try this:

CMenu* mmenu = GetMenu();
CMenu* submenu = mmenu->GetSubMenu(0);
submenu->EnableMenuItem(ID_FILE_NEW, MF_BYCOMMAND | MF_DISABLED | MF_GRAYED);
0

Share this post


Link to post
Share on other sites
nope, it just displayed the menu as normal.

here is my code:


class MFC_Tutorial_Window :public CFrameWnd
{
CMenu menu1; // dedines my menu
public:
HANDLE tThread;
MFC_Tutorial_Window()
{
Create(NULL,"Countdown - ALPHA V 0.2"); // creates window

menu1.LoadMenu(IDR_MENU1); // sets up menu
SetMenu(&menu1);
// UINT t = menu1.EnableMenuItem // here I want to grey out the new button.(ID_FILE_NEW,MF_BYCOMMAND|MF_GRAYED);
}


void OnClickNew(); // defines function for when the new button is clicked
void OnClickStatusT1();
void OnClickExitApp();
void OnClickAbout();
int OnCreate(LPCREATESTRUCT lpCreateStruct);
void OnClose();
DECLARE_MESSAGE_MAP() // sets up a message map, for message handling
};

0

Share this post


Link to post
Share on other sites
OK, ive still not had any luck, It just doesn't grey out. should I try creating the menu at runtime rather than as a resource?
0

Share this post


Link to post
Share on other sites
I haven't touched MFC in ages, but I think this is the cause. Before displaying a menu MFC updates each menu item automatically. If it's missing an ON_COMMAND entry in a message map somewhere the menu item is automatically disabled, otherwise it's automatically enabled. CWinApp might have an update handler for ID_FILE_NEW by default, which is what is enabling the menu again.

This page describes a way to disable this. In your constructor for MFC_Tutorial_Window try adding this:

MFC_Tutorial_Window()
{
m_bAutoMenuEnable = false;
}
Ideally you'd have a message map entry to handle ID_FILE_NEW, and then you could simply add ON_UPDATE_COMMAND_UI(ID_FILE_NEW, OnUpdateFileNew) and call pCmdUI->Enable(false) from OnUpdateFileNew(CCmdUI* pCmdUI). How does your message map look like?

Update: Fixed incorrect information.
0

Share this post


Link to post
Share on other sites
ok, I tried that but I'm getting an unresolved external. heres my message map


class MFC_Tutorial_Window :public CFrameWnd
{
CMenu menu1; // dedines my menu
public:
HANDLE tThread;
MFC_Tutorial_Window()
{
m_bAutoMenuEnable = false;
Create(NULL,"Countdown - ALPHA V 0.2"); // creates window

menu1.LoadMenu(IDR_MENU1); // sets up menu
SetMenu(&menu1);
// UINT t = menu1.EnableMenuItem(ID_FILE_NEW,MF_BYCOMMAND|MF_GRAYED);
}


void OnClickNew(); // defines function for when the new button is clicked
void OnClickStatusT1();
void OnClickExitApp();
void OnClickAbout();
int OnCreate(LPCREATESTRUCT lpCreateStruct);
void OnClose();
void OnUpdateFileNew(CCmdUI* pCmdUI);
DECLARE_MESSAGE_MAP() // sets up a message map, for message handling
};

BEGIN_MESSAGE_MAP( MFC_Tutorial_Window, CFrameWnd) // begining of message map
ON_WM_CREATE()
ON_WM_CLOSE()
ON_COMMAND(ID_FILE_NEW,OnClickNew) // when new is clicked do function OnClickNew()
ON_COMMAND(ID_HELP_ABOUT,OnClickAbout)
ON_COMMAND(ID_STATUS_TIMER1,OnClickStatusT1)
ON_COMMAND(IDEXIT,OnClickExitApp)
ON_UPDATE_COMMAND_UI(ID_FILE_NEW,OnUpdateFileNew) // unresolved external here
END_MESSAGE_MAP() // end of message map

void OnUpdateFileNew(CCmdUI* pCmdUI)
{
pCmdUI->Enable(false);
}

void MFC_Tutorial_Window::OnClickNew() // what to do when new is clicked
{
newDialog dlg; //defines dialog box
dlg.DoModal();
}
...

0

Share this post


Link to post
Share on other sites
Oh, I probably should've worded things clearer.

Solution 1: Add the m_bAutoMenuEnable line. I don't know if this works.

Solution 2: Add ON_UPDATE_COMMAND_UI, this is probably the preferred solution since it integrates into MFC's message map, command updating framework. Ahh I wrote out a bunch of stuff describing how to implement it. Turns out you're just missing one thing.


void OnUpdateFileNew(CCmdUI* pCmdUI)

// should be

void MFC_Tutorial_Window::OnUpdateFileNew(CCmdUI* pCmdUI)




Of course now you won't be able to click the ID_FILE_NEW menuitem since it'll always be disabled. If you want to disable it after one click, try this:


class MFC_Tutorial_Window : public CFrameWnd
{
bool m_bEnableFileNew;

MFC_Tutorial_Window()
{
m_bEnableFileNew = true;

// ...
}

// ...
}

void OnUpdateFileNew(CCmdUI* pCmdUI)
{
// the nice thing about this is that it'll also disable toolbar buttons that
// have an ID of ID_FILE_NEW
pCmdUI->Enable(m_bEnableFileNew);
}

void MFC_Tutorial_Window::OnClickNew()
{
// disable file new. next time the menu displays MFC will call OnUpdateFileNew,
// which will disable the menu item.
m_bEnableFileNew = false;

newDialog dlg;
dlg.DoModal();
}

// ...



0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0