• Advertisement
Sign in to follow this  

Unity [.net] First C# Program - GameDev Thread Saver

This topic is 4644 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

I've recently started taking a look at C# since it's been on my todo list for so long. And what better way to start learning it with other than making tools! This C# program is called Thread Saver and what it does is you give it an id of the GameDev.net thread you want to save, and it will save the entire thread, all pages, into one html file to your hard drive. Now you will have to look at the code to see everything I did. It is very brekable right now, but anything that does popup with specific threads could be fixed with more code. One of the major things that I added in was the resolving of all relative links to absolute links, so when you save the page, it looks like a gamedev page rather than what you get when you save it from your browser. Here's the complete source, since I have no reason to keep it closed. There are lots of room for improvements and modifications. If you uncomment out a lot of the stuff in the CombineGameDevThread function, then you will end up with a nice page that is print ready! Since there are a lot of slashes and tags the forum might eat, I will just post the file instead. Now for my C# questions/comments from making this: 1. Is the StreamReader.ReadToEnd(); function used in a good sense how I did it? Is there anything that would be faster? I tried using the StreamReader.Read function, but I could not figure out how to convert from a char[] to a string. 2. How do you convert from a char[] to a string? The .toString method returns simply System.char[] or whatever that string is for the object name. 3. Why, oh why do functions such as Replace, Insert, etc.. return the new string rather than modify the current! It took me so long to figure out that the new modified string is returned rather than the updated itself. I can see the logics, but darn, that was so confusing! 4. It took me a bit to figure out that .Find is really .IndexOf [headshake] 5. Other than that, does anyone see any improvements that I can make in terms of C# concepts? Ok thanks for any help/suggestions. As for the program, if you want to do some comparing, I saved the thread, Single Word Game, and my results were:
102 Pages
...
Operation time: 358.234 seconds
The final file is 7.962MB and takes quite a bit for FF to load [lol]. I plan to improve this a lot more, but for right now, I'm just learning the concepts. If there's anything you'd like to see in it, feel free to make a suggestion and I will write it down. - Drew

Share this post


Link to post
Share on other sites
Advertisement
Quote:
Original post by Drew_Benton
Now for my C# questions/comments from making this:

1. Is the StreamReader.ReadToEnd(); function used in a good sense how I did it? Is there anything that would be faster? I tried using the StreamReader.Read function, but I could not figure out how to convert from a char[] to a string.

2. How do you convert from a char[] to a string? The .toString method returns simply System.char[] or whatever that string is for the object name.

3. Why, oh why do functions such as Replace, Insert, etc.. return the new string rather than modify the current! It took me so long to figure out that the new modified string is returned rather than the updated itself. I can see the logics, but darn, that was so confusing!


I'm tired and about to crash, but here is a little help. Strings are immutable objects, meaning that they can't be changed once they are set. Since that is the case,, and function that returns a different string must make a new string. If you are modifying a string a lot, consider using its mutable cousin the StringBuilder. As far as converting char[] to a string, just pass the character array into the string constructor.

Share this post


Link to post
Share on other sites
Quote:
Original post by Drew_Benton
Now for my C# questions/comments from making this:

1. Is the StreamReader.ReadToEnd(); function used in a good sense how I did it? Is there anything that would be faster? I tried using the StreamReader.Read function, but I could not figure out how to convert from a char[] to a string.

Dunno, would have to read the code to know. [grin]
Quote:

2. How do you convert from a char[] to a string? The .toString method returns simply System.char[] or whatever that string is for the object name.

String constructor
Quote:

3. Why, oh why do functions such as Replace, Insert, etc.. return the new string rather than modify the current! It took me so long to figure out that the new modified string is returned rather than the updated itself. I can see the logics, but darn, that was so confusing!

strings are immutable, aka: they cannot change. Use StringBuilder/StringWriter/StringReader.
Quote:

4. It took me a bit to figure out that .Find is really .IndexOf [headshake]

lol, made sense to me.
Quote:

5. Other than that, does anyone see any improvements that I can make in terms of C# concepts?

Your naming scheme is inconsistant. Stop mixing cases of the method names. If you are going to use upper camel case, then stick with that, mixing lower and upper camel case (pascal case) just confuses things.

It's also not done in a very OO fashion. You might also want to look into the MS HTML processing stuff. You can use it to build a DOM of the pages, find hyperlinks, images, stylesheets. That information could be used to download a whole tree of the pages, based on the information. You are replicating a lot of code that's already been done.

Definantly need to use a StringBuilder, your current code is very....memory inneficient.

Share this post


Link to post
Share on other sites
If you're interested in efficiency, you might want to check out the CLR Profiler. An article on it is available here. The call graph view is interesting. It'll let you see what functions are taking up the most time.

Regarding your code itself, like Washu I'd recommend naming consistency. I'd also recommend following .NET naming conventions for even more consistency; I've always found it annoying when Java naming conventions sneak into .NET and vice versa. The link is quite in depth; you can find summaries through Google.

Share this post


Link to post
Share on other sites
Sorry guys for the late replies, I will be getting back to this thread in a week or so when I have my dev computer up again. It's broken now so I am working with an old celeron 633mhz. It's not that bad and Visual C# 2005 Beta > Visual Studio 2003 C# [wink]. I'll start reading all the replies and respond again soon. Thanks for all your time!

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
  • Advertisement
  • Popular Tags

  • Advertisement
  • Popular Now

  • Similar Content

    • By Florencia Sylvester Anelli
      Hi everyone! I've developed a game called The Last Dog (ZOMBIES + DOGS) and was wondering if you could give it a try in order for me to analyse your behaviour in analytics. Give it a shot! Please download it here: https://florsyl.wixsite.com/thelastdog2 and let me know if you detect any bugs. VIDEO.3gp
       

       
       
    • By Manuel Berger
      Hello fellow devs!
      Once again I started working on an 2D adventure game and right now I'm doing the character-movement/animation. I'm not a big math guy and I was happy about my solution, but soon I realized that it's flawed.
      My player has 5 walking-animations, mirrored for the left side: up, upright, right, downright, down. With the atan2 function I get the angle between player and destination. To get an index from 0 to 4, I divide PI by 5 and see how many times it goes into the player-destination angle.

      In Pseudo-Code:
      angle = atan2(destination.x - player.x, destination.y - player.y) //swapped y and x to get mirrored angle around the y axis
      index = (int) (angle / (PI / 5));
      PlayAnimation(index); //0 = up, 1 = up_right, 2 = right, 3 = down_right, 4 = down

      Besides the fact that when angle is equal to PI it produces an index of 5, this works like a charm. Or at least I thought so at first. When I tested it, I realized that the up and down animation is playing more often than the others, which is pretty logical, since they have double the angle.

      What I'm trying to achieve is something like this, but with equal angles, so that up and down has the same range as all other directions.

      I can't get my head around it. Any suggestions? Is the whole approach doomed?

      Thank you in advance for any input!
       
    • By devbyskc
      Hi Everyone,
      Like most here, I'm a newbie but have been dabbling with game development for a few years. I am currently working full-time overseas and learning the craft in my spare time. It's been a long but highly rewarding adventure. Much of my time has been spent working through tutorials. In all of them, as well as my own attempts at development, I used the audio files supplied by the tutorial author, or obtained from one of the numerous sites online. I am working solo, and will be for a while, so I don't want to get too wrapped up with any one skill set. Regarding audio, the files I've found and used are good for what I was doing at the time. However I would now like to try my hand at customizing the audio more. My game engine of choice is Unity and it has an audio mixer built in that I have experimented with following their tutorials. I have obtained a great book called Game Audio Development with Unity 5.x that I am working through. Half way through the book it introduces using FMOD to supplement the Unity Audio Mixer. Later in the book, the author introduces Reaper (a very popular DAW) as an external program to compose and mix music to be integrated with Unity. I did some research on DAWs and quickly became overwhelmed. Much of what I found was geared toward professional sound engineers and sound designers. I am in no way trying or even thinking about getting to that level. All I want to be able to do is take a music file, and tweak it some to get the sound I want for my game. I've played with Audacity as well, but it didn't seem to fit the bill. So that is why I am looking at a better quality DAW. Since being solo, I am also under a budget contraint. So of all the DAW software out there, I am considering Reaper or Presonus Studio One due to their pricing. My question is, is investing the time to learn about using a DAW to tweak a sound file worth it? Are there any solo developers currently using a DAW as part of their overall workflow? If so, which one? I've also come across Fabric which is a Unity plug-in that enhances the built-in audio mixer. Would that be a better alternative?
      I know this is long, and maybe I haven't communicated well in trying to be brief. But any advice from the gurus/vets would be greatly appreciated. I've leaned so much and had a lot of fun in the process. BTW, I am also a senior citizen (I cut my programming teeth back using punch cards and Structured Basic when it first came out). If anyone needs more clarification of what I am trying to accomplish please let me know.  Thanks in advance for any assistance/advice.
    • By Yosef BenSadon
      Hi , I was considering this start up http://adshir.com/, for investment and i would like a little bit of feedback on what the developers community think about the technology.
      So far what they have is a demo that runs in real time on a Tablet at over 60FPS, it runs locally on the  integrated GPU of the i7 . They have a 20 000 triangles  dinosaur that looks impressive,  better than anything i saw on a mobile device, with reflections and shadows looking very close to what they would look in the real world. They achieved this thanks to a  new algorithm of a rendering technique called Path tracing/Ray tracing, that  is very demanding and so far it is done mostly for static images.
      From what i checked around there is no real option for real time ray tracing (60 FPS on consumer devices). There was imagination technologies that were supposed to release a chip that supports real time ray tracing, but i did not found they had a product in the market or even if the technology is finished as their last demo  i found was with a PC.  The other one is OTOY with their brigade engine that is still not released and if i understand well is more a cloud solution than in hardware solution .
      Would there  be a sizable  interest in the developers community in having such a product as a plug-in for existing game engines?  How important  is Ray tracing to the  future of high end real time graphics?
    • By bryandalo
      Good day,

      I just wanted to share our casual game that is available for android.

      Description: Fight your way from the ravenous plant monster for survival through flips. The rules are simple, drag and release your phone screen. Improve your skills and show it to your friends with the games quirky ranks. Select an array of characters using the orb you acquire throughout the game.

      Download: https://play.google.com/store/apps/details?id=com.HellmodeGames.FlipEscape&hl=en
       
      Trailer: 
       
  • Advertisement