Sign in to follow this  
Mari_p

OpenGL dark regions in some parts of the mesh

Recommended Posts

Hi friends, I'm new in OpenGL. I loaded a .3ds model in my OpenGL code. There is no texture mapped on the model (only material color). The model contains thin triangles in some regions. The problem is that these regions are appearing darker... (as if I had applied a super smooth on the surface). In 3ds max the model doesn't show these dark regions. It seems a small shading problem... but I'm sure the normals were correctly calculated. Is there some OpenGL setting I should do to avoid that? Thanks in advance.

Share this post


Link to post
Share on other sites
OK friends, here is an image about the problem. The left model was exported as a 3ds file and it was rendered using OpenGL (notice the dark regions). The right model was exported as an x-file and it was rendered using Direct3D (no shading problem here).

models.jpg

Share this post


Link to post
Share on other sites
Most likely its a case of shoddy normals. Are you using normals supplied by the 3ds model? If not, make sure you're generating "good" normals. and finnally, show us your rendering code (more importantly your setup before you render)

cheers
-Dan

Share this post


Link to post
Share on other sites
Hi Ademan555, the rendering code is pratically the same than 3DS Loader shown in Game Tutorials site.


LFace face;

for (int k=0; k < GetMesh->GetFaceCount(); k++)
{
face = GetMesh->GetFace(k);

glBegin(GL_TRIANGLES);
glNormal3f(face.normals[0].x, face.normals[0].y, face.normals[0].z);
glVertex3f(face.vertices[0].x, face.vertices[0].y, face.vertices[0].z);

glNormal3f(face.normals[1].x, face.normals[1].y, face.normals[1].z);
glVertex3f(face.vertices[1].x, face.vertices[1].y, face.vertices[1].z);

glNormal3f(face.normals[2].x, face.normals[2].y, face.normals[2].z);
glVertex3f(face.vertices[2].x, face.vertices[2].y, face.vertices[2].z);
glEnd();
}


LFace is a structure containing vertices and normals data:

struct LVector3
{
float x;
float y;
float z;
};

struct LFace
{
LVector3 vertices[3];
LVector3 normals[3];
};


The function to calculate the normals is:

void LMesh::CalcNormals()
{
LVector3 vertex;
LVector3 normal;
int i, k, j;
if (m_vertexCount <= 0)
return;
m_normalCount = m_vertexCount;
m_normals = (LVector3*) malloc(m_vertexCount*sizeof(LVector3));

for (i=0; i<m_vertexCount; i++)
{
normal.x = 0.0f;
normal.y = 0.0f;
normal.z = 0.0f;
vertex = m_vertices[i];
// find all vertices with the same coords
for (k=0; k<m_vertexCount; k++)
{
if ((fabs(vertex.x - m_vertices[k].x) < 0.0000001f) &&
(fabs(vertex.y - m_vertices[k].y) < 0.0000001f) &&
(fabs(vertex.z - m_vertices[k].z) < 0.0000001f))
{
for (j=0; j<m_triangleCount; j++)
{
if ((m_triangles[j].a == (unsigned int)k) ||
(m_triangles[j].b == (unsigned int)k) ||
(m_triangles[j].c == (unsigned int)k))
{
LVector3 a, b, n;
a = SubtractVectors(m_vertices[m_triangles[j].b], m_vertices[m_triangles[j].a]);
b = SubtractVectors(m_vertices[m_triangles[j].b], m_vertices[m_triangles[j].c]);
n = CrossProduct(b, a);
n = NormalizeVector(n);
normal = AddVectors(normal, n);
}
}
}
}
m_normals[i] = NormalizeVector(normal);

}
}

Share this post


Link to post
Share on other sites
It looks like you're doing a basic vertex normal by averaging all incident face normals. This is fine for smooth meshes (eg. heightmaps) but for an object like this you actually want two discrete normals for certain verts (like those around the edges of the holes). Best option is to actually export and load those normals from your editor.

Alternativly, you need to add the concept of a 'crease angle'. This basically means if two incident normals are too dissimilar (ie. you think theres a crease in the mesh) you duplicate the vert and only use the normals that are similar. This is fairly standard so google should give you a suitable algorithm.

Share this post


Link to post
Share on other sites
Quote:
Original post by OrangyTang
Alternativly, you need to add the concept of a 'crease angle'. This basically means if two incident normals are too dissimilar (ie. you think theres a crease in the mesh) you duplicate the vert and only use the normals that are similar. This is fairly standard so google should give you a suitable algorithm.

This seems to be the case to me on the screenshot, the shading goes weird because the normals are smoothing faces which are pretty much at straight angle to one another, and consequently the renderer is trying to interpolate between 'in light' and 'in shadow' along what's really a single, flat polygon.

checking acos( dot_product( face_1_normal, face_2_normal )) if it's below defined threshold angle (in radians) would generally work from what i can see.

On side note, testing every vertex against every vertex to see if they share position isn't very fast... implementing some kind of hash_multimap which keeps references to the vertices, with vertex position being the map key... might speed things up a lot, the testing for each vertex would be then done against greatly reduced sub-range of the whole set.

Share this post


Link to post
Share on other sites
It looks like you used a boolean object in creating that model in 3d studio's, that can have some weird effects on meshes.

Besides that, try just calculating normals per face and rendering them that way instead of calculating per vertex.

It will give you more of the look you have on the .x file rather than the smoothed look you have in the 3ds file.

Share this post


Link to post
Share on other sites
Thanks folks,

I solved the problem by importing the normals from an x-file to my OpenGL code (I wrote a code to parse the x-file to OpenGL functions). I decided to use an x-file (instead of a .3ds file) because I am already familiarized with this file format.

Another reason why I decided to import normals instead of calculating them in the code is: Usually, it is more flexible to change the smooth level in the mesh editor (3ds max) than in the code.

Thank you very much again for the help.

Share this post


Link to post
Share on other sites
Quote:
Original post by Mari_p
Another reason why I decided to import normals instead of calculating them in the code is: Usually, it is more flexible to change the smooth level in the mesh editor (3ds max) than in the code.

True about the flexibility... that's why ideally for 3ds format you'd be reading the smoothing groups information stored in the file:
** Subchunks of 0x4000 - Object description Block
* Subchunks of 0x4100 - Triangular Polygon List
(..)
0x4150: Face Smoothing Group chunk.
stores: unsigned int * number of faces.
bits of the int indicate enabled smooth groups for this particular face.

... then during the check of vertices, instead of dot product of face normals, you do bitwise AND check: face_1_smoothgroup & face_2_smoothgroup ... if the result is non-zero it means faces share at least one smoothing group, and the normals for points they share should be smoothed.

The angle test on the other hand is good for other formats which make use of it, Lightwave files for example.

[edit] just for the heck of it, this thread gave me excuse to do small test how many vertex checks are done with different methods... the results for classic teapot with 5894 vertices (after unwelding):

* straight comparison (each vertex with each vertex): 34,739,236 tests
* 'smart' straight comparison (tested vertex and the target share their normals at once, vertices which already did it are skipped): 17,366,671 tests
* hash map, straight comparison: 118,354 tests
* 'smart' hash map, similar to method 2: 56,230 tests

from nearly 35 mil to 56 k... wish it's always possible to reduce workload like that :s

[Edited by - tolaris on June 12, 2005 10:22:35 AM]

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Announcements

  • Forum Statistics

    • Total Topics
      628305
    • Total Posts
      2981939
  • Similar Content

    • By mellinoe
      Hi all,
      First time poster here, although I've been reading posts here for quite a while. This place has been invaluable for learning graphics programming -- thanks for a great resource!
      Right now, I'm working on a graphics abstraction layer for .NET which supports D3D11, Vulkan, and OpenGL at the moment. I have implemented most of my planned features already, and things are working well. Some remaining features that I am planning are Compute Shaders, and some flavor of read-write shader resources. At the moment, my shaders can just get simple read-only access to a uniform (or constant) buffer, a texture, or a sampler. Unfortunately, I'm having a tough time grasping the distinctions between all of the different kinds of read-write resources that are available. In D3D alone, there seem to be 5 or 6 different kinds of resources with similar but different characteristics. On top of that, I get the impression that some of them are more or less "obsoleted" by the newer kinds, and don't have much of a place in modern code. There seem to be a few pivots:
      The data source/destination (buffer or texture) Read-write or read-only Structured or unstructured (?) Ordered vs unordered (?) These are just my observations based on a lot of MSDN and OpenGL doc reading. For my library, I'm not interested in exposing every possibility to the user -- just trying to find a good "middle-ground" that can be represented cleanly across API's which is good enough for common scenarios.
      Can anyone give a sort of "overview" of the different options, and perhaps compare/contrast the concepts between Direct3D, OpenGL, and Vulkan? I'd also be very interested in hearing how other folks have abstracted these concepts in their libraries.
    • By aejt
      I recently started getting into graphics programming (2nd try, first try was many years ago) and I'm working on a 3d rendering engine which I hope to be able to make a 3D game with sooner or later. I have plenty of C++ experience, but not a lot when it comes to graphics, and while it's definitely going much better this time, I'm having trouble figuring out how assets are usually handled by engines.
      I'm not having trouble with handling the GPU resources, but more so with how the resources should be defined and used in the system (materials, models, etc).
      This is my plan now, I've implemented most of it except for the XML parts and factories and those are the ones I'm not sure of at all:
      I have these classes:
      For GPU resources:
      Geometry: holds and manages everything needed to render a geometry: VAO, VBO, EBO. Texture: holds and manages a texture which is loaded into the GPU. Shader: holds and manages a shader which is loaded into the GPU. For assets relying on GPU resources:
      Material: holds a shader resource, multiple texture resources, as well as uniform settings. Mesh: holds a geometry and a material. Model: holds multiple meshes, possibly in a tree structure to more easily support skinning later on? For handling GPU resources:
      ResourceCache<T>: T can be any resource loaded into the GPU. It owns these resources and only hands out handles to them on request (currently string identifiers are used when requesting handles, but all resources are stored in a vector and each handle only contains resource's index in that vector) Resource<T>: The handles given out from ResourceCache. The handles are reference counted and to get the underlying resource you simply deference like with pointers (*handle).  
      And my plan is to define everything into these XML documents to abstract away files:
      Resources.xml for ref-counted GPU resources (geometry, shaders, textures) Resources are assigned names/ids and resource files, and possibly some attributes (what vertex attributes does this geometry have? what vertex attributes does this shader expect? what uniforms does this shader use? and so on) Are reference counted using ResourceCache<T> Assets.xml for assets using the GPU resources (materials, meshes, models) Assets are not reference counted, but they hold handles to ref-counted resources. References the resources defined in Resources.xml by names/ids. The XMLs are loaded into some structure in memory which is then used for loading the resources/assets using factory classes:
      Factory classes for resources:
      For example, a texture factory could contain the texture definitions from the XML containing data about textures in the game, as well as a cache containing all loaded textures. This means it has mappings from each name/id to a file and when asked to load a texture with a name/id, it can look up its path and use a "BinaryLoader" to either load the file and create the resource directly, or asynchronously load the file's data into a queue which then can be read from later to create the resources synchronously in the GL context. These factories only return handles.
      Factory classes for assets:
      Much like for resources, these classes contain the definitions for the assets they can load. For example, with the definition the MaterialFactory will know which shader, textures and possibly uniform a certain material has, and with the help of TextureFactory and ShaderFactory, it can retrieve handles to the resources it needs (Shader + Textures), setup itself from XML data (uniform values), and return a created instance of requested material. These factories return actual instances, not handles (but the instances contain handles).
       
       
      Is this a good or commonly used approach? Is this going to bite me in the ass later on? Are there other more preferable approaches? Is this outside of the scope of a 3d renderer and should be on the engine side? I'd love to receive and kind of advice or suggestions!
      Thanks!
    • By nedondev
      I 'm learning how to create game by using opengl with c/c++ coding, so here is my fist game. In video description also have game contain in Dropbox. May be I will make it better in future.
      Thanks.
    • By Abecederia
      So I've recently started learning some GLSL and now I'm toying with a POM shader. I'm trying to optimize it and notice that it starts having issues at high texture sizes, especially with self-shadowing.
      Now I know POM is expensive either way, but would pulling the heightmap out of the normalmap alpha channel and in it's own 8bit texture make doing all those dozens of texture fetches more cheap? Or is everything in the cache aligned to 32bit anyway? I haven't implemented texture compression yet, I think that would help? But regardless, should there be a performance boost from decoupling the heightmap? I could also keep it in a lower resolution than the normalmap if that would improve performance.
      Any help is much appreciated, please keep in mind I'm somewhat of a newbie. Thanks!
    • By test opty
      Hi,
      I'm trying to learn OpenGL through a website and have proceeded until this page of it. The output is a simple triangle. The problem is the complexity.
      I have read that page several times and tried to analyse the code but I haven't understood the code properly and completely yet. This is the code:
       
      #include <glad/glad.h> #include <GLFW/glfw3.h> #include <C:\Users\Abbasi\Desktop\std_lib_facilities_4.h> using namespace std; //****************************************************************************** void framebuffer_size_callback(GLFWwindow* window, int width, int height); void processInput(GLFWwindow *window); // settings const unsigned int SCR_WIDTH = 800; const unsigned int SCR_HEIGHT = 600; const char *vertexShaderSource = "#version 330 core\n" "layout (location = 0) in vec3 aPos;\n" "void main()\n" "{\n" " gl_Position = vec4(aPos.x, aPos.y, aPos.z, 1.0);\n" "}\0"; const char *fragmentShaderSource = "#version 330 core\n" "out vec4 FragColor;\n" "void main()\n" "{\n" " FragColor = vec4(1.0f, 0.5f, 0.2f, 1.0f);\n" "}\n\0"; //******************************* int main() { // glfw: initialize and configure // ------------------------------ glfwInit(); glfwWindowHint(GLFW_CONTEXT_VERSION_MAJOR, 3); glfwWindowHint(GLFW_CONTEXT_VERSION_MINOR, 3); glfwWindowHint(GLFW_OPENGL_PROFILE, GLFW_OPENGL_CORE_PROFILE); // glfw window creation GLFWwindow* window = glfwCreateWindow(SCR_WIDTH, SCR_HEIGHT, "My First Triangle", nullptr, nullptr); if (window == nullptr) { cout << "Failed to create GLFW window" << endl; glfwTerminate(); return -1; } glfwMakeContextCurrent(window); glfwSetFramebufferSizeCallback(window, framebuffer_size_callback); // glad: load all OpenGL function pointers if (!gladLoadGLLoader((GLADloadproc)glfwGetProcAddress)) { cout << "Failed to initialize GLAD" << endl; return -1; } // build and compile our shader program // vertex shader int vertexShader = glCreateShader(GL_VERTEX_SHADER); glShaderSource(vertexShader, 1, &vertexShaderSource, nullptr); glCompileShader(vertexShader); // check for shader compile errors int success; char infoLog[512]; glGetShaderiv(vertexShader, GL_COMPILE_STATUS, &success); if (!success) { glGetShaderInfoLog(vertexShader, 512, nullptr, infoLog); cout << "ERROR::SHADER::VERTEX::COMPILATION_FAILED\n" << infoLog << endl; } // fragment shader int fragmentShader = glCreateShader(GL_FRAGMENT_SHADER); glShaderSource(fragmentShader, 1, &fragmentShaderSource, nullptr); glCompileShader(fragmentShader); // check for shader compile errors glGetShaderiv(fragmentShader, GL_COMPILE_STATUS, &success); if (!success) { glGetShaderInfoLog(fragmentShader, 512, nullptr, infoLog); cout << "ERROR::SHADER::FRAGMENT::COMPILATION_FAILED\n" << infoLog << endl; } // link shaders int shaderProgram = glCreateProgram(); glAttachShader(shaderProgram, vertexShader); glAttachShader(shaderProgram, fragmentShader); glLinkProgram(shaderProgram); // check for linking errors glGetProgramiv(shaderProgram, GL_LINK_STATUS, &success); if (!success) { glGetProgramInfoLog(shaderProgram, 512, nullptr, infoLog); cout << "ERROR::SHADER::PROGRAM::LINKING_FAILED\n" << infoLog << endl; } glDeleteShader(vertexShader); glDeleteShader(fragmentShader); // set up vertex data (and buffer(s)) and configure vertex attributes float vertices[] = { -0.5f, -0.5f, 0.0f, // left 0.5f, -0.5f, 0.0f, // right 0.0f, 0.5f, 0.0f // top }; unsigned int VBO, VAO; glGenVertexArrays(1, &VAO); glGenBuffers(1, &VBO); // bind the Vertex Array Object first, then bind and set vertex buffer(s), //and then configure vertex attributes(s). glBindVertexArray(VAO); glBindBuffer(GL_ARRAY_BUFFER, VBO); glBufferData(GL_ARRAY_BUFFER, sizeof(vertices), vertices, GL_STATIC_DRAW); glVertexAttribPointer(0, 3, GL_FLOAT, GL_FALSE, 3 * sizeof(float), (void*)0); glEnableVertexAttribArray(0); // note that this is allowed, the call to glVertexAttribPointer registered VBO // as the vertex attribute's bound vertex buffer object so afterwards we can safely unbind glBindBuffer(GL_ARRAY_BUFFER, 0); // You can unbind the VAO afterwards so other VAO calls won't accidentally // modify this VAO, but this rarely happens. Modifying other // VAOs requires a call to glBindVertexArray anyways so we generally don't unbind // VAOs (nor VBOs) when it's not directly necessary. glBindVertexArray(0); // uncomment this call to draw in wireframe polygons. //glPolygonMode(GL_FRONT_AND_BACK, GL_LINE); // render loop while (!glfwWindowShouldClose(window)) { // input // ----- processInput(window); // render // ------ glClearColor(0.2f, 0.3f, 0.3f, 1.0f); glClear(GL_COLOR_BUFFER_BIT); // draw our first triangle glUseProgram(shaderProgram); glBindVertexArray(VAO); // seeing as we only have a single VAO there's no need to // bind it every time, but we'll do so to keep things a bit more organized glDrawArrays(GL_TRIANGLES, 0, 3); // glBindVertexArray(0); // no need to unbind it every time // glfw: swap buffers and poll IO events (keys pressed/released, mouse moved etc.) glfwSwapBuffers(window); glfwPollEvents(); } // optional: de-allocate all resources once they've outlived their purpose: glDeleteVertexArrays(1, &VAO); glDeleteBuffers(1, &VBO); // glfw: terminate, clearing all previously allocated GLFW resources. glfwTerminate(); return 0; } //************************************************** // process all input: query GLFW whether relevant keys are pressed/released // this frame and react accordingly void processInput(GLFWwindow *window) { if (glfwGetKey(window, GLFW_KEY_ESCAPE) == GLFW_PRESS) glfwSetWindowShouldClose(window, true); } //******************************************************************** // glfw: whenever the window size changed (by OS or user resize) this callback function executes void framebuffer_size_callback(GLFWwindow* window, int width, int height) { // make sure the viewport matches the new window dimensions; note that width and // height will be significantly larger than specified on retina displays. glViewport(0, 0, width, height); } As you see, about 200 lines of complicated code only for a simple triangle. 
      I don't know what parts are necessary for that output. And also, what the correct order of instructions for such an output or programs is, generally. That start point is too complex for a beginner of OpenGL like me and I don't know how to make the issue solved. What are your ideas please? What is the way to figure both the code and the whole program out correctly please?
      I wish I'd read a reference that would teach me OpenGL through a step-by-step method. 
  • Popular Now