Back to General and Gameplay Programming

which is better?

General and Gameplay Programming Programming

Started by utilae June 11, 2005 10:55 PM

18 comments, last by GameDev.net 18 years, 10 months ago

utilae

188

Author

June 11, 2005 10:55 PM

Which is better? This:


if(X=="A" && Y==1)
   ;//do stuff
else if(X=="A" && Y==2)
   ;//do stuff
else if(X=="B" && Y==1)
   ;//do stuff
else if(X=="B" && Y==2)
   ;//do stuff

Or this:


if(X=="A")
{
   if(Y==1)
      ;//do stuff
   else if(Y==2)
      ;//do stuff
}
else if(X=="B")
{
   if(Y==1)
      ;//do stuff
   else if(Y==2)
      ;//do stuff
}

HTML5, iOS and Android Game Development using Corona SDK and moai SDK

Alpha_ProgDes

6,963

June 11, 2005 10:56 PM

i like the second one better, but functionally they're the same.

Beginner in Game Development? Read here. And read here.

x_gamer_x

136

June 11, 2005 11:01 PM

#2, less comparisons.

-------------------------Rayoom Sledge Hammer Productions - Programmer

Catafriggm

296

June 11, 2005 11:18 PM

2 is better, because it has less comparisons, but if the compiler's halfway intelligent, it'll generate the same code either way.

Q and Stuff

Way Walker

745

June 12, 2005 12:52 AM

Quote:Original post by Catafriggm
2 is better, because it has less comparisons, but if the compiler's halfway intelligent, it'll generate the same code either way.

And, because of this, you should choose whichever better describes the intent. For instance, if X can be "A", "B", or "C", then the first is probably clearer. If Y can be 1, 2, or 3, then the first is probably clearer. (If it turns out that the compiler doesn't optimize it and profiling shows that this is a bottle neck, then switch it) If X and Y are limited to the values shown, then the second is probably clearer.

Deranged

668

June 12, 2005 12:55 AM

#2, just looks cleaner.

stroma

218

June 12, 2005 01:13 AM

second one. but if it grows up i would use switch function for them, if, elif... doesnt looks good

+-+-+-+-+-STR

Way Walker

745

June 12, 2005 01:17 AM

Quote:Original post by DerAnged
#2, just looks cleaner.

Really? I like the looks of #1 better. Symmetry and all. However, #2 may be more descriptive of the logic.

By the way, if this is X is a char *, you don't want to be using == to compare strings, you want strcmp(). If X is a char, you want single quotes (') around the character. If X is a C++ stirng, never mind. But you all probably knew all that (and it's just an example).

wendigo23

512

June 12, 2005 01:34 AM

I say it depends on how the variables are related. Either case may present a more readable solution in different situations. If Y is like a sub-case of X, I'd go with style 2. If they are completely unrelated variables that just happen to control the same logic, I might go with style 1.

iMalc

2,466

June 12, 2005 02:53 AM

Depending on how much there is in common between the cases, use either your option 2, or the equivalent refracted code below.

if(Y==1)   {   if(X=="A")         ;//do stuff   else if(X=="B")         ;//do stuff   }else if(Y==2)   {   if(X=="A")         ;//do stuff   else if(X=="B")         ;//do stuff   }

Also if X can only be "A" or "B" then

else if(X=="B")

could simply be an else. Ditto goes for Y. You'd of course perhaps use an assert, to ensure it was never any other value.
The prettiness of option 1 will wear off you expand it any furthur.

"In order to understand recursion, you must first understand recursion."
My website dedicated to sorting algorithms

which is better?

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

which is better?

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

Reticulating splines