Sign in to follow this  
gp343

OpenGL Loading Texture

Recommended Posts

gp343    101
Hi there, I'm a newbie to Opengl programming and am currently trying to work with texture mapping. Now i'm trying to build a function to load a texture from a bitmap as the below code shows. However the texture is not loading at all my box is drawn but without any texture. Can somebody please take a look and point out what i'm doing wrong, as i've been working on this piece of code for 2 day. #include <windows.h> ##include <stdio.h> #include <stdlib.h> #include <math.h> #include <gl\gl.h> #include <gl\glu.h> #include <gl\glaux.h> GLuint texture; int LoadGLBitmap(const char*, LONG*, LONG*, GLubyte*); int LoadTexture(const char*, GLuint*); int InitGL(GLvoid) { glEnable(GL_TEXTURE_2D); LoadTexture("C:\\wood02.bmp", &texture); DrawBox() return TRUE; } int LoadGLBitmap(const char* FileName, LONG *Width, LONG *Height, GLubyte* pData) { ////// Defines #define BITMAP_ID 0x4D42 // the universal bitmap ID FILE *filePtr; BITMAPINFOHEADER InfoHeader; BITMAPFILEHEADER FileHeader; int imageIdx = 0; // image index counter unsigned chartempRGB; // swap variable // open filename in "read binary" mode filePtr = fopen(FileName, "rb"); if (filePtr == NULL) return NULL; // read the bitmap file header fread(&FileHeader, sizeof(BITMAPFILEHEADER), 1, filePtr); // verify that this is a bitmap by checking for the universal bitmap id if (FileHeader.bfType != BITMAP_ID) { fclose(filePtr); return NULL; } // read the bitmap information header fread(&InfoHeader, sizeof(BITMAPINFOHEADER), 1, filePtr); // move file pointer to beginning of bitmap data fseek(filePtr, FileHeader.bfOffBits, SEEK_SET); // allocate enough memory for the bitmap image data pData = (unsigned char*)malloc(InfoHeader.biSizeImage); // verify memory allocation if (!pData) { free(pData); fclose(filePtr); return NULL; } // read in the bitmap image data fread(pData, 1, InfoHeader.biSizeImage, filePtr); // make sure bitmap image data was read if (pData == NULL) { fclose(filePtr); return NULL; } // swap the R and B values to get RGB since the bitmap color format is in BGR for (imageIdx = 0; imageIdx < InfoHeader.biSizeImage; imageIdx+=3) { tempRGB = pData[imageIdx]; pData[imageIdx] = pData[imageIdx + 2]; pData[imageIdx + 2] = tempRGB; } // close the file and return the bitmap image data fclose(filePtr); *Width = InfoHeader.biWidth; *Height = InfoHeader.biHeight; return TRUE; }// End of LoadGLBitmap Function int LoadTexture(const char* Filename, GLuint* Texture) { LONG Width; LONG Height; GLubyte *pmsData=0; if(!LoadGLBitmap(Filename, &Width, &Height, pmsData)) { MessageBox(NULL,"Unable to Load Texture!","SHUTDOWN ERROR",MB_OK | MB_ICONINFORMATION); return 0; } glGenTextures(1, Texture); glBindTexture(GL_TEXTURE_2D, *Texture); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST); // generate the texture image glTexImage2D(GL_TEXTURE_2D, 0, GL_RGB, Width, Height, 0, GL_RGB, GL_UNSIGNED_BYTE, pmsData); free(pmsData); return 1; }// End of LoadTexture Function glEnable(GL_TEXTURE_2D); LoadTexture("C:\\wood02.bmp", &texture);

Share this post


Link to post
Share on other sites
steven katic    275
Hi, I do not know if this will solve your problem: but I do see something
you should correct:

The third parameter (components) you pass to glTexImage2D() can only be 1, 2, 3 or 4(not GL_RGB).

typically you can get this value by dividing the bits per pixel (bpp) value by
the number of bits per component->

and, typically for a 24 bit bmp you would have 24/8 = 3:
That is 3 components.

so put 3 in there and see how you go.

Share this post


Link to post
Share on other sites
_the_phantom_    11250
I'm afraid to say steven katic that you are infact wrong.
The third parameter of glTexImage() is infact the internal format flag, which has many different values which can be placed there, GL_RGB and GL_RGBA being the most common.
Now, you might have ment the 7th paramter, which indeed indictes the format of the incoming data, however this is a GLenum type and thus it is perfectly valid to use GL_RGB, GL_RGBA or any other valid enum value in that place.

This is why out of data tutorials should be burned from the internet as we know it [grin]

anyways, gp343, is your texture size a power-of-two in both dimentions? (ie 16x16, 32x16, 256x256 etc?)

also, the glaux library is out dated and as close to pure evil as you can get, you'll be wanting to find something else to load textures with (infact, gimmie 10mins and I'll add some links to the FAQ [grin])

Share this post


Link to post
Share on other sites
steven katic    275
Thankyou _The_Phantom_ for the correction.
Sorry I did reference old documentation for that information. Naughty me.

Speaking of using something else to load textures:

From a practical point of view I do not have any problems using

gluBuild2DMipmaps() function. What do you think phantom?

Share this post


Link to post
Share on other sites
_the_phantom_    11250
Nowt wrong with using it, however I favour just turning on automatic mipmap generation before uploading the base texture image and let the hardware sort it out (GL_SGIS_generate_mipmap being the extension in question) or using the FBO GenerateMipmap() function.

These should both give you the same result as using the glu function, possibly a little faster, if you need todo any complex mipmap generation you'd be better off doing it yaself anyways.

Share this post


Link to post
Share on other sites
gp343    101
All i'm trying to achieved with the previous posted code is to apply a texture to a simple QUAD. That is all. I wanted to code to be as Loosely Couple as possible. Most of the previous codes i've seen uses Global BITMAPINFOHEADER, BITMAPFILEHEADER structures, which does not follow the Loosely Couple-Highly Cohesive principles.

Regards

James (GP343)

Share this post


Link to post
Share on other sites
gp343    101
I'm sorry, but not yet, i'm still trying to load the texture onto a Quad.
I'm dereferencing all of my pointers correctly, i just can't see why this isn;t working.

Share this post


Link to post
Share on other sites
gp343    101
Yes, my texture is a power of two in both direction. I solved the problem anyway by re-arranging the code a bit.

All i did was to Re-defined the signature of the "LoadGLBitmap" function from:
int LoadGLBitmap(const char*, LONG*, LONG*, GLubyte*);

To:
GLubyte* LoadGLBitmap(const char* FileName, LONG *Width, LONG *Height)

Now the codes work as follow:

GLuint textureObject;
LoadTexture("C:\\wood02.bmp", &textureObject);

Anyway, thanks to everybody for all the help rendered.

James.

Share this post


Link to post
Share on other sites
Gorax    202
Pity I didn't see this sooner. You're using a pointer, fair enough. What you forgot, is that it is basically an integer, which can be overwritten in the local function, and will be unaffected by the function's caller. Your change was probably the best one you could have made, but for future reference, this is how you would have used the other method:


//this function will return 0 on failure
int myFunction(char** myPtr){//note the pointer to the pointer
if (!myPtr) return 0;
//allocate your data
char* newPtr = (char*)malloc(1024);
if (!newPtr) return 0;
*myPtr = newPtr;//set the pointer (pointed to by 'myPtr') to your new pointer
return newPtr;
}

void myCallingFunction(){
char* myPtr = 0;
if (myFunction(&myPtr)){
free(myPtr);
printf("WOOHOO!\n");
}else{
printf("DAMN!\n");
}
}




Loading bitmaps taught me a lot about pointers, 'specially since I tend to rewrite my code a few times. ;)

[EDIT]
Fixed a memory leak. ;)

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Similar Content

    • By Arulbabu Donbosco
      There are studios selling applications which is just copying any 3Dgraphic content and regenerating into another new window. especially for CAVE Virtual reality experience. so that the user opens REvite or CAD or any other 3D applications and opens a model. then when the user selects the rendered window the VR application copies the 3D model information from the OpenGL window. 
      I got the clue that the VR application replaces the windows opengl32.dll file. how this is possible ... how can we copy the 3d content from the current OpenGL window.
      anyone, please help me .. how to go further... to create an application like VR CAVE. 
       
      Thanks
    • By cebugdev
      hi all,

      i am trying to build an OpenGL 2D GUI system, (yeah yeah, i know i should not be re inventing the wheel, but this is for educational and some other purpose only),
      i have built GUI system before using 2D systems such as that of HTML/JS canvas, but in 2D system, i can directly match a mouse coordinates to the actual graphic coordinates with additional computation for screen size/ratio/scale ofcourse.
      now i want to port it to OpenGL, i know that to render a 2D object in OpenGL we specify coordiantes in Clip space or use the orthographic projection, now heres what i need help about.
      1. what is the right way of rendering the GUI? is it thru drawing in clip space or switching to ortho projection?
      2. from screen coordinates (top left is 0,0 nd bottom right is width height), how can i map the mouse coordinates to OpenGL 2D so that mouse events such as button click works? In consideration ofcourse to the current screen/size dimension.
      3. when let say if the screen size/dimension is different, how to handle this? in my previous javascript 2D engine using canvas, i just have my working coordinates and then just perform the bitblk or copying my working canvas to screen canvas and scale the mouse coordinates from there, in OpenGL how to work on a multiple screen sizes (more like an OpenGL ES question).
      lastly, if you guys know any books, resources, links or tutorials that handle or discuss this, i found one with marekknows opengl game engine website but its not free,
      Just let me know. Did not have any luck finding resource in google for writing our own OpenGL GUI framework.
      IF there are no any available online, just let me know, what things do i need to look into for OpenGL and i will study them one by one to make it work.
      thank you, and looking forward to positive replies.
    • By fllwr0491
      I have a few beginner questions about tesselation that I really have no clue.
      The opengl wiki doesn't seem to talk anything about the details.
       
      What is the relationship between TCS layout out and TES layout in?
      How does the tesselator know how control points are organized?
          e.g. If TES input requests triangles, but TCS can output N vertices.
             What happens in this case?
      In this article,
      http://www.informit.com/articles/article.aspx?p=2120983
      the isoline example TCS out=4, but TES in=isoline.
      And gl_TessCoord is only a single one.
      So which ones are the control points?
      How are tesselator building primitives?
    • By Orella
      I've been developing a 2D Engine using SFML + ImGui.
      Here you can see an image
      The editor is rendered using ImGui and the scene window is a sf::RenderTexture where I draw the GameObjects and then is converted to ImGui::Image to render it in the editor.
      Now I need to create a 3D Engine during this year in my Bachelor Degree but using SDL2 + ImGui and I want to recreate what I did with the 2D Engine. 
      I've managed to render the editor like I did in the 2D Engine using this example that comes with ImGui. 
      3D Editor preview
      But I don't know how to create an equivalent of sf::RenderTexture in SDL2, so I can draw the 3D scene there and convert it to ImGui::Image to show it in the editor.
      If you can provide code will be better. And if you want me to provide any specific code tell me.
      Thanks!
    • By Picpenguin
      Hi
      I'm new to learning OpenGL and still learning C. I'm using SDL2, glew, OpenGL 3.3, linmath and stb_image.
      I started following through learnopengl.com and got through it until I had to load models. The problem is, it uses Assimp for loading models. Assimp is C++ and uses things I don't want in my program (boost for example) and C support doesn't seem that good.
      Things like glVertexAttribPointer and shaders are still confusing to me, but I have to start somewhere right?
      I can't seem to find any good loading/rendering tutorials or source code that is simple to use and easy to understand.
      I have tried this for over a week by myself, searching for solutions but so far no luck. With tinyobjloader-c and project that uses it, FantasyGolfSimulator, I was able to actually load the model with plain color (always the same color no matter what I do) on screen and move it around, but cannot figure out how to use textures or use its multiple textures with it.
      I don't ask much: I just want to load models with textures in them, maybe have lights affect them (directional spotlight etc). Also, some models have multiple parts and multiple textures in them, how can I handle those?
      Are there solutions anywhere?
      Thank you for your time. Sorry if this is a bit confusing, English isn't my native language
  • Popular Now