Sign in to follow this  
gp343

OpenGL Loading Texture

Recommended Posts

Hi there, I'm a newbie to Opengl programming and am currently trying to work with texture mapping. Now i'm trying to build a function to load a texture from a bitmap as the below code shows. However the texture is not loading at all my box is drawn but without any texture. Can somebody please take a look and point out what i'm doing wrong, as i've been working on this piece of code for 2 day. #include <windows.h> ##include <stdio.h> #include <stdlib.h> #include <math.h> #include <gl\gl.h> #include <gl\glu.h> #include <gl\glaux.h> GLuint texture; int LoadGLBitmap(const char*, LONG*, LONG*, GLubyte*); int LoadTexture(const char*, GLuint*); int InitGL(GLvoid) { glEnable(GL_TEXTURE_2D); LoadTexture("C:\\wood02.bmp", &texture); DrawBox() return TRUE; } int LoadGLBitmap(const char* FileName, LONG *Width, LONG *Height, GLubyte* pData) { ////// Defines #define BITMAP_ID 0x4D42 // the universal bitmap ID FILE *filePtr; BITMAPINFOHEADER InfoHeader; BITMAPFILEHEADER FileHeader; int imageIdx = 0; // image index counter unsigned chartempRGB; // swap variable // open filename in "read binary" mode filePtr = fopen(FileName, "rb"); if (filePtr == NULL) return NULL; // read the bitmap file header fread(&FileHeader, sizeof(BITMAPFILEHEADER), 1, filePtr); // verify that this is a bitmap by checking for the universal bitmap id if (FileHeader.bfType != BITMAP_ID) { fclose(filePtr); return NULL; } // read the bitmap information header fread(&InfoHeader, sizeof(BITMAPINFOHEADER), 1, filePtr); // move file pointer to beginning of bitmap data fseek(filePtr, FileHeader.bfOffBits, SEEK_SET); // allocate enough memory for the bitmap image data pData = (unsigned char*)malloc(InfoHeader.biSizeImage); // verify memory allocation if (!pData) { free(pData); fclose(filePtr); return NULL; } // read in the bitmap image data fread(pData, 1, InfoHeader.biSizeImage, filePtr); // make sure bitmap image data was read if (pData == NULL) { fclose(filePtr); return NULL; } // swap the R and B values to get RGB since the bitmap color format is in BGR for (imageIdx = 0; imageIdx < InfoHeader.biSizeImage; imageIdx+=3) { tempRGB = pData[imageIdx]; pData[imageIdx] = pData[imageIdx + 2]; pData[imageIdx + 2] = tempRGB; } // close the file and return the bitmap image data fclose(filePtr); *Width = InfoHeader.biWidth; *Height = InfoHeader.biHeight; return TRUE; }// End of LoadGLBitmap Function int LoadTexture(const char* Filename, GLuint* Texture) { LONG Width; LONG Height; GLubyte *pmsData=0; if(!LoadGLBitmap(Filename, &Width, &Height, pmsData)) { MessageBox(NULL,"Unable to Load Texture!","SHUTDOWN ERROR",MB_OK | MB_ICONINFORMATION); return 0; } glGenTextures(1, Texture); glBindTexture(GL_TEXTURE_2D, *Texture); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST); // generate the texture image glTexImage2D(GL_TEXTURE_2D, 0, GL_RGB, Width, Height, 0, GL_RGB, GL_UNSIGNED_BYTE, pmsData); free(pmsData); return 1; }// End of LoadTexture Function glEnable(GL_TEXTURE_2D); LoadTexture("C:\\wood02.bmp", &texture);

Share this post


Link to post
Share on other sites
Hi, I do not know if this will solve your problem: but I do see something
you should correct:

The third parameter (components) you pass to glTexImage2D() can only be 1, 2, 3 or 4(not GL_RGB).

typically you can get this value by dividing the bits per pixel (bpp) value by
the number of bits per component->

and, typically for a 24 bit bmp you would have 24/8 = 3:
That is 3 components.

so put 3 in there and see how you go.

Share this post


Link to post
Share on other sites
I'm afraid to say steven katic that you are infact wrong.
The third parameter of glTexImage() is infact the internal format flag, which has many different values which can be placed there, GL_RGB and GL_RGBA being the most common.
Now, you might have ment the 7th paramter, which indeed indictes the format of the incoming data, however this is a GLenum type and thus it is perfectly valid to use GL_RGB, GL_RGBA or any other valid enum value in that place.

This is why out of data tutorials should be burned from the internet as we know it [grin]

anyways, gp343, is your texture size a power-of-two in both dimentions? (ie 16x16, 32x16, 256x256 etc?)

also, the glaux library is out dated and as close to pure evil as you can get, you'll be wanting to find something else to load textures with (infact, gimmie 10mins and I'll add some links to the FAQ [grin])

Share this post


Link to post
Share on other sites
Thankyou _The_Phantom_ for the correction.
Sorry I did reference old documentation for that information. Naughty me.

Speaking of using something else to load textures:

From a practical point of view I do not have any problems using

gluBuild2DMipmaps() function. What do you think phantom?

Share this post


Link to post
Share on other sites
Nowt wrong with using it, however I favour just turning on automatic mipmap generation before uploading the base texture image and let the hardware sort it out (GL_SGIS_generate_mipmap being the extension in question) or using the FBO GenerateMipmap() function.

These should both give you the same result as using the glu function, possibly a little faster, if you need todo any complex mipmap generation you'd be better off doing it yaself anyways.

Share this post


Link to post
Share on other sites
All i'm trying to achieved with the previous posted code is to apply a texture to a simple QUAD. That is all. I wanted to code to be as Loosely Couple as possible. Most of the previous codes i've seen uses Global BITMAPINFOHEADER, BITMAPFILEHEADER structures, which does not follow the Loosely Couple-Highly Cohesive principles.

Regards

James (GP343)

Share this post


Link to post
Share on other sites
I'm sorry, but not yet, i'm still trying to load the texture onto a Quad.
I'm dereferencing all of my pointers correctly, i just can't see why this isn;t working.

Share this post


Link to post
Share on other sites
Yes, my texture is a power of two in both direction. I solved the problem anyway by re-arranging the code a bit.

All i did was to Re-defined the signature of the "LoadGLBitmap" function from:
int LoadGLBitmap(const char*, LONG*, LONG*, GLubyte*);

To:
GLubyte* LoadGLBitmap(const char* FileName, LONG *Width, LONG *Height)

Now the codes work as follow:

GLuint textureObject;
LoadTexture("C:\\wood02.bmp", &textureObject);

Anyway, thanks to everybody for all the help rendered.

James.

Share this post


Link to post
Share on other sites
Pity I didn't see this sooner. You're using a pointer, fair enough. What you forgot, is that it is basically an integer, which can be overwritten in the local function, and will be unaffected by the function's caller. Your change was probably the best one you could have made, but for future reference, this is how you would have used the other method:


//this function will return 0 on failure
int myFunction(char** myPtr){//note the pointer to the pointer
if (!myPtr) return 0;
//allocate your data
char* newPtr = (char*)malloc(1024);
if (!newPtr) return 0;
*myPtr = newPtr;//set the pointer (pointed to by 'myPtr') to your new pointer
return newPtr;
}

void myCallingFunction(){
char* myPtr = 0;
if (myFunction(&myPtr)){
free(myPtr);
printf("WOOHOO!\n");
}else{
printf("DAMN!\n");
}
}




Loading bitmaps taught me a lot about pointers, 'specially since I tend to rewrite my code a few times. ;)

[EDIT]
Fixed a memory leak. ;)

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Announcements

  • Forum Statistics

    • Total Topics
      628368
    • Total Posts
      2982293
  • Similar Content

    • By test opty
      Hi all,
       
      I'm starting OpenGL using a tut on the Web. But at this point I would like to know the primitives needed for creating a window using OpenGL. So on Windows and using MS VS 2017, what is the simplest code required to render a window with the title of "First Rectangle", please?
       
       
    • By DejayHextrix
      Hi, New here. 
      I need some help. My fiance and I like to play this mobile game online that goes by real time. Her and I are always working but when we have free time we like to play this game. We don't always got time throughout the day to Queue Buildings, troops, Upgrades....etc.... 
      I was told to look into DLL Injection and OpenGL/DirectX Hooking. Is this true? Is this what I need to learn? 
      How do I read the Android files, or modify the files, or get the in-game tags/variables for the game I want? 
      Any assistance on this would be most appreciated. I been everywhere and seems no one knows or is to lazy to help me out. It would be nice to have assistance for once. I don't know what I need to learn. 
      So links of topics I need to learn within the comment section would be SOOOOO.....Helpful. Anything to just get me started. 
      Thanks, 
      Dejay Hextrix 
    • By mellinoe
      Hi all,
      First time poster here, although I've been reading posts here for quite a while. This place has been invaluable for learning graphics programming -- thanks for a great resource!
      Right now, I'm working on a graphics abstraction layer for .NET which supports D3D11, Vulkan, and OpenGL at the moment. I have implemented most of my planned features already, and things are working well. Some remaining features that I am planning are Compute Shaders, and some flavor of read-write shader resources. At the moment, my shaders can just get simple read-only access to a uniform (or constant) buffer, a texture, or a sampler. Unfortunately, I'm having a tough time grasping the distinctions between all of the different kinds of read-write resources that are available. In D3D alone, there seem to be 5 or 6 different kinds of resources with similar but different characteristics. On top of that, I get the impression that some of them are more or less "obsoleted" by the newer kinds, and don't have much of a place in modern code. There seem to be a few pivots:
      The data source/destination (buffer or texture) Read-write or read-only Structured or unstructured (?) Ordered vs unordered (?) These are just my observations based on a lot of MSDN and OpenGL doc reading. For my library, I'm not interested in exposing every possibility to the user -- just trying to find a good "middle-ground" that can be represented cleanly across API's which is good enough for common scenarios.
      Can anyone give a sort of "overview" of the different options, and perhaps compare/contrast the concepts between Direct3D, OpenGL, and Vulkan? I'd also be very interested in hearing how other folks have abstracted these concepts in their libraries.
    • By aejt
      I recently started getting into graphics programming (2nd try, first try was many years ago) and I'm working on a 3d rendering engine which I hope to be able to make a 3D game with sooner or later. I have plenty of C++ experience, but not a lot when it comes to graphics, and while it's definitely going much better this time, I'm having trouble figuring out how assets are usually handled by engines.
      I'm not having trouble with handling the GPU resources, but more so with how the resources should be defined and used in the system (materials, models, etc).
      This is my plan now, I've implemented most of it except for the XML parts and factories and those are the ones I'm not sure of at all:
      I have these classes:
      For GPU resources:
      Geometry: holds and manages everything needed to render a geometry: VAO, VBO, EBO. Texture: holds and manages a texture which is loaded into the GPU. Shader: holds and manages a shader which is loaded into the GPU. For assets relying on GPU resources:
      Material: holds a shader resource, multiple texture resources, as well as uniform settings. Mesh: holds a geometry and a material. Model: holds multiple meshes, possibly in a tree structure to more easily support skinning later on? For handling GPU resources:
      ResourceCache<T>: T can be any resource loaded into the GPU. It owns these resources and only hands out handles to them on request (currently string identifiers are used when requesting handles, but all resources are stored in a vector and each handle only contains resource's index in that vector) Resource<T>: The handles given out from ResourceCache. The handles are reference counted and to get the underlying resource you simply deference like with pointers (*handle).  
      And my plan is to define everything into these XML documents to abstract away files:
      Resources.xml for ref-counted GPU resources (geometry, shaders, textures) Resources are assigned names/ids and resource files, and possibly some attributes (what vertex attributes does this geometry have? what vertex attributes does this shader expect? what uniforms does this shader use? and so on) Are reference counted using ResourceCache<T> Assets.xml for assets using the GPU resources (materials, meshes, models) Assets are not reference counted, but they hold handles to ref-counted resources. References the resources defined in Resources.xml by names/ids. The XMLs are loaded into some structure in memory which is then used for loading the resources/assets using factory classes:
      Factory classes for resources:
      For example, a texture factory could contain the texture definitions from the XML containing data about textures in the game, as well as a cache containing all loaded textures. This means it has mappings from each name/id to a file and when asked to load a texture with a name/id, it can look up its path and use a "BinaryLoader" to either load the file and create the resource directly, or asynchronously load the file's data into a queue which then can be read from later to create the resources synchronously in the GL context. These factories only return handles.
      Factory classes for assets:
      Much like for resources, these classes contain the definitions for the assets they can load. For example, with the definition the MaterialFactory will know which shader, textures and possibly uniform a certain material has, and with the help of TextureFactory and ShaderFactory, it can retrieve handles to the resources it needs (Shader + Textures), setup itself from XML data (uniform values), and return a created instance of requested material. These factories return actual instances, not handles (but the instances contain handles).
       
       
      Is this a good or commonly used approach? Is this going to bite me in the ass later on? Are there other more preferable approaches? Is this outside of the scope of a 3d renderer and should be on the engine side? I'd love to receive and kind of advice or suggestions!
      Thanks!
    • By nedondev
      I 'm learning how to create game by using opengl with c/c++ coding, so here is my fist game. In video description also have game contain in Dropbox. May be I will make it better in future.
      Thanks.
  • Popular Now