Jump to content
  • Advertisement
Sign in to follow this  
iliak

Unity c++ class design in dll

This topic is 4722 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

Hi I'm making a 3D engine as a dll. To do so, I give in the SDK pure virtual functions as below :
//file iTexture.h
class iTexture
{
public:
	iTexture()				{};
	virtual ~iTexture(void) {};

	virtual	int	GetHeight(void) = 0;
	virtual	int	GetWidth(void) = 0;

	/* .... */
};

And inside my dll, I do this :
//file cTexture.h
#include "iTexture.h"

class cTexture : public iTexture
{
	friend	class	cTextureManager;

public:
	cTexture(void);
	virtual	~cTexture(void);

	int	GetHeight(void);
	int	GetWidth(void);

	/* .... */
}

Problemes arises in derivated classes when I try to do something like that :
// file iStreamTexture.h

#include "iTexture.h"

class iStreamTexture : public iTexture
{
public:
	iStreamTexture()	{};
	~iStreamTexture()	{};

	virtual	bool	LoadAVIStream(const char *filename) = 0;
	/* ... */
	
}


// file cStreamTexture.h

#include "iStreamTexture.h"
#include "cTexture.h"

class cStreamTexture : public cTexture, iStreamTexture
{
public:
	cStreamTexture();
	virtual	~cStreamTexture();

	bool	LoadAVIStream(const char *filename);
	
	/* ... */
}


Error C2259 happen (Unable to instanciate abstract classes). In a previous thread, Enigma gave me a solution to work around my problem. I want to know if it's the good solution to do such ? Let's look at other "dll engine" does as I do and they don't have this problem. Where am I wrong ?

Share this post


Link to post
Share on other sites
Advertisement
Relying on interface is certainly a good thing, doing multiple inheritance is bad, very very bad :).

Your having a deadly diamond problem right now. You are trying to inherit from cTexture and IStreamTexture, both of which are depending on ITexture. I would recommand changing this and pulling that diamond out.

I think you can fix it if you try

using iStreamTexture::GetHeight;
using iStreamTexture::GetWidth;

in you cStreamTexture.

But this isn't the best solution. Also if you are working with dlls, you will need to export either your class (might not be in your best interest since you are working with interfaces anyway), or create a factory that will return you your interfaces. That factory will need to be exported (can be as simple as a CreateStreamTexture exported function).

Hope this helps,

Shadx

Share this post


Link to post
Share on other sites
Quote:
Original post by Shadx
Your having a deadly diamond problem right now. You are trying to inherit from cTexture and IStreamTexture, both of which are depending on ITexture. I would recommand changing this and pulling that diamond out.

I think you can fix it if you try

using iStreamTexture::GetHeight;
using iStreamTexture::GetWidth;
in you cStreamTexture.


Here's what did :

int GetHeight(void) {return cTexture::GetHeight();};
int GetWidth(void) {return cTexture::GetWidth();};





Quote:

But this isn't the best solution. Also if you are working with dlls, you will need to export either your class (might not be in your best interest since you are working with interfaces anyway), or create a factory that will return you your interfaces. That factory will need to be exported (can be as simple as a CreateStreamTexture exported function).


I use a cTextureManager::CreateTexture(....) class inside the dll :)
As You said I have to get ride of this diamond problem...

Share this post


Link to post
Share on other sites
The problem is your use of non-virtual inheritance. With non-virtual inheritance a base class can be included multiple times in an inheritance hierarchy. For example your cStreamTexture inheritance hierarchy looks like:
    cStreamTexture
| |
V V
cTexture iStreamTexture
| |
V V
iTexture iTexture

Now cStreamTexture inherits two copies of iTexture. cTexture correctly overrides the pure virtual functions of one of those instances, but the pure virtual functions of the other instance are never overriden, causing cStreamTexture to be an abstract class.
By using virtual inheritance you resolve this problem and your inheritance hierarchy now looks like:
   cStreamTexture
| |
V V
cTexture iStreamTexture
| |
V V
iTexture

You now only have one copy of iTexture and cTexture overrides the pure virtual functions contained within.

This is actually one of the (relatively) few cases where multiple inheritance is probably a good solution to a problem. I certainly don't know of any nice equivalent solutions without using multiple inheritance.

It is important to note that this is a simple case of multiple inheritance. Since iTexture and iStreamTexture are abstract base classes many of the problems with general multiple inheritance cannot arise. In fact this form of virtual inheritance is so safe even Java implements it, via interfaces (no offense to Java programmers [lol]).

Enigma

Share this post


Link to post
Share on other sites
Enigma, you are my hero one more time :)
I found a "work around", but your solution is nice too.

many thx !

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
  • Advertisement
  • Popular Tags

  • Similar Content

    • By Alexander_Vovk
      Hello Guys!
      Please share your experience, where is it better to find sales manager  specialists for indie team of 6 + people(remotely)?
      Maybe someone has a good experience of cooperation with finding projects through sale managers(USA and Canada)?
      Thank you
      Best Regards
      Alex Vovk
      Co-Founder of Sixteen Squares
      Alexander_Vovk@outlook.com
       
    • By RoKabium Games
      Been a bit quiet recently, but we've been busy bug fixing and tweaking things... Now we have lots more 'Particle effects' in the game, specifically here the Flamethrower and Enemy attacks!
    • By JoshuaFraser
      Hi and thanks for reading, I have an issue with this reactive crosshair script, everything works fine until I start changing the offset. Give the script a go and you will see what I mean, when I do SetOffset(0f); it doesnt always set back to the origional state, if anyone can spot a fix I'd be super appreciative!
      using System.Collections; using System.Collections.Generic; using UnityEngine; public class ReactiveCrosshair : MonoBehaviour { [SerializeField] GameObject c_limb_prefab; private float center_offset = 0f; private float current_offset = 0f; private float max_offset = .5f; private int number_of_limbs = 4; private float limb_length = .05f; private float limb_width = .005f; private List<GameObject> c_limbs = new List<GameObject>(); public void SetupCrosshair(){ for (int i = 0; i < number_of_limbs; i++) { GameObject line_go = (GameObject)Instantiate (c_limb_prefab); line_go.transform.SetParent (this.transform); Vector3 limb_pos = new Vector3 (0f,0f,0f); //line_go.transform.position = limb_pos; line_go.transform.localPosition = limb_pos; LineRenderer line = line_go.GetComponent<LineRenderer>(); line.startWidth = limb_width; line.positionCount = 2; line.SetPosition (0, line_go.transform.localPosition + new Vector3(center_offset, 0f, 0f)); line.SetPosition (1, line_go.transform.localPosition + new Vector3(center_offset + limb_length, 0f, 0f)); line.useWorldSpace = false; c_limbs.Add(line_go.gameObject); } if (c_limbs != null) { OrientLimbs (); SetOffset (0f); } } public void OrientLimbs(){ for (int i = 0; i < c_limbs.Count; i++) { float rotation_step = 360f / (float)c_limbs.Count; c_limbs [i].transform.RotateAround (c_limbs[i].transform.position, c_limbs[i].transform.forward, 90f + (rotation_step * (float)i)); } } public void SetOffset(float _current_spread){ float offset = Mathf.Lerp (0f, max_offset, _current_spread); for (int i = 0; i < number_of_limbs; i++) { if (offset > current_offset) { Vector3 pos = c_limbs [i].transform.position + (c_limbs [i].transform.TransformDirection (Vector3.right) * offset); c_limbs [i].transform.position = pos; } if (offset < current_offset) { Vector3 pos = c_limbs [i].transform.position - (c_limbs [i].transform.TransformDirection (Vector3.right) * offset); c_limbs [i].transform.position = pos; } } Debug.Log ("SetOffset() offset: " + offset.ToString () + " _current_spread: " + _current_spread.ToString() + " localPos: " + c_limbs[1].transform.localPosition); current_offset = offset; } }  
    • By Erik Nivala
      So, as the title says i am trying to figure out a good way sync all that information with other players in Unity. My problem is that i can't come up with a good solution since i am used to creating classes for everything e.g. attachments are its own class and then the weapon would save a reference to that attachment. But since you can't send custom classes over [Command] & [ClientRPC] i am a little stuck. A solution for this would be giving each attachment for a slot a unique ID and then passing the ID to other player but i feel like that is very error prone if other ppl add a new attachment or the IDs get mixed up.
      Is there a "standard" way that this is usually done that i am missing?
      I am fairly new to programming so any help is appreciated!
    • By MintyLyton
      I'm looking for any team / people that need a programmer for their project. I'm looking to expand my portfolio which you can see Here. I'm more experienced with Unity but I can spend the time to learn new Engines if that's your preference. I have worked on Unreal Engine 4 before but I might take some time to re-learn it, if the project requires it. Feel free to DM here or use the contact info on my website. 
    • By ethancodes
      I'm working on a system for my game that will allow the player to stack pick ups in a queue. As one pick up expires, the next automatically activates. I'm having an issue though where if I pick up the first one, it activates fine, but if i pick up a second directly after it, it overrides the first one, activates the second one, and then once it has run it's course, everything goes back to normal gameplay, no first pick up. I'm not sure why this is happening. Hopefully someone can spot what I'm doing wrong in my code.
      Here is the code for the pick up manager:
      // Update is called once per frame void Update () { if (pickUpQueue.Count != 0 && !pickUpActive) { pickUpActive = true; pickUpQueue[0].ActivatePickUp(); } DeactivatePickUp(); } void DeactivatePickUp () { if (pickUpQueue.Count != 0 && pickUpActive) { Destroy (pickUpQueue [0]); pickUpQueue.RemoveAt (0); pickUpActive = false; } } And here is the PickUp:
      public override void ActivatePickUp () { ball.GetComponent<Ball>().Speed = 2.0f; //increase ball speed... ball.GetComponent<Ball>().StartCoroutine(timer); //...set time that power up is active }  
      There is also a Base Pick Up:
      public void OnCollisionEnter2D (Collision2D collision) { Vector2 tweak = new Vector2 (Random.Range(0f, 0.2f),Random.Range(0f, 0.2f)); this.gameObject.GetComponent<Rigidbody2D>().velocity += tweak; //if the pickup makes contact with the paddle or ball.... if (collision.gameObject.tag == "Paddle" || collision.gameObject.tag == "Ball") { GameObject.FindObjectOfType<GameManager>().GetComponent<PickUpManager>().pickUpQueue.Add(this); Destroy(gameObject); //...and finally destroy power up object } } As a side note, I am trying to find a solution to this that will work for all of my pickups. Some pickups are ammo based, some are timed. 
    • By D34DPOOL
      Edit Your Profile D34DPOOL 0 Threads 0 Updates 0 Messages Network Mod DB GameFront Sign Out Add jobEdit jobDeleteC# Programmer for a Unity FPS at Anywhere   Programmers located Anywhere.
      Posted by D34DPOOL on May 20th, 2018
      Hello, my name is Mason, and I've been working on a Quake style arena shooter about destroying boxes on and off for about a year now. I have a proof of concept with all of the basic features, but as an artist with little programming skill I've reached the end of my abilities as a programmer haha. I need someone to help fix bugs, optomize code, and to implent new features into the game. As a programmer you will have creative freedom to suggest new features and modes to add into the game if you choose to, I'm usually very open to suggestions :).
      What is required:
      Skill using C#
      Experience with Unity
      Experience using UNET (since it is a multiplayer game), or the effort and ability to learn it
      Compensation:
      Since the game currently has no funding, we can split whatever revenue the game makes in the future. However if you would perfer I can create 2D and/or 3D assets for whatever you need in return for your time and work.
      It's a very open and chill enviornment, where you'll have relative creative freedom. I hope you are interested in joining the team, and have a good day!
       
      To apply email me at mangemason@yahoo.com
    • By davejones
      Is there a way to automatically change the start position of an animation? I have a bunch of animations set up on 3D models in unity. The issue is that I need to move the 3D models, however when I do so the animation start positions are not updated and I have to do it manually.

      Changing the transform of key frames is time consuming with the amount of animations I have, so I was wondering if there was a way to do it automatically?
    • By MoreLion
      hey all! We are looking for members for our Unity horror game! 
      Here’s the story:
      After a deadly virus plunges the world into chaos killing 85% of the human population there are now what they call “zones” these zones are watched very closely by the surviving government, people are checked every day for the virus, even if you touch the spit or any human waste or fluids of the victim who is infected, you will die. But one day, people in the west zone start to go missing, 1 woman goes outside the walls to uncover the mystery, is there more to the virus than meets the eye?, That is where your story starts.
      This game is not a long development game, I have loads other game ideas,
      I will also allow you to have a bit of creative freedom if you wish to add or share a idea!
      And no, it’s not a zombie game lol I feel like zombie games are too generic, in this game you will encounter terrifying beasts!
      There is some concept art one of our concept artists have made
      If interested email liondude12@gmail.com
    • By Canadian Map Makers
      GOVERNOR is a modernized version of the highly popular series of “Caesar” games. Our small team has already developed maps, written specifications, acquired music and performed the historical research needed to create a good base for the programming part of the project.

      Our ultimate goal is to create a world class multi-level strategic city building game, but to start with we would like to create some of the simpler modules to demonstrate proof of concept and graphical elegance.

       

      We would like programmers and graphical artists to come onboard to (initially) create:

      A module where Province wide infrastructure can be built on an interactive 3D map of one of the ancient Roman Provinces.
      A module where city infrastructure can be built on a real 3D interactive landscape.
      For both parts, geographically and historically accurate base maps will be prepared by our team cartographer. Graphics development will be using Blender. The game engine will be Unity.

       

      More information, and examples of the work carried out so far can be found at http://playgovernor.com/ (most of the interesting content is under the Encyclopedia tab).

       

      This project represents a good opportunity for upcoming programmers and 3D modeling artists to develop something for their portfolios in a relatively short time span, working closely with one of Canada’s leading cartographers. There is also the possibility of being involved in this project to the point of a finished game and commercial success! Above all, this is a fun project to work on.

       

      Best regards,

      Steve Chapman (Canadian Map Makers)

       
  • Advertisement
  • Popular Now

  • Forum Statistics

    • Total Topics
      631399
    • Total Posts
      2999847
×

Important Information

By using GameDev.net, you agree to our community Guidelines, Terms of Use, and Privacy Policy.

Participate in the game development conversation and more when you create an account on GameDev.net!

Sign me up!