• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
Dim_Yimma_H

[web] Can't get JavaScript function call to work in Firefox

4 posts in this topic

I've written a javascript function which makes a table in a convenient way and it was OK when I ran it in Internet Explorer but I can't get it to work in Firefox. Luckily, Firefox says in the javascript Console function name "is not defined". What I do is simply call a function (writeText) from another function (createDocument) and writeText is defined above createDocument, if I replace the function call with the code in it then it works. Below is an example which works in IE but not in Firefox, it's very basic so I believe I've misunderstood something crucial about javascript. I would be very happy to hear some guidelines.
<html>
<head>

<title>test</title>

<script type="text/javascript">
function writeText(text)
{
	document.write(text)
}

function createDocument(title)
{
	document.open()
	
	var string = "<html><head><title>" + title + "</title></head><body>"
	document.write(string)

	writeText(title)

	string = "</body></html>"
	document.write(string)
	
	document.close()
}
</script>

</head>

<body>
<a href="javascript:createDocument('test')">click here to test</a>
</body>

</html>



0

Share this post


Link to post
Share on other sites
Have you tried putting, y'know, semi-colons after your statements? ;)

IE will try to assemble something meaningful from a lot of code, but usually not very well - FireFox is a lot more picky about syntax. Fortunately.
0

Share this post


Link to post
Share on other sites
It looks like a limitation of FireFox's document.open(). As soon as that is called, the rest of the javascript functions seem to disappear. This is either a bug or just how FireFox happens to handle an ambiguous/non-standard case (if it is one). According to the specs: "Open a document stream for writing. If a document exists in the target, this method clears it." It does work under Opera.

If you re-write it like:


function createDocument(title)
{
function writeText(text)
{
d.write(text)
}
}



it works. So basically, your function calling code is correct. The only reason why it cannot find the function is because of the document.open().
0

Share this post


Link to post
Share on other sites
You're essentially falling into the javascript trap of trying to do more than one thing at once - the results are pretty much guaranteed to be undefined.

Calling document.open on the currently active document, will wipe it out. And everything else will go away with it.

One option is to use a javascript: URL to return the HTML you need - this seems more likely to work (but it's still evil).

Better still, don't use this method at all, and either use DOM manipulation to effect what you need, or server-side code.

Anyway, what's wrong with

<a href="someblankpage.html">



?

Mark
0

Share this post


Link to post
Share on other sites
konForce, that made a lot of sense, and thanks for the suggestion about defining a local function, but I will have to redefine it in every function I want to call it from. I thought if I made a separate JS file, I should be able to take the functions with me to the new blank document by putting a script src tag in the new document too, unforunately that didn't work either. I'll probably do like you said and define local functions.
Quote:
Original post by markr
Better still, don't use this method at all, and either use DOM manipulation to effect what you need, or server-side code.
Mark

That might be a good idea, I can try to do the same thing using the innerHTML property.
Quote:
Original post by markr
Anyway, what's wrong with
*** Source Snippet Removed ***

?

Mark

The documents contains images, so instead of linking to many finished documents (pain to update'em all) I decided to convert an array of names into links and create the targets dynamically. What I like about it is that I get a lot less documents to handle. But since many people use Firefox I want to make sure it works for it too.
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0