************************************ DISCLAIMER: I KNOW THIS CODE IS UGLY ************************************ ok... now that I took care of that, I need help identifying how to fix a segmentation fault. It occurs on this line in my code: iPossibilities[possibilities][COUNTFINAL] = iWord[POS]; // <-- THIS ONE Maybe I am having troubles figuring this out because I have written some code that should probably never be seen it is so terrible. I have 6 for loops nested... lol... but I am just doing this to get an answer for an extra credit problem in math, and I only have tonight. Anyways, here is my function abomination: (sorry I'm not sure what code tags are)

/***************************************************************************
*******void iGenerateList(int iWord[5], int iPossibilities[121][5])
***************************************************************************/
void iGenerateList(int iWord[5], int iPossibilities[121][5])
{
    int i,j,k,l,m;
    int possibilities = 0;
    // int temp[5];
    int used[6]; //levels of usage

    //BEGIN THE GENERATION!!!
    /*
     * A note to all -
     *     THIS IS THE MOTHER OF ALL NESTED FOR-SETS!!!
    */
    for(i = 0; i < 5; i++) //for
    {
        used[0] = i;
        for(j = 0; j < 5; j++) //for
        {
            if(j == used[0])
            { // nothing 
            }
            else
            { used[1] = j; }
            
            for(k = 0; k < 5; k++) //for
            {
                if((k == used[0]) || (k == used[1]))
                { // nothing 
                }
                else
                { used[2] = k; }
                
                for(l = 0; l < 5; l++) //for
                {
                    if((l == used[0]) || (l == used[1]) || (l == used[2]))
                    { // nothing 
                    }
                    else
                     { used[3] = l; }
                     
                     for(m = 0; m < 5; m++) //for
                     {
                         if((m == used[0]) || (m == used[1]) || (m == used[2]) || (m == used[3]))
                         { // nothing 
                         }
                         else
                         { used[4] = m; }
                         
                         possibilities++;
                         int COUNTFINAL = 0;
                         for(COUNTFINAL = 0; COUNTFINAL < 5; COUNTFINAL++) //for
                         {
                             int POS = used[COUNTFINAL];
                             iPossibilities[possibilities][COUNTFINAL] = iWord[POS]; // <-- HERE IT IS ******************************* THE BAD LINE!!!
                         }//for
                     }//for
                }//for
            }//for
        }//for
    }//for
    
    //omg its over

}//function

If somebody can figure out what I am doing wrong, I would be very happy. I don't think I'm writing past the end of the arrray, and it still occurred when I put limitations on possibilities ( less than 120 ) so i dunno... Please Help!

thanks for cleaning it up, it helps a lot since i had to just throw this together. unfortunately, the clean code still has a segmentation fault... on the same line...

I see what you mean about that overindexing... but I put a limitation around the code at fault and

if (possibilities < 120)
{
then do bad line...
}

I still have the fault...

Hey i figured something out! I had to initialize all of the used[] variables to a value before I could write to them. Don't know for sure why, but I'm assuming it has to to with memory allocation. Of course the program doesn't find the values that I want, but I'll work on that. Thanks for the help guys.



EDIT: I moved possibilities into the conditional statement in the for loop with four (..) || (..) so that I wouldn't have way too many possibilities also

EDIT: Lol thx for the tip on used[] Dave. Sry im trying to move around too fast