Jump to content
  • Advertisement
Sign in to follow this  
TEUTON

doubly linklist problem

This topic is 4525 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

Why does my code crash in Reverse_Traverse member function...I am using VC 6.0
// Doubly Linked List.cpp

#include <iostream>
using std::cout;
using std::cin;
using std::endl;

struct Node{
	int data;
	Node* prev;
	Node* next;
};//End of the structure definition

class Doubly_Linked_list{
private:
	Node* HEAD;
public:
	Doubly_Linked_list():HEAD(NULL){}// Initialise the HEAD pointer
	void Insert_at_the_Beginning(int i);
	void Forward_Traverse();
	void Reverse_Traverse();
	~Doubly_Linked_list();
};// End of the class definition

Doubly_Linked_list::~Doubly_Linked_list(){
	cout<<"Destructor Called\nMemory Realesed\n";
	Node* p;
	while(HEAD != NULL){
		p = HEAD;
		HEAD = HEAD->next;
		delete p; 
	}
	HEAD = NULL;  

}
void Doubly_Linked_list::Insert_at_the_Beginning(int i){
	Node* p = new Node; 
	if(p!=NULL){
		
		p->data=i;
		p->prev=NULL;
		p->next=NULL;
		if(HEAD==NULL){
			HEAD=p;
			return;
		}		
		p->next=HEAD;
		HEAD->prev=p;
		HEAD=p;
	}
	else{
		cout<<"Memory Exception Occurred";
		return;
	}
}// End of the function

void Doubly_Linked_list::Forward_Traverse(){
	for(Node* START = HEAD; START!=NULL; START=START->next)	{
		cout<< START->data<<endl; 
		//cout<< START->next<<endl; 
	}
	cout<<endl;
}
// Function  to traverse a doubly linked list in the reverse direction


void Doubly_Linked_list::Reverse_Traverse(){
	Node* END,*CURRENT;
	for(CURRENT = HEAD; CURRENT!=NULL; CURRENT=CURRENT->next);
	
	END = CURRENT;
	
	for(CURRENT = END; CURRENT!=HEAD; CURRENT=CURRENT->prev){
		cout<<CURRENT->data<<endl;
	}
} 

int main(){
	
	Doubly_Linked_list* l = new Doubly_Linked_list();

	l->Insert_at_the_Beginning(10);
	l->Insert_at_the_Beginning(20);
	l->Insert_at_the_Beginning(30);
	l->Insert_at_the_Beginning(50);
	l->Forward_Traverse();
	l->Reverse_Traverse();
	delete l;
return 0;
}

Share this post


Link to post
Share on other sites
Advertisement

void Doubly_Linked_list::Reverse_Traverse(){

Node* END,*CURRENT;

for(CURRENT = HEAD; CURRENT!=NULL; CURRENT=CURRENT->next);

//CURRENT is set to NULL because we are 1 past the end of the list

END = CURRENT;

// END is null

for(CURRENT = END; CURRENT!=HEAD; CURRENT=CURRENT->prev){
//Going to a previous that is non existant

cout<<CURRENT->data<<endl;

}

}




Atleast from what I can tell this is whats happening...I didn't run this in any compiler or through a debugger.

Share this post


Link to post
Share on other sites
Place a breakpoint, fire up the debugger and learn why your code crashes. Look for uninitialized memory.

In particular, if you ever try to dereference a null pointer (like access the prev member of a null node), you'll crash with an illegal access violation.

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
×

Important Information

By using GameDev.net, you agree to our community Guidelines, Terms of Use, and Privacy Policy.

Participate in the game development conversation and more when you create an account on GameDev.net!

Sign me up!