Sign in to follow this  
Aragon

OpenGL little question about drawelement

Recommended Posts

hi @all i play around with openGL since a few days and now i want to create an 50x50grid for example (base for landscapes) i play around with the examples from redbook but how can i add here texturecoordinates and normals to the code here? google/nehe/codesampler/etc offers me no real tutorial "in one piece" to learn about drawelements, only little pieces i am not able to complete so i took that way to pick sample of rebook that works and learn by modifying that but my question is: how can i add my textures and normal coordinates to that 'v' thing and how use the texture in draw call then ? and p.s.: if you can tell me where to activate z buffer ;)

#define NFACE 6
#define NVERT 8
void drawCube(GLdouble x0, GLdouble x1, GLdouble y0,
GLdouble y1, GLdouble z0, GLdouble z1)
{
static GLfloat v[8][3];
static GLfloat c[8][4] = {
{0.0, 0.0, 0.0, 1.0}, {1.0, 0.0, 0.0, 1.0},
{0.0, 1.0, 0.0, 1.0}, {1.0, 1.0, 0.0, 1.0},
{0.0, 0.0, 1.0, 1.0}, {1.0, 0.0, 1.0, 1.0},
{0.0, 1.0, 1.0, 1.0}, {1.0, 1.0, 1.0, 1.0}
};
/* indices of front, top, left, bottom, right, back faces */
static GLubyte indices[NFACE][4] = {
{4, 5, 6, 7}, {2, 3, 7, 6}, {0, 4, 7, 3},
{0, 1, 5, 4}, {1, 5, 6, 2}, {0, 3, 2, 1}
};

....

// Vertices Positions 
v[0][0] = v[3][0] = v[4][0] = v[7][0] = x0;
v[1][0] = v[2][0] = v[5][0] = v[6][0] = x1;
v[0][1] = v[1][1] = v[4][1] = v[5][1] = y0;
v[2][1] = v[3][1] = v[6][1] = v[7][1] = y1;
v[0][2] = v[1][2] = v[2][2] = v[3][2] = z0;
v[4][2] = v[5][2] = v[6][2] = v[7][2] = z1;

//Normal Positions

// ????

// Texture Positions

// ????



//drawing example 


glEnable (GL_DEPTH_TEST);  // Z buffer is not working

glEnable(GL_TEXTURE_2D);
glBindTexture(GL_TEXTURE_2D, g_textureID[0]); 

glEnableClientState (GL_VERTEX_ARRAY);
glEnableClientState (GL_COLOR_ARRAY);
glVertexPointer (3, GL_FLOAT, 0, v);
glColorPointer (4, GL_FLOAT, 0, c);

** ?!?!  glNORMALPointer (3, GL_FLOAT, 0, v);
** ?!?! glTEXTUREPointer (2, GL_FLOAT, 0, v);

glDrawElements(GL_QUADS, NFACE*4, GL_UNSIGNED_BYTE, indices);

glDisableClientState (GL_VERTEX_ARRAY);
glDisableClientState (GL_COLOR_ARRAY);

can you help me? much thx for all answers :) p.s.: i hate google

Share this post


Link to post
Share on other sites
You don't "add" your normals and texture coordinates to the 'v' buffer -- you just create them in their own buffers, like you did with the colors (the 'c' buffer). For example:
static GLfloat t[8][2] = {
{ ...your texture coords go here... },
};

Then call:
glTexCoordPointer(2, GL_FLOAT, 0, t);
...as you already have. And don't forget to enable GL_TEXTURE_COORD_ARRAY.

The same style goes for normals too.

As for your Z buffer not working, it's possible you're not creating it when you initialize the pixel format. Or it could be you're not clearing it either (setting GL_DEPTH_BUFFER_BIT when calling glClear). I'd need to see more code to tell you exactly.

Share this post


Link to post
Share on other sites

much thankx.. i start to understand how it works :)

and i works ..the textures are working perfekt
-> glTexCoordPointer (2, GL_FLOAT, 0, t);


what is the correct spell for normals to activate
like glTexNormalPointer (3, GL_FLOAT, 0, n) ; ?


for Z buffer, here
is my initialisation (fullscreen)
and start of my main(render)

much thx :)




void init( void)
{

EnumDisplaySettings( NULL, ENUM_CURRENT_SETTINGS, &g_oldDevMode );

int nMode = 0;
DEVMODE devMode;
bool bDesiredDevModeFound = false;

while( EnumDisplaySettings( NULL, nMode++, &devMode ) )
{

if( devMode.dmPelsWidth != reso_x || devMode.dmPelsHeight != reso_y)
continue;

// Does this device mode support 32-bit color?
if( devMode.dmBitsPerPel != 32 )
continue;

// Does this device mode support a refresh rate of 75 MHz?
if( devMode.dmDisplayFrequency != 75 )
continue;

// We found a match, but can it be set without rebooting?
if( ChangeDisplaySettings( &devMode, CDS_TEST ) == DISP_CHANGE_SUCCESSFUL )
{
bDesiredDevModeFound = true;
break;
}
}

if( bDesiredDevModeFound == false )
{
// TO DO: Handle lack of support for desired mode...
return;
}

//
// Verify hardware support by enumerating pixel formats...
//

g_hDC = GetDC( g_hWnd );

PIXELFORMATDESCRIPTOR pfd;

int nTotalFormats = DescribePixelFormat( g_hDC, 1, sizeof(pfd), NULL );

int nPixelFormat;

for( nPixelFormat = 1; nPixelFormat <= nTotalFormats; ++nPixelFormat )
{
if( DescribePixelFormat( g_hDC, nPixelFormat, sizeof(pfd), &pfd ) == 0 )
{
DWORD dwErrorCode = GetLastError();
// TO DO: Respond to failure of DescribePixelFormat
return;
}

if( !(pfd.dwFlags & PFD_SUPPORT_OPENGL) )
continue;

if( !(pfd.dwFlags & PFD_DOUBLEBUFFER) )
continue;

if( !(pfd.dwFlags & PFD_DRAW_TO_WINDOW) && fullscreen==0 )
continue;

if( pfd.iPixelType != PFD_TYPE_RGBA )
continue;

if( pfd.cColorBits != 32 )
continue;

if( pfd.cDepthBits != 16 )
continue;

// If we made it this far, we found a match!
break;
}

//
// Everything checks out - create the rendering context and
// switch the display settings with our new device mode...
//
if( SetPixelFormat( g_hDC, nPixelFormat, &pfd) == FALSE )
{
DWORD dwErrorCode = GetLastError();
// TO DO: Respond to failure of SetPixelFormat
return;
}

g_hRC = wglCreateContext( g_hDC );
wglMakeCurrent( g_hDC, g_hRC );


if( ChangeDisplaySettings( &devMode, CDS_FULLSCREEN ) != DISP_CHANGE_SUCCESSFUL )
{
// TO DO: Respond to failure of ChangeDisplaySettings
return;
}


loadTexture();

// Setup inits

glClearColor( 0.0f, 0.0f, 0.2f, 1.0f );
glEnable(GL_TEXTURE_2D);

glEnable (GL_DEPTH_TEST);


glMatrixMode( GL_PROJECTION );
glLoadIdentity();
gluPerspective( 45.0, (GLdouble)reso_x / reso_y, 0.0001, 100.0 );

int nNumTextureUnits = 0;
glGetIntegerv( GL_MAX_TEXTURE_UNITS_ARB, &nNumTextureUnits );

ShowCursor(false);
}



........................


void render( void )
{
glClear( GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT );

//draw_land();


glMatrixMode( GL_MODELVIEW );
glLoadIdentity();


Share this post


Link to post
Share on other sites
Normals work fine now :)

but the Z Buffer problem is still there



void render( void )
{
glDepthFunc(GL_LESS);
glClearDepth(1.0);

glClear( GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT );




another thing i see now.. if the object hit the borders
the texture positions seems to be moved at this vertice
that are out of the screen.


much thanx for your time :)

Share this post


Link to post
Share on other sites
hurray ... i got it !!!!


in the init of opengl was the error!


-> //if( !(pfd.dwFlags & PFD_DRAW_TO_WINDOW) && fullscreen==0 )continue;

-> if( pfd.cDepthBits != 16 ) continue;

after diabling thoose two lines
the Z Buffer error was complete away,
the textures painted normal
and

the FPS raised from 6 FPS to 91 FPS



much much thankx for your fast help :)

(i post some screenshots when i get better with opengl ,
my networkcode and other things runs perfect
we work on an mmorpg and we decided to move from directx to opengl
and i need to reprogramm all basic graphic parts of the engine.
(to avoid the xp/vista chaos that will hit much gamers)
(the game is a bit like the old ultima online..in 3d but with old touch)

greetings sven













Share this post


Link to post
Share on other sites
Quote:
Original post by Aragon
in the init of opengl was the error!


-> //if( !(pfd.dwFlags & PFD_DRAW_TO_WINDOW) && fullscreen==0 )continue;

-> if( pfd.cDepthBits != 16 ) continue;

after diabling thoose two lines
the Z Buffer error was complete away,
the textures painted normal
and

the FPS raised from 6 FPS to 91 FPS


Hmm... it sounds like the pixel format checking code picked the Microsoft OpenGL driver, rather than your video card's driver.

It _might_ be that a cDepthBits of 16 wasn't good -- perhaps 24 would work better?

Glad it's fixed, though! :)

Share this post


Link to post
Share on other sites
...thats very possible

i will work on the code to avoid such problems again,
but first i have to get much much deeper into openGL
to understand it..but i get quicker results
with opengl than with directx... thats absolut great

z buffer is working, index buffers working,
lighting is now working.. alpha transparency and colorkeying
is working..

what a wonderfull day :)

much thx again



Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Announcements

  • Forum Statistics

    • Total Topics
      628315
    • Total Posts
      2982031
  • Similar Content

    • By mellinoe
      Hi all,
      First time poster here, although I've been reading posts here for quite a while. This place has been invaluable for learning graphics programming -- thanks for a great resource!
      Right now, I'm working on a graphics abstraction layer for .NET which supports D3D11, Vulkan, and OpenGL at the moment. I have implemented most of my planned features already, and things are working well. Some remaining features that I am planning are Compute Shaders, and some flavor of read-write shader resources. At the moment, my shaders can just get simple read-only access to a uniform (or constant) buffer, a texture, or a sampler. Unfortunately, I'm having a tough time grasping the distinctions between all of the different kinds of read-write resources that are available. In D3D alone, there seem to be 5 or 6 different kinds of resources with similar but different characteristics. On top of that, I get the impression that some of them are more or less "obsoleted" by the newer kinds, and don't have much of a place in modern code. There seem to be a few pivots:
      The data source/destination (buffer or texture) Read-write or read-only Structured or unstructured (?) Ordered vs unordered (?) These are just my observations based on a lot of MSDN and OpenGL doc reading. For my library, I'm not interested in exposing every possibility to the user -- just trying to find a good "middle-ground" that can be represented cleanly across API's which is good enough for common scenarios.
      Can anyone give a sort of "overview" of the different options, and perhaps compare/contrast the concepts between Direct3D, OpenGL, and Vulkan? I'd also be very interested in hearing how other folks have abstracted these concepts in their libraries.
    • By aejt
      I recently started getting into graphics programming (2nd try, first try was many years ago) and I'm working on a 3d rendering engine which I hope to be able to make a 3D game with sooner or later. I have plenty of C++ experience, but not a lot when it comes to graphics, and while it's definitely going much better this time, I'm having trouble figuring out how assets are usually handled by engines.
      I'm not having trouble with handling the GPU resources, but more so with how the resources should be defined and used in the system (materials, models, etc).
      This is my plan now, I've implemented most of it except for the XML parts and factories and those are the ones I'm not sure of at all:
      I have these classes:
      For GPU resources:
      Geometry: holds and manages everything needed to render a geometry: VAO, VBO, EBO. Texture: holds and manages a texture which is loaded into the GPU. Shader: holds and manages a shader which is loaded into the GPU. For assets relying on GPU resources:
      Material: holds a shader resource, multiple texture resources, as well as uniform settings. Mesh: holds a geometry and a material. Model: holds multiple meshes, possibly in a tree structure to more easily support skinning later on? For handling GPU resources:
      ResourceCache<T>: T can be any resource loaded into the GPU. It owns these resources and only hands out handles to them on request (currently string identifiers are used when requesting handles, but all resources are stored in a vector and each handle only contains resource's index in that vector) Resource<T>: The handles given out from ResourceCache. The handles are reference counted and to get the underlying resource you simply deference like with pointers (*handle).  
      And my plan is to define everything into these XML documents to abstract away files:
      Resources.xml for ref-counted GPU resources (geometry, shaders, textures) Resources are assigned names/ids and resource files, and possibly some attributes (what vertex attributes does this geometry have? what vertex attributes does this shader expect? what uniforms does this shader use? and so on) Are reference counted using ResourceCache<T> Assets.xml for assets using the GPU resources (materials, meshes, models) Assets are not reference counted, but they hold handles to ref-counted resources. References the resources defined in Resources.xml by names/ids. The XMLs are loaded into some structure in memory which is then used for loading the resources/assets using factory classes:
      Factory classes for resources:
      For example, a texture factory could contain the texture definitions from the XML containing data about textures in the game, as well as a cache containing all loaded textures. This means it has mappings from each name/id to a file and when asked to load a texture with a name/id, it can look up its path and use a "BinaryLoader" to either load the file and create the resource directly, or asynchronously load the file's data into a queue which then can be read from later to create the resources synchronously in the GL context. These factories only return handles.
      Factory classes for assets:
      Much like for resources, these classes contain the definitions for the assets they can load. For example, with the definition the MaterialFactory will know which shader, textures and possibly uniform a certain material has, and with the help of TextureFactory and ShaderFactory, it can retrieve handles to the resources it needs (Shader + Textures), setup itself from XML data (uniform values), and return a created instance of requested material. These factories return actual instances, not handles (but the instances contain handles).
       
       
      Is this a good or commonly used approach? Is this going to bite me in the ass later on? Are there other more preferable approaches? Is this outside of the scope of a 3d renderer and should be on the engine side? I'd love to receive and kind of advice or suggestions!
      Thanks!
    • By nedondev
      I 'm learning how to create game by using opengl with c/c++ coding, so here is my fist game. In video description also have game contain in Dropbox. May be I will make it better in future.
      Thanks.
    • By Abecederia
      So I've recently started learning some GLSL and now I'm toying with a POM shader. I'm trying to optimize it and notice that it starts having issues at high texture sizes, especially with self-shadowing.
      Now I know POM is expensive either way, but would pulling the heightmap out of the normalmap alpha channel and in it's own 8bit texture make doing all those dozens of texture fetches more cheap? Or is everything in the cache aligned to 32bit anyway? I haven't implemented texture compression yet, I think that would help? But regardless, should there be a performance boost from decoupling the heightmap? I could also keep it in a lower resolution than the normalmap if that would improve performance.
      Any help is much appreciated, please keep in mind I'm somewhat of a newbie. Thanks!
    • By test opty
      Hi,
      I'm trying to learn OpenGL through a website and have proceeded until this page of it. The output is a simple triangle. The problem is the complexity.
      I have read that page several times and tried to analyse the code but I haven't understood the code properly and completely yet. This is the code:
       
      #include <glad/glad.h> #include <GLFW/glfw3.h> #include <C:\Users\Abbasi\Desktop\std_lib_facilities_4.h> using namespace std; //****************************************************************************** void framebuffer_size_callback(GLFWwindow* window, int width, int height); void processInput(GLFWwindow *window); // settings const unsigned int SCR_WIDTH = 800; const unsigned int SCR_HEIGHT = 600; const char *vertexShaderSource = "#version 330 core\n" "layout (location = 0) in vec3 aPos;\n" "void main()\n" "{\n" " gl_Position = vec4(aPos.x, aPos.y, aPos.z, 1.0);\n" "}\0"; const char *fragmentShaderSource = "#version 330 core\n" "out vec4 FragColor;\n" "void main()\n" "{\n" " FragColor = vec4(1.0f, 0.5f, 0.2f, 1.0f);\n" "}\n\0"; //******************************* int main() { // glfw: initialize and configure // ------------------------------ glfwInit(); glfwWindowHint(GLFW_CONTEXT_VERSION_MAJOR, 3); glfwWindowHint(GLFW_CONTEXT_VERSION_MINOR, 3); glfwWindowHint(GLFW_OPENGL_PROFILE, GLFW_OPENGL_CORE_PROFILE); // glfw window creation GLFWwindow* window = glfwCreateWindow(SCR_WIDTH, SCR_HEIGHT, "My First Triangle", nullptr, nullptr); if (window == nullptr) { cout << "Failed to create GLFW window" << endl; glfwTerminate(); return -1; } glfwMakeContextCurrent(window); glfwSetFramebufferSizeCallback(window, framebuffer_size_callback); // glad: load all OpenGL function pointers if (!gladLoadGLLoader((GLADloadproc)glfwGetProcAddress)) { cout << "Failed to initialize GLAD" << endl; return -1; } // build and compile our shader program // vertex shader int vertexShader = glCreateShader(GL_VERTEX_SHADER); glShaderSource(vertexShader, 1, &vertexShaderSource, nullptr); glCompileShader(vertexShader); // check for shader compile errors int success; char infoLog[512]; glGetShaderiv(vertexShader, GL_COMPILE_STATUS, &success); if (!success) { glGetShaderInfoLog(vertexShader, 512, nullptr, infoLog); cout << "ERROR::SHADER::VERTEX::COMPILATION_FAILED\n" << infoLog << endl; } // fragment shader int fragmentShader = glCreateShader(GL_FRAGMENT_SHADER); glShaderSource(fragmentShader, 1, &fragmentShaderSource, nullptr); glCompileShader(fragmentShader); // check for shader compile errors glGetShaderiv(fragmentShader, GL_COMPILE_STATUS, &success); if (!success) { glGetShaderInfoLog(fragmentShader, 512, nullptr, infoLog); cout << "ERROR::SHADER::FRAGMENT::COMPILATION_FAILED\n" << infoLog << endl; } // link shaders int shaderProgram = glCreateProgram(); glAttachShader(shaderProgram, vertexShader); glAttachShader(shaderProgram, fragmentShader); glLinkProgram(shaderProgram); // check for linking errors glGetProgramiv(shaderProgram, GL_LINK_STATUS, &success); if (!success) { glGetProgramInfoLog(shaderProgram, 512, nullptr, infoLog); cout << "ERROR::SHADER::PROGRAM::LINKING_FAILED\n" << infoLog << endl; } glDeleteShader(vertexShader); glDeleteShader(fragmentShader); // set up vertex data (and buffer(s)) and configure vertex attributes float vertices[] = { -0.5f, -0.5f, 0.0f, // left 0.5f, -0.5f, 0.0f, // right 0.0f, 0.5f, 0.0f // top }; unsigned int VBO, VAO; glGenVertexArrays(1, &VAO); glGenBuffers(1, &VBO); // bind the Vertex Array Object first, then bind and set vertex buffer(s), //and then configure vertex attributes(s). glBindVertexArray(VAO); glBindBuffer(GL_ARRAY_BUFFER, VBO); glBufferData(GL_ARRAY_BUFFER, sizeof(vertices), vertices, GL_STATIC_DRAW); glVertexAttribPointer(0, 3, GL_FLOAT, GL_FALSE, 3 * sizeof(float), (void*)0); glEnableVertexAttribArray(0); // note that this is allowed, the call to glVertexAttribPointer registered VBO // as the vertex attribute's bound vertex buffer object so afterwards we can safely unbind glBindBuffer(GL_ARRAY_BUFFER, 0); // You can unbind the VAO afterwards so other VAO calls won't accidentally // modify this VAO, but this rarely happens. Modifying other // VAOs requires a call to glBindVertexArray anyways so we generally don't unbind // VAOs (nor VBOs) when it's not directly necessary. glBindVertexArray(0); // uncomment this call to draw in wireframe polygons. //glPolygonMode(GL_FRONT_AND_BACK, GL_LINE); // render loop while (!glfwWindowShouldClose(window)) { // input // ----- processInput(window); // render // ------ glClearColor(0.2f, 0.3f, 0.3f, 1.0f); glClear(GL_COLOR_BUFFER_BIT); // draw our first triangle glUseProgram(shaderProgram); glBindVertexArray(VAO); // seeing as we only have a single VAO there's no need to // bind it every time, but we'll do so to keep things a bit more organized glDrawArrays(GL_TRIANGLES, 0, 3); // glBindVertexArray(0); // no need to unbind it every time // glfw: swap buffers and poll IO events (keys pressed/released, mouse moved etc.) glfwSwapBuffers(window); glfwPollEvents(); } // optional: de-allocate all resources once they've outlived their purpose: glDeleteVertexArrays(1, &VAO); glDeleteBuffers(1, &VBO); // glfw: terminate, clearing all previously allocated GLFW resources. glfwTerminate(); return 0; } //************************************************** // process all input: query GLFW whether relevant keys are pressed/released // this frame and react accordingly void processInput(GLFWwindow *window) { if (glfwGetKey(window, GLFW_KEY_ESCAPE) == GLFW_PRESS) glfwSetWindowShouldClose(window, true); } //******************************************************************** // glfw: whenever the window size changed (by OS or user resize) this callback function executes void framebuffer_size_callback(GLFWwindow* window, int width, int height) { // make sure the viewport matches the new window dimensions; note that width and // height will be significantly larger than specified on retina displays. glViewport(0, 0, width, height); } As you see, about 200 lines of complicated code only for a simple triangle. 
      I don't know what parts are necessary for that output. And also, what the correct order of instructions for such an output or programs is, generally. That start point is too complex for a beginner of OpenGL like me and I don't know how to make the issue solved. What are your ideas please? What is the way to figure both the code and the whole program out correctly please?
      I wish I'd read a reference that would teach me OpenGL through a step-by-step method. 
  • Popular Now