Quote:and instead of saying "this is a perfect example of how not to do something. why dont you give the right example.

I was talking about simon10k's code, and I don't think I need to provide an example of how to read data from a file into a buffer.

Quote:Original post by donjonson
Thaks for all your help.

and yes I am trying to count the characters in the file.

and it works perfectly.

By the way, you still have a couple of subtle bugs, that you may never notice but I'll share anyway.

.get can return EOF, as I said earlier. However, by that point you have already read in that value, and you'd try to count it in your array, which is not generally what you want to do.

Also, because you cast the value to an unsigned char, there is no point comparing them against 256, because every unsigned char is less than 256. So your if statement achieves nothing. One better way to write such a loop would be like so:


Note that I also changed it to use pre-increment instead of post-increment. It's a good habit to get into using pre-increment where possible because it can be quicker than post-increment on some objects.