Sign in to follow this  
Zorbfish

OpenGL Multithreaded OpenGL problem (Win32)

Recommended Posts

Zorbfish    214
#include <windows.h>

HWND hWnd = 0;
BOOL done = FALSE;

LRESULT WinProc(HWND hWnd, UINT Msg, WPARAM wParam, LPARAM lParam) {
   switch (Msg) {
      
      /* Ignore paint messages */
      case WM_PAINT:
      case WM_ERASEBKGND:
         return 0;
      
      case WM_DESTROY:
         PostQuitMessage(0);
         break;
   }
   
   return DefWindowProc(hWnd, Msg, wParam, lParam);
}

/* Creates a GL context attached to the window owned
   by the other thread and paints the client area blue */

DWORD GLThread(LPVOID lpParams) {
   PIXELFORMATDESCRIPTOR pfd = {0};
   HDC hDC = GetDC(hWnd);
   HGLRC hRC = 0;
   
   /* Set absolute minimum format attributes; i.e. select default mode */
   pfd.nSize = sizeof(PIXELFORMATDESCRIPTOR);
   pfd.nVersion = 1;
   pfd.dwFlags = PFD_DRAW_TO_WINDOW | PFD_SUPPORT_OPENGL | PFD_DOUBLEBUFFER;
   pfd.iPixelType = PFD_TYPE_RGBA;
   
   SetPixelFormat(hDC, ChoosePixelFormat(hDC, &pfd), &pfd);
   
   hRC = wglCreateContext(hDC);
   wglMakeCurrent(hDC, hRC);
   
   glClearColor(0.0f, 0.0f, 1.0f, 0.0f);
   
   while (!done) {
      glClear(GL_COLOR_BUFFER_BIT);
      SwapBuffers(hDC);
      
      /* Yield to other threads */
      Sleep(0);
   }
   
   return 0;
}

INT WINAPI WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpCmdLine, INT nShowCmd) {
   WNDCLASSEX wcx = {0};
   HANDLE hThread = 0;
   DWORD iThread = 0;
   DWORD wait = 0;
   MSG msg = {0};
   
   wcx.cbSize = sizeof(WNDCLASSEX);
   wcx.style = CS_OWNDC | CS_VREDRAW | CS_HREDRAW;
   wcx.lpfnWindowProc = WinProc;
   wcx.hInstance = hInstance;
   wcx.lpszClassName = "MTGL";
   /* No background brush */
   
   hWnd = CreateWindowEx(WS_EX_APPWINDOW, wcx.lpszClassName, "Untitled",
      WS_OVERLAPPEDWINDOW | WS_CLIPCHILDREN | WS_CLIPSIBLINGS, 0, 0, 320,
      240, 0, 0, hInstance, 0);
   
   ShowWindow(hWnd, nShowCmd);
   
   /* Start OpenGL */
   hThread = CreateThread(0, 0, GLThread, 0, &iThread);
   
   while (!done) {
      if (GetMessage(&msg, 0, 0) > 0) {
         DispatchMessage(&msg);
      } else {
         done = TRUE;
      }
   }
   
   return (INT)msg.wParam;
}

I'm trying to run my game logic in a different thread from the Win32 message pump so that my game doesn't stall when a message is being processed by Windows. I've been reading up on multithreading OpenGL but I am running into a problem. The above code has a race condition. I can easily cause the host window to become hung if I resize or move it quickly across the screen. The window will then stop responding and the mouse cursor will not hover over the taskbar. I have to open up the task manager and kill it manually. I can fix the problem if I introduce synchronization through a mutex or event object around the OpenGL and message pump code. I suspect there's something going on under the hood that's causing the problem (GDI, window handle, etc). I defeat the purpose behind using the two threads in the first place by synchornizing them since the mutex would not be released until a message is processed. I've been trying to troubleshoot this for a couple of days now but the information on the net is sparse at best. I've read the few posts in this forum about multithread OpenGL but none of them seem to address this issue. Any help would be appreciated.

Share this post


Link to post
Share on other sites
Mike2343    1202
Few things I noticed.

A) You're recreating the pixel format each time, this is just a MAJOR waste of processing cycles. I set it once and forget it until something changes with the window (like resizing, etc).

B) I call my rendering loop in my while (!done) message pump, like I see most people do. I multithread things like AI, audio, resource loading, scene graph, etc. But not my rendering loop.

Now, have you worked with multithreading a lot before? Just wondering because if you haven't you might want to start off a bit simpler. Remember, rendering the scene is the last thing to happen and normally is the least amount of work (AI, scene graph, physics, collision detection all take a lot more CPU cycles).

Share this post


Link to post
Share on other sites
udaykv    126
When it goes into race, try breaking into the application and check the stack trace. Also, try syncing SwapBuffers call with DispatchMessage.

Share this post


Link to post
Share on other sites
Zorbfish    214
Sorry to those who responded that I never got back to.

Mike2343
A) No. The pixelformat is created just once and then for the remainder of the thread it executes inside the while block.

B) I'm simply interested in finding out why it was racing.

And yes I do have multithreading experience under my belt.

udaykv:
I had tried that but when the problem occurs Windows stop working. About the only thing I can do is bring up the taskmanager and kill the application.

phantom:
I thought GetMessage automatically blocks when there is no message queued (maybe I read the msdn docs wrong). I changed it to use MsgWaitForMultipleObjects instead.

Ultimately I did find a solution that works from what I have tested. I finally tracked the problem down to the window's HDC object. Apparently the main thread and the OpenGL thread began to race for control of the DC and every once and awhile they ran into each other. It was happening when the window tried to process a WM_NCPAINT message to redraw the frame of its window while the OpenGL thread was trying to draw in the client area using the same DC. So far by just synchronizing the DC I have not run into anymore problems.

If anyone is interested I'll post the code as soon as I clean it up.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Similar Content

    • By povilaslt2
      Hello. I'm Programmer who is in search of 2D game project who preferably uses OpenGL and C++. You can see my projects in GitHub. Project genre doesn't matter (except MMO's :D).
    • By ZeldaFan555
      Hello, My name is Matt. I am a programmer. I mostly use Java, but can use C++ and various other languages. I'm looking for someone to partner up with for random projects, preferably using OpenGL, though I'd be open to just about anything. If you're interested you can contact me on Skype or on here, thank you!
      Skype: Mangodoor408
    • By tyhender
      Hello, my name is Mark. I'm hobby programmer. 
      So recently,I thought that it's good idea to find people to create a full 3D engine. I'm looking for people experienced in scripting 3D shaders and implementing physics into engine(game)(we are going to use the React physics engine). 
      And,ye,no money =D I'm just looking for hobbyists that will be proud of their work. If engine(or game) will have financial succes,well,then maybe =D
      Sorry for late replies.
      I mostly give more information when people PM me,but this post is REALLY short,even for me =D
      So here's few more points:
      Engine will use openGL and SDL for graphics. It will use React3D physics library for physics simulation. Engine(most probably,atleast for the first part) won't have graphical fron-end,it will be a framework . I think final engine should be enough to set up an FPS in a couple of minutes. A bit about my self:
      I've been programming for 7 years total. I learned very slowly it as "secondary interesting thing" for like 3 years, but then began to script more seriously.  My primary language is C++,which we are going to use for the engine. Yes,I did 3D graphics with physics simulation before. No, my portfolio isn't very impressive. I'm working on that No,I wasn't employed officially. If anybody need to know more PM me. 
       
    • By Zaphyk
      I am developing my engine using the OpenGL 3.3 compatibility profile. It runs as expected on my NVIDIA card and on my Intel Card however when I tried it on an AMD setup it ran 3 times worse than on the other setups. Could this be a AMD driver thing or is this probably a problem with my OGL code? Could a different code standard create such bad performance?
    • By Kjell Andersson
      I'm trying to get some legacy OpenGL code to run with a shader pipeline,
      The legacy code uses glVertexPointer(), glColorPointer(), glNormalPointer() and glTexCoordPointer() to supply the vertex information.
      I know that it should be using setVertexAttribPointer() etc to clearly define the layout but that is not an option right now since the legacy code can't be modified to that extent.
      I've got a version 330 vertex shader to somewhat work:
      #version 330 uniform mat4 osg_ModelViewProjectionMatrix; uniform mat4 osg_ModelViewMatrix; layout(location = 0) in vec4 Vertex; layout(location = 2) in vec4 Normal; // Velocity layout(location = 3) in vec3 TexCoord; // TODO: is this the right layout location? out VertexData { vec4 color; vec3 velocity; float size; } VertexOut; void main(void) { vec4 p0 = Vertex; vec4 p1 = Vertex + vec4(Normal.x, Normal.y, Normal.z, 0.0f); vec3 velocity = (osg_ModelViewProjectionMatrix * p1 - osg_ModelViewProjectionMatrix * p0).xyz; VertexOut.velocity = velocity; VertexOut.size = TexCoord.y; gl_Position = osg_ModelViewMatrix * Vertex; } What works is the Vertex and Normal information that the legacy C++ OpenGL code seem to provide in layout location 0 and 2. This is fine.
      What I'm not getting to work is the TexCoord information that is supplied by a glTexCoordPointer() call in C++.
      Question:
      What layout location is the old standard pipeline using for glTexCoordPointer()? Or is this undefined?
       
      Side note: I'm trying to get an OpenSceneGraph 3.4.0 particle system to use custom vertex, geometry and fragment shaders for rendering the particles.
  • Popular Now