Jacks or Better Program

Danikar · 2006-03-30T23:11:42

I am reading the book Beginning C++ Game Programing. And from what I have learned so far I think I should be able to write this program. Just run into a little road block. I can make it deal to a hand from a deck and also discard cards and redraw cards. But analizing the hand is where I am having an issue. I kind of got an Idea of how to see if there is a flush but anything else seems a little hard lol. Anyone have any ideas how I can achieve my goal. (Analyzing a hand) Or any other advice would be greatly appreciated. Thanks! /* Jacks Or Better */ #include <iostream> #include <string> #include <vector> #include <algorithm> #include <ctime> #include <cctype> using namespace std; int main() { //Creating Deck string value[13] = { "A", "2", "3", "4", "5", "6", "7", "8", "9", "T", "J", "Q", "K" }; string suite[4] = { "h", "s", "c", "d" }; vector<string> deck; vector<string> hand; for(int x = 0; x != 13; ++x) { for(int i = 0; i != 4; ++i) { deck.push_back(value[x] + suite); } } //Shuffling Deck srand(time(0)); for(int x = 0; x != 52; ++x){ int index1 = (rand() % 52); int index2 = (rand() % 52); string temp; temp = deck[index1]; deck[index1] = deck[index2]; deck[index2] = temp; } //Drawing Cards from deck const int CARDS_IN_HAND = 5; for(int x = 0; x != CARDS_IN_HAND; ++x) { hand.push_back(deck[0]); deck.erase(deck.begin()); } //Show Cards for(int x = 0; x != 5; ++x) { cout << hand[x] << " "; } cout << endl; cout << endl; for(int x = 0; x != 47; ++x) { cout << deck[x] << " "; if((x+1) % 5 == 0) { cout << endl; } } //Ask if want to discard and Draw new card when appropriate string discard; cout << "\n\nDo you want to keep? (y/n)" << endl; for(int x = 0; x!= CARDS_IN_HAND; ++x) { cout << "Card " << x+1 << ": "; cin >> discard[x]; while(discard[x] != 'y' && discard[x] != 'n') { cout << "Card " << x+1 << ": "; cin >> discard[x]; } if(discard[x] == 'n') { hand[x] = deck[0]; deck.erase(deck.begin()); } } //Show new Hand cout << endl; for(int x = 0; x != 5; ++x) { cout << hand[x] << " "; } /* bool pair = false; //pair pays nothing bool jorb = false; //jacks or better pays 1x bool twopair = false; //Two Pair pays 2x bool threekind = false; //Three of a Kind pays 3x bool straight = false; //Straight pays 4x bool flush = false; //Flush pays 5x bool fullhouse = false; //Full House pays 10x bool straightflush = false; //Straight Flush pays 50x bool royalflush = false; //Royal Flush pays 100x //Checks For Flush if(hand[0][1] == hand[1][1], hand[0][1] == hand[2][1], hand[0][1] == hand[3][1], hand[0][1] == hand[4][1]) { flush == true; } //checks For Straight //checks For Pair hand.find(hand[0][0], 1) */ return 0; } [Edited by - Danikar on March 29, 2006 4:51:50 PM]

For Beginners

Started by Danikar March 29, 2006 04:02 PM

19 comments, last by JohnBolton 18 years ago

nomichi

211

March 29, 2006 06:51 PM

Quote:Original post by Danikar
Yeah if u want to send that to me that would be cool. I always like looking over other peoples code.

I PM'd it to ya. hope it helps.

Regards,nomichi

TANSTAAFL

1,160

March 29, 2006 07:09 PM

Quote:Original post by Lothia
Tan that confuses the hell out of me. How does that prove they are flush if 5 is the highest? Could it not be you have, Ace, ace, Queen, Jack, and 10. And that 10 would make it a 5. Or maybe i just get the concept. It seems that you are doing a check high and low, but the low is really the high (ace) and ur high is really your low (two) Maybe it's the enum.. I have never heard of it.

that's checking the SUITS array, not the RANKS array. if you get 5 cards of the same suit, it MUST be a flush or a straight flush, and the ranks array does not matter, as it will have no number higher than 1 in it, provided a single deck.

also, i set the initial value for the high value to the lowest value and the initial value for the low value to the highest value because it guarantees that it will be set to the correct value while the cards are being evaluated.

i'm going to be going home shortly, and I'll write up code that'll do this....

Get off my lawn!

Lothia

102

March 29, 2006 07:30 PM

Thank you Tan. That would be great to see the code, and now I actually get that part. I guess I was getting confused for something really trivial.

TANSTAAFL

1,160

March 29, 2006 09:19 PM

It'll compile, but it hasn't been tested. Provided as-is, to be use by whomever for whatever. Corrections for deficiencies welcome.

enum rank_t{	RANK_TWO,	RANK_THREE,	RANK_FOUR,	RANK_FIVE,	RANK_SIX,	RANK_SEVEN,	RANK_EIGHT,	RANK_NINE,	RANK_TEN,	RANK_JACK,	RANK_QUEEN,	RANK_KING,	RANK_ACE,	RANK_COUNT,	RANK_FIRST=RANK_TWO};enum suit_t{	SUIT_CLUBS,	SUIT_HEARTS,	SUIT_SPADES,	SUIT_DIAMONDS,	SUIT_COUNT,	SUIT_FIRST=SUIT_CLUBS};enum handvalue_t{	HANDVALUE_INVALID,	HANDVALUE_JUNK,	HANDVALUE_ONEPAIR,	HANDVALUE_ONEPAIRJACKSORBETTER,	HANDVALUE_TWOPAIR,	HANDVALUE_THREEOFAKIND,	HANDVALUE_STRAIGHT,	HANDVALUE_FLUSH,	HANDVALUE_FULLHOUSE,	HANDVALUE_FOUROFAKIND,	HANDVALUE_STRAIGHTFLUSH,	HANDVALUE_ROYALFLUSH,};enum{	HAND_CARDCOUNT = 5};struct card_t{	rank_t rank;	suit_t suit;};struct hand_t{	card_t cards[HAND_CARDCOUNT];};handvalue_t getHandValue(const hand_t& theHand){	handvalue_t result=HANDVALUE_INVALID;		int cardRanks[RANK_COUNT]={0};	int cardSuits[SUIT_COUNT]={0};	rank_t rankHigh=RANK_TWO;	rank_t rankLow=RANK_ACE;	int validCards=0;	for(int cardIndex=0;cardIndex<HAND_CARDCOUNT;++cardIndex)	{		bool cardIsValid=false;		if((theHand.cards[cardIndex].rank<RANK_COUNT)&&(theHand.cards[cardIndex].suit<SUIT_COUNT))		{			bool foundDuplicate=false;			for(int otherCardIndex=cardIndex+1;otherCardIndex<HAND_CARDCOUNT;++otherCardIndex)			{				if((theHand.cards[cardIndex].rank==theHand.cards[otherCardIndex].rank)&&(theHand.cards[cardIndex].suit==theHand.cards[otherCardIndex].suit))				{					foundDuplicate=true;				}				if(!foundDuplicate)				{					cardIsValid=true;				}			}		}		if(cardIsValid)		{			validCards++;			cardRanks[theHand.cards[cardIndex].rank]++;			cardSuits[theHand.cards[cardIndex].suit]++;			if(theHand.cards[cardIndex].rank>rankHigh)			{				rankHigh=theHand.cards[cardIndex].rank;			}			if(theHand.cards[cardIndex].rank<rankLow)			{				rankLow=theHand.cards[cardIndex].rank;			}		}	}	if(HAND_CARDCOUNT==validCards)	{		for(int suitIndex=SUIT_FIRST;(result==HANDVALUE_INVALID)&&(suitIndex<SUIT_COUNT);++suitIndex)		{			if(HAND_CARDCOUNT==cardSuits[suitIndex])			{				result=HANDVALUE_FLUSH;			}		}		if(HANDVALUE_FLUSH==result)		{			if((HAND_CARDCOUNT-1)==(rankHigh-rankLow))			{				if(cardRanks[RANK_ACE])				{					result=HANDVALUE_ROYALFLUSH;				}				else				{					result=HANDVALUE_STRAIGHTFLUSH;				}			}			else if(cardRanks[RANK_TWO]&&cardRanks[RANK_THREE]&&cardRanks[RANK_FOUR]&&cardRanks[RANK_FIVE]&&cardRanks[RANK_ACE])			{				result=HANDVALUE_STRAIGHTFLUSH;			}		}		else		{			bool fourOfAKind=false;			bool threeOfAKind=false;			int pairCount=0;			bool jacksOrBetter=false;			for(int rankIndex=0;(!fourOfAKind)&&(rankIndex<RANK_COUNT);++rankIndex)			{				switch(cardRanks[rankIndex])				{				case 4:					{						fourOfAKind=true;					}break;				case 3:					{						threeOfAKind=true;					}break;				case 2:					{						pairCount++;						if(rankIndex>=RANK_JACK)						{							jacksOrBetter=true;						}					}break;				}			}			if(fourOfAKind)			{				result=HANDVALUE_FOUROFAKIND;			}			else if(threeOfAKind)			{				if(pairCount)				{					result=HANDVALUE_FULLHOUSE;				}				else				{					result=HANDVALUE_THREEOFAKIND;				}			}			else			{				switch(pairCount)				{				case 2:					{						result=HANDVALUE_TWOPAIR;					}break;				case 1:					{						if(jacksOrBetter)						{							result=HANDVALUE_ONEPAIRJACKSORBETTER;						}						else						{							result=HANDVALUE_ONEPAIR;						}					}break;				case 0:					{						if((HAND_CARDCOUNT-1)==(rankHigh-rankLow))						{							result=HANDVALUE_STRAIGHT;						}						else if(cardRanks[RANK_TWO]&&cardRanks[RANK_THREE]&&cardRanks[RANK_FOUR]&&cardRanks[RANK_FIVE]&&cardRanks[RANK_ACE])						{							result=HANDVALUE_STRAIGHT;						}						else						{							result=HANDVALUE_JUNK;						}					}break;				}			}		}	}	return(result);}

Get off my lawn!

Cosmic R

159

March 29, 2006 09:56 PM

just wondering why do you check if each card is valid first? wouldnt the deal function assure that the player is only handed valid cards?

TANSTAAFL

1,160

March 29, 2006 10:34 PM

Always assume invalid input until you are certain otherwise...

Get off my lawn!

Lothia

102

March 30, 2006 01:33 AM

Can you explain what a enum is? It seems to me its a struct.

Riekistyx

100

March 30, 2006 02:06 AM

Heres a little thing you should try which you might find interesting

for(char i = 3; i<7; i++)
cout << i;

whoa wasnt that cool? Now to make it easy for you

string typestr = string(char(3));