Sign in to follow this  
Taymo

OpenGL SDL_Surface to OGL texture

Recommended Posts

Ok so I am using SDL for my OGL implementation cause it's way easyer. I'm using SDL_image to load a JPG into a SDL_Surface and them load that into a OGL texture object. Once I got it down and it didn't work I did some research and it seems that my implementation should work. The img loading routine is LoadTextures althought I don't think that it is the problem. Heres the WHOLE program. It's not that long. See anything wrong?
#pragma comment(lib,"sdlmain.lib")
#pragma comment(lib,"sdl.lib")
#pragma comment(lib, "OpenGL32.lib")
#pragma comment(lib, "GLu32.lib")
#pragma comment(lib, "SDL_Image/SDL_image.lib")

#include "SDL_image.h"
#include <sdl.h>
#include <sdl_opengl.h>

SDL_Surface *g_screen;
SDL_Surface *mobo;

bool quit_app = 0;
int bpp;
GLuint texture_one;

void LoadTextures()
{
        //TEST
        glEnable(GL_TEXTURE_2D);
        mobo = IMG_Load("test.jpg");
        if(mobo)
        {
                glGenTextures(1,&texture_one);
                glBindTexture(GL_TEXTURE_2D,texture_one);

                SDL_LockSurface(mobo);

                glTexImage2D(GL_TEXTURE_2D, 3, 3, mobo->w, mobo->h, 0 , GL_RGB, GL_UNSIGNED_BYTE, mobo->pixels);

                SDL_UnlockSurface(mobo);
                SDL_FreeSurface(mobo);

                glTexParameteri(GL_TEXTURE_2D,GL_TEXTURE_MIN_FILTER,GL_LINEAR_MIPMAP_NEAREST);
                glTexParameteri(GL_TEXTURE_2D,GL_TEXTURE_MAG_FILTER,GL_LINEAR_MIPMAP_LINEAR);
        }
        else
        {
                printf("IMG_Load: %s\n", IMG_GetError());
        }
}

bool InitSDL()
{
        if(SDL_Init(SDL_INIT_VIDEO))
        {
                printf("Couldn't initalize SDL!");
                return 0;
        }

        SDL_GL_SetAttribute(SDL_GL_RED_SIZE, 8);
        SDL_GL_SetAttribute(SDL_GL_GREEN_SIZE, 8);
        SDL_GL_SetAttribute(SDL_GL_BLUE_SIZE, 8);
        SDL_GL_SetAttribute(SDL_GL_DEPTH_SIZE, 16);
        SDL_GL_SetAttribute(SDL_GL_DOUBLEBUFFER, 1);


        if((g_screen = SDL_SetVideoMode(640,480,32,SDL_OPENGL)) == NULL)
        {
                printf("Couldn't set video mode! Quitting...");
                SDL_Quit();     
                return 0;
        }
        return 1;
}

void SetupProjection(int width, int height)
{
        if(height == 0)
        {
                height = 1;
        }

        glViewport(0,0,width,height); //Reset viewport to new dimensions
        glMatrixMode(GL_PROJECTION);  //set the current matrix to projection
        glLoadIdentity(); // reset projection matrix
       
        //Calculate aspect ratio of window
        gluPerspective(52.0f,(GLfloat)width/(GLfloat)height,1.0f,1000.0f);

        glMatrixMode(GL_MODELVIEW); //set modelview matrix
        glLoadIdentity();   //reset modelview matrix
}

bool InitOGL()
{
        SetupProjection(640,480);
        glEnable(GL_DEPTH_TEST);
        return true;

}       

void RenderScene()
{
        //clear screen and depth buffer
        glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);          // Clear The Screen And The Depth Buffer
        glLoadIdentity();                            // Reset The View

        glTranslatef(-1.5f,0.0f,-6.0f);  // Move Left 1.5 Units And Into The Screen 6.0

        // draw a triangle
        glBegin(GL_POLYGON);                // start drawing a polygon
        glVertex3f( 0.0f, 1.0f, 0.0f);    // Top
        glVertex3f( 1.0f,-1.0f, 0.0f);    // Bottom Right
        glVertex3f(-1.0f,-1.0f, 0.0f);    // Bottom Left   
        glEnd();                                        // we're done with the polygon

        glTranslatef(3.0f,0.0f,0.0f);              // Move Right 3 Units

        glEnable( GL_TEXTURE_2D );
        glBindTexture( GL_TEXTURE_2D, texture_one );
   
        // draw a square (quadrilateral)
        glBegin(GL_QUADS);                 
        glTexCoord2f(0.0,0.0); glVertex2f(-1.0f, 1.0f);  
        glTexCoord2f(0.0,1.0); glVertex2f( 1.0f, 1.0f);  
        glTexCoord2f(1.0,1.0); glVertex2f( 1.0f,-1.0f);  
        glTexCoord2f(0.0,1.0); glVertex2f(-1.0f,-1.0f);  
        glEnd();       

        // swap buffers to display, since we're double buffered.
        SDL_GL_SwapBuffers();
}


int main(int argv, char **argc)
{
        InitSDL();
        InitOGL();
        LoadTextures();
        unsigned char* keys = 0;
       
        while(!quit_app)
        {
                RenderScene();
                SDL_Event event;
                while ( SDL_PollEvent(&event) )
                {
                        if ( event.type == SDL_QUIT )
                        {
                                quit_app = 1;
                        }
                        if ( event.type == SDL_KEYDOWN )
                        {
                                if ( event.key.keysym.sym == SDLK_ESCAPE )
                                {
                                        quit_app = 1;
                                }
                        }
                }

        }
        SDL_FreeSurface(g_screen);
        SDL_Quit();

        return 0;
}

Share this post


Link to post
Share on other sites
Yes 256x256 and it is in the right place. I know it's being loaded becuase I null cheak it and if it wasn't SDL would deploy it's parachute for me trying to access mobo->pixels when theres nothing there. That was happening before.

Share this post


Link to post
Share on other sites
Quote:
Original post by Taymo
glTexImage2D(GL_TEXTURE_2D, 3, 3, mobo->w, mobo->h, 0 , GL_RGB, GL_UNSIGNED_BYTE, mobo->pixels);

You have (mistakenly, I think) set the lod parameter of glTexImage2D to 3. Set that as 0, unless you are planning to supply a complete set of mipmaps.

Share this post


Link to post
Share on other sites
Yeah, I just tested it out on my framework - setting an incorrect mipmap value will cause it to fail completely. I had assumed that it would just make the texture weird.

You might want to look into gluBuild2DMipMaps. gluBuild2DMipMaps will also convert non-power-of-2 textures to the correct dimensions.

An additional (possible) problem is the pixel format of the surface. I'm not sure how IMG_Load creates an image, but you may want to convert it to a specific format to guarentee you're using RGB. I've had weird stuff happen before, like SDL_LoadBMP returning a BGR texture, or it having an alpha value or something.

Share this post


Link to post
Share on other sites
True words by Mushu.

You are also explicitly providing GL_RGB for the dataformat. You should check the number of bits perpixel in the SDL_Surface before providing it like that. I believe the SDL_Surface struct has a member value that contains this information. If 32 -> GL_RGBA, if 24 -> GL_RGB etc. It isn't a problem with jpg images though, always 24 bit AFAIK.

You may want to use gluBuild2DMipmaps as Mushu suggested, but if you don't make sure you don't set mipmap filtering with glTexParameter, use linear filtering instead.

Share this post


Link to post
Share on other sites
Here's what I use:

	if(image->format->BitsPerPixel==32)
{
glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, image->w, image->h,
0, GL_RGBA, GL_UNSIGNED_BYTE, image->pixels);
}
else
{
glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, image->w, image->h,
0, GL_BGR, GL_UNSIGNED_BYTE, image->pixels);
}


In this, image is an SDL_surface loaded with IMG_Load(). I haven't tested this with every file format, but it works fine for me when I use bitmaps, tgas, and pngs. Its basically doing what Deavik said.

And if you want to display your source code(especially when its as long as that!), try using the [ source ] and [ /source ] tags around your code(without the spaces). It will format your code nicely.

Share this post


Link to post
Share on other sites
You can convert any surface to a specific format (and set a colorkey) using the following method (there are others) -
  1. Load the surface.
  2. Create a new RGB surface with the desired format.
  3. Fill the new surface with pure alpha.
  4. Set the desired colorkey on the loaded surface.
  5. Blit the loaded surface onto the new surface.
  6. Convert the new surface to an OpenGL texture.
  7. Free both surfaces.

Code dump -
SDL_Surface* surf = SDL_LoadBMP( filename.c_str() );

if ( !surf ) {
OGLGfxAdapter::TextureType ret;
ret.tex = 0;
ret.w = 0;
ret.h = 0;

return ret;
}

SDL_Surface* dest = SDL_CreateRGBSurface( SDL_HWSURFACE, surf->w, surf->h,
32,
#if SDL_BYTEORDER == SDL_LIL_ENDIAN // OpenGL RGBA masks
0x000000FF,
0x0000FF00,
0x00FF0000,
0xFF000000
#else
0xFF000000,
0x00FF0000,
0x0000FF00,
0x000000FF
#endif
);


SDL_FillRect( dest, NULL, SDL_MapRGBA( dest->format, 0, 0, 0, SDL_ALPHA_TRANSPARENT ) );

SDL_SetColorKey( surf, SDL_SRCCOLORKEY, SDL_MapRGB( surf->format, (Uint8)colorkey.r, (Uint8)colorkey.g, (Uint8)colorkey.b ) );
SDL_BlitSurface( surf, NULL, dest, NULL );

The key is that SDL will internally "do the right stuff" with the surface formats when blitting. You can also use SDL_ConvertSurface to create a new surface with a specific pixel format, but I like to apply a colorkey too [grin]

Share this post


Link to post
Share on other sites
Washu- You don't have to go through all that mess

From the SDL docs

SDL_Surface *SDL_DisplayFormatAlpha(SDL_Surface *surface);
Description
This function takes a surface and copies it to a new surface of the pixel format and colors of the video framebuffer plus an alpha channel, suitable for fast blitting onto the display surface. It calls SDL_ConvertSurface.

If you want to take advantage of hardware colorkey or alpha blit acceleration, you should set the colorkey and alpha value before calling this function.

This function can be used to convert a colorkey to an alpha channel, if the SDL_SRCCOLORKEY flag is set on the surface. The generated surface will then be transparent (alpha=0) where the pixels match the colorkey, and opaque (alpha=255) elsewhere.


Or the non Alpha version
SDL_Surface *SDL_DisplayFormat(SDL_Surface *surface);
Description
This function takes a surface and copies it to a new surface of the pixel format and colors of the video framebuffer, suitable for fast blitting onto the display surface. It calls SDL_ConvertSurface.

If you want to take advantage of hardware colorkey or alpha blit acceleration, you should set the colorkey and alpha value before calling this function.




P.S. How do you put code on this forum?

Share this post


Link to post
Share on other sites
Thanks alot guy for all te information. I switched the MIN MAG filters in Texparam to GL_LINEAR and the LOD param to 0 and it works fine untill I loaded a non-power-of-two surface. But THEN I used glu_BuildMipmap() and it works fine now. Thanks again.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Announcements

  • Forum Statistics

    • Total Topics
      628345
    • Total Posts
      2982192
  • Similar Content

    • By test opty
      Hi all,
       
      I'm starting OpenGL using a tut on the Web. But at this point I would like to know the primitives needed for creating a window using OpenGL. So on Windows and using MS VS 2017, what is the simplest code required to render a window with the title of "First Rectangle", please?
       
       
    • By DejayHextrix
      Hi, New here. 
      I need some help. My fiance and I like to play this mobile game online that goes by real time. Her and I are always working but when we have free time we like to play this game. We don't always got time throughout the day to Queue Buildings, troops, Upgrades....etc.... 
      I was told to look into DLL Injection and OpenGL/DirectX Hooking. Is this true? Is this what I need to learn? 
      How do I read the Android files, or modify the files, or get the in-game tags/variables for the game I want? 
      Any assistance on this would be most appreciated. I been everywhere and seems no one knows or is to lazy to help me out. It would be nice to have assistance for once. I don't know what I need to learn. 
      So links of topics I need to learn within the comment section would be SOOOOO.....Helpful. Anything to just get me started. 
      Thanks, 
      Dejay Hextrix 
    • By mellinoe
      Hi all,
      First time poster here, although I've been reading posts here for quite a while. This place has been invaluable for learning graphics programming -- thanks for a great resource!
      Right now, I'm working on a graphics abstraction layer for .NET which supports D3D11, Vulkan, and OpenGL at the moment. I have implemented most of my planned features already, and things are working well. Some remaining features that I am planning are Compute Shaders, and some flavor of read-write shader resources. At the moment, my shaders can just get simple read-only access to a uniform (or constant) buffer, a texture, or a sampler. Unfortunately, I'm having a tough time grasping the distinctions between all of the different kinds of read-write resources that are available. In D3D alone, there seem to be 5 or 6 different kinds of resources with similar but different characteristics. On top of that, I get the impression that some of them are more or less "obsoleted" by the newer kinds, and don't have much of a place in modern code. There seem to be a few pivots:
      The data source/destination (buffer or texture) Read-write or read-only Structured or unstructured (?) Ordered vs unordered (?) These are just my observations based on a lot of MSDN and OpenGL doc reading. For my library, I'm not interested in exposing every possibility to the user -- just trying to find a good "middle-ground" that can be represented cleanly across API's which is good enough for common scenarios.
      Can anyone give a sort of "overview" of the different options, and perhaps compare/contrast the concepts between Direct3D, OpenGL, and Vulkan? I'd also be very interested in hearing how other folks have abstracted these concepts in their libraries.
    • By aejt
      I recently started getting into graphics programming (2nd try, first try was many years ago) and I'm working on a 3d rendering engine which I hope to be able to make a 3D game with sooner or later. I have plenty of C++ experience, but not a lot when it comes to graphics, and while it's definitely going much better this time, I'm having trouble figuring out how assets are usually handled by engines.
      I'm not having trouble with handling the GPU resources, but more so with how the resources should be defined and used in the system (materials, models, etc).
      This is my plan now, I've implemented most of it except for the XML parts and factories and those are the ones I'm not sure of at all:
      I have these classes:
      For GPU resources:
      Geometry: holds and manages everything needed to render a geometry: VAO, VBO, EBO. Texture: holds and manages a texture which is loaded into the GPU. Shader: holds and manages a shader which is loaded into the GPU. For assets relying on GPU resources:
      Material: holds a shader resource, multiple texture resources, as well as uniform settings. Mesh: holds a geometry and a material. Model: holds multiple meshes, possibly in a tree structure to more easily support skinning later on? For handling GPU resources:
      ResourceCache<T>: T can be any resource loaded into the GPU. It owns these resources and only hands out handles to them on request (currently string identifiers are used when requesting handles, but all resources are stored in a vector and each handle only contains resource's index in that vector) Resource<T>: The handles given out from ResourceCache. The handles are reference counted and to get the underlying resource you simply deference like with pointers (*handle).  
      And my plan is to define everything into these XML documents to abstract away files:
      Resources.xml for ref-counted GPU resources (geometry, shaders, textures) Resources are assigned names/ids and resource files, and possibly some attributes (what vertex attributes does this geometry have? what vertex attributes does this shader expect? what uniforms does this shader use? and so on) Are reference counted using ResourceCache<T> Assets.xml for assets using the GPU resources (materials, meshes, models) Assets are not reference counted, but they hold handles to ref-counted resources. References the resources defined in Resources.xml by names/ids. The XMLs are loaded into some structure in memory which is then used for loading the resources/assets using factory classes:
      Factory classes for resources:
      For example, a texture factory could contain the texture definitions from the XML containing data about textures in the game, as well as a cache containing all loaded textures. This means it has mappings from each name/id to a file and when asked to load a texture with a name/id, it can look up its path and use a "BinaryLoader" to either load the file and create the resource directly, or asynchronously load the file's data into a queue which then can be read from later to create the resources synchronously in the GL context. These factories only return handles.
      Factory classes for assets:
      Much like for resources, these classes contain the definitions for the assets they can load. For example, with the definition the MaterialFactory will know which shader, textures and possibly uniform a certain material has, and with the help of TextureFactory and ShaderFactory, it can retrieve handles to the resources it needs (Shader + Textures), setup itself from XML data (uniform values), and return a created instance of requested material. These factories return actual instances, not handles (but the instances contain handles).
       
       
      Is this a good or commonly used approach? Is this going to bite me in the ass later on? Are there other more preferable approaches? Is this outside of the scope of a 3d renderer and should be on the engine side? I'd love to receive and kind of advice or suggestions!
      Thanks!
    • By nedondev
      I 'm learning how to create game by using opengl with c/c++ coding, so here is my fist game. In video description also have game contain in Dropbox. May be I will make it better in future.
      Thanks.
  • Popular Now