You left a few details out ... are you suggesting this?

your have a struture which contains a vector of char pointers? ... like this:

  struct MyStructType  {  std::vector<char*> text;  }  

of that you have a vector of structures that contain char pointers ... like this:

  struct MyStructType2  {  char *text;  }std::vector<MyStructType2> myVector;  

in the general sense, an STL container calls the destructors on elements it erases ... but that means this:

  std::vector<MyClass> vector1;std::vector<MyClass*> vector2;  

the elements of vector1 will be destroyed properly ... the elements of vector2 (the pointers themselves) will be destroyed .. but the items they point to will not ... so if you allocated the memory somewhere ... and are not deleting it elsewhere ... it''s getting leaked.

understand?

and in the case of having structures with pointers ... IF the structure is supposed to OWN the memory (meaning it has the responsibility of deleting it) ... then you must write a destructor for you structure ... which deletes the buffer. Assuming you do this:

  struct MyStruct3  {  ~MyStruct3(void) {delete[] text;}  char *text;  }  

then your class properly handles it''s ownership of the buffer (assuming it was allocated correctly using new[] and assigned into the text variable correctly). But you still have to be sure you delete your MyStruct3 variables ... so in the following

  std::vector<MyStruct3> items;std::vector<MyStruct3*> itemRefs;  

the items variable would handle the ownership issues ... but itemRefs leaves the deletion of the items to someone else ...

so ... if you read this and your eyes glaze over ... post a more detailed and specific question ... I''ll do what i can.

Good Luck

Here's the part of the code that's the problem:

TEXT t;t = new char[strlen("hello")];strcpy(t.text, "hello");t.ypos = y;t.color = color[c];g_TextVector.push_back(t); 

t isn't a char*, it's a local TEXT object. It already has memory allocated to it on the stack holding the contents of an uninitialized TEXT structure. I'm not really sure if the line "t = new char[strlen("hello")];" will compile--you're assigning new memory to an object that isn't even a pointer.

This is what you should have

TEXT t;t.text = new char[strlen ("hello")+1]; // need +1 for null charstrcpy (t.text, "hello");t.ypos = y;t.color = color[c];g_TextVector.push_back(t);  

What you have for erasing the data should work now when you uncomment the delete [] ob->text line. vector::erase will erase the TEXT entry from the container. It will also call the destructor for TEXT, but since you didn't declare one, it doesn't do anything; you have to manually release all objects owned by TEXT yourself, in this case the char *text.


Edited by - Stoffel on February 19, 2001 12:28:24 AM